From: nick huang <nickhuang99@hotmail.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: [PATCH] c++: Fix unnecessary error when top-level cv-qualifiers is dropped [PR101783]
Date: Tue, 10 Aug 2021 05:36:11 +0000 [thread overview]
Message-ID: <DM5PR0501MB37336BCE03A8F8D0D77C2780B5F79@DM5PR0501MB3733.namprd05.prod.outlook.com> (raw)
The root cause of this bug is that it considers reference with cv-qualifiers
as an error by generating value for variable "bad_quals". However, this is
not correct for case of typedef. Here I quote spec:
"Cv-qualified references are ill-formed except when the cv-qualifiers
are introduced through the use of a typedef-name ([dcl.typedef],
[temp.param]) or decltype-specifier ([dcl.type.decltype]),
in which case the cv-qualifiers are ignored."
2021-08-09 Qingzhe Huang <nickhuang99@hotmail.com>
PR c++/101387
gcc/cp/ChangeLog:
PR c++/101387
* tree.c (cp_build_qualified_type_real): Excluding typedef from error
gcc/testsuite/ChangeLog:
PR c++/101387
* g++.dg/parse/pr101783.C: New test.
diff --git gcc/cp/tree.c gcc/cp/tree.c
index 10b818d1370..a4ae3eee6d0 100644
--- gcc/cp/tree.c
+++ gcc/cp/tree.c
@@ -1361,11 +1361,18 @@ cp_build_qualified_type_real (tree type,
/* A reference or method type shall not be cv-qualified.
[dcl.ref], [dcl.fct]. This used to be an error, but as of DR 295
(in CD1) we always ignore extra cv-quals on functions. */
+ /* Cv-qualified references are ill-formed except when the cv-qualifiers
+ are introduced through the use of a typedef-name ([dcl.typedef],
+ [temp.param]) or decltype-specifier ([dcl.type.decltype]),
+ in which case the cv-qualifiers are ignored. */
if (type_quals & (TYPE_QUAL_CONST | TYPE_QUAL_VOLATILE)
&& (TYPE_REF_P (type)
|| FUNC_OR_METHOD_TYPE_P (type)))
{
- if (TYPE_REF_P (type))
+ if (TYPE_REF_P (type)
+ //A reference from typedef is not an error, but ignored.
+ && (!typedef_variant_p (type) || FUNC_OR_METHOD_TYPE_P (type)))
bad_quals |= type_quals & (TYPE_QUAL_CONST | TYPE_QUAL_VOLATILE);
type_quals &= ~(TYPE_QUAL_CONST | TYPE_QUAL_VOLATILE);
}
diff --git gcc/testsuite/g++.dg/parse/pr101783.C gcc/testsuite/g++.dg/parse/pr101783.C
new file mode 100644
index 00000000000..8f8f8b1faeb
--- /dev/null
+++ gcc/testsuite/g++.dg/parse/pr101783.C
@@ -0,0 +1,10 @@
+template<class T> struct A{
+ typedef T& Type;
+};
+template<class T>
+void f(const typename A<T>::Type){}
+template<>
+void f<int>(const typename A<int>::Type){}
+struct B{};
+template<>
+void f<B>(const A<B>::Type){}
next reply other threads:[~2021-08-10 5:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 5:36 nick huang [this message]
2021-08-24 15:29 ` Jonathan Wakely
2021-08-28 11:54 ` [PATCH] c++: Suppress error when cv-qualified reference is introduced by typedef [PR101783] nick huang
2021-09-24 11:15 ` *PING* " nick huang
2021-09-24 20:33 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR0501MB37336BCE03A8F8D0D77C2780B5F79@DM5PR0501MB3733.namprd05.prod.outlook.com \
--to=nickhuang99@hotmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).