From: Bernd Edlinger <bernd.edlinger@hotmail.de>
To: Mike Stump <mikestump@comcast.net>
Cc: Jakub Jelinek <jakub@redhat.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: RE: [PATCH] Fix sporadic failure in g++.dg/tsan/aligned_vs_unaligned_race.C
Date: Sat, 03 Jan 2015 11:20:00 -0000 [thread overview]
Message-ID: <DUB118-W292D09896C48BED7B29B14E45A0@phx.gbl> (raw)
In-Reply-To: <3C12133C-DABF-40FA-94F7-9DB785F6E914@comcast.net>
On Sat, 3 Jan 2015 01:51:34, Mike Strump wrote:
>
> On Jan 3, 2015, at 1:01 AM, Bernd Edlinger <bernd.edlinger@hotmail.de> wrote:
>> the test case g++.dg/tsan/aligned_vs_unaligned_race.C
>> still fails sporadically (around 1 out of 100 times).
>> That is apparently a race condition in the tsan runtime itself.
>> To make the test reproducible pass, I need to add a sleep(1)
>> in one of the two threads.
>>
>>
>> Tested really often with:
>> make check-gcc-c++ RUNTESTFLAGS="tsan.exp=*"
>>
>> OK for trunk?
>
> No. sleep can never fix race conditions. The only time sleep can fix a race condition would be in a hard real time system, and, that in general doesn’t apply to anything in the gcc test suite.
Yes, but all other tsan test cases call sleep(1) too.
The sleep does not really "fix" the race condition but it changes
the likelihood from 1 / 100 to 1 / 10^20.
That is just to avoid noise from sporadic test failures.
Bernd.
next prev parent reply other threads:[~2015-01-03 11:20 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-03 9:01 Bernd Edlinger
2015-01-03 9:51 ` Mike Stump
2015-01-03 11:20 ` Bernd Edlinger [this message]
2015-01-04 17:00 ` Bernd Edlinger
2015-01-04 19:07 ` Mike Stump
2015-01-04 19:17 ` Jakub Jelinek
2015-01-04 19:44 ` Bernd Edlinger
2015-01-04 22:19 ` Mike Stump
2015-01-05 8:49 ` Bernd Edlinger
2015-01-05 20:58 ` Mike Stump
2015-01-05 22:02 ` Mike Stump
2015-01-06 1:07 ` Bernd Edlinger
2015-01-06 9:08 ` Bernd Edlinger
2015-01-06 9:16 ` Jakub Jelinek
2015-01-06 9:38 ` Bernd Edlinger
2015-01-06 17:45 ` Bernd Edlinger
2015-01-06 19:48 ` Mike Stump
2015-01-06 23:22 ` Bernd Edlinger
2015-01-07 0:33 ` Mike Stump
2015-01-07 7:17 ` Bernd Edlinger
2015-01-07 8:23 ` Jakub Jelinek
2015-01-07 14:55 ` Bernd Edlinger
2015-01-07 15:04 ` Jakub Jelinek
2015-01-07 16:58 ` Mike Stump
2015-01-07 17:00 ` Jakub Jelinek
2015-01-07 18:21 ` Bernd Edlinger
2015-01-07 18:32 ` Jakub Jelinek
2015-01-07 22:44 ` Bernd Edlinger
2015-01-08 19:24 ` Mike Stump
2015-01-08 19:29 ` Jakub Jelinek
2015-01-08 21:07 ` Mike Stump
2015-01-08 21:27 ` Jakub Jelinek
2015-01-08 22:06 ` Mike Stump
2015-01-08 22:23 ` Bernd Edlinger
2015-01-09 15:36 ` Bernd Edlinger
2015-01-09 15:37 ` Jakub Jelinek
2015-01-19 8:53 ` Dmitry Vyukov
2015-01-19 15:16 ` Mike Stump
2015-01-21 8:52 ` Dmitry Vyukov
2015-01-21 9:02 ` Jakub Jelinek
2015-01-21 9:07 ` Dmitry Vyukov
2015-01-08 19:10 ` Mike Stump
2015-01-07 16:36 ` Mike Stump
2015-01-06 21:29 ` Mike Stump
2015-01-04 19:05 ` Mike Stump
2015-01-04 19:15 ` Jakub Jelinek
2015-01-04 21:48 ` Bernd Edlinger
2015-01-04 21:58 ` Mike Stump
2015-01-04 22:20 ` Bernd Edlinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DUB118-W292D09896C48BED7B29B14E45A0@phx.gbl \
--to=bernd.edlinger@hotmail.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=mikestump@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).