public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Bernd Edlinger <bernd.edlinger@hotmail.de>
To: Kirill Yukhin <kirill.yukhin@gmail.com>,
	Andrey Turetskiy	<andrey.turetskiy@intel.com>
Cc: Jakub Jelinek <jakub@redhat.com>, Ilya Verbin <iverbin@gmail.com>,
	"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing
Date: Fri, 21 Nov 2014 18:44:00 -0000	[thread overview]
Message-ID: <DUB118-W39F20F36D26B91274E4A4E4770@phx.gbl> (raw)

Aehm Kirill,

excuse me please, but if I do

autogen Makefile.def


I get this from svn diff

Index: Makefile.in
===================================================================
--- Makefile.in    (revision 217890)
+++ Makefile.in    (working copy)
@@ -35238,9 +35238,6 @@
     $(SHELL) $(srcdir)/mkinstalldirs $(TARGET_SUBDIR)/liboffloadmic ; \
     $(NORMAL_TARGET_EXPORTS)  \
     echo Configuring in $(TARGET_SUBDIR)/liboffloadmic; \
-     \
-    this_target="${target_alias}"; \
-     \
     cd "$(TARGET_SUBDIR)/liboffloadmic" || exit 1; \
     case $(srcdir) in \
       /* | [A-Za-z]:[\\/]*) topdir=$(srcdir) ;; \
@@ -35248,14 +35245,12 @@
         sed -e 's,\./,,g' -e 's,[^/]*/,../,g' `$(srcdir) ;; \
     esac; \
     module_srcdir=liboffloadmic; \
-    srcdiroption="--srcdir=$${topdir}/liboffloadmic"; \
-    libsrcdir="$$s/liboffloadmic"; \
     rm -f no-such-file || : ; \
     CONFIG_SITE=no-such-file $(SHELL) \
       $$s/$$module_srcdir/configure \
       --srcdir=$${topdir}/$$module_srcdir \
       $(TARGET_CONFIGARGS) --build=${build_alias} --host=${target_alias} \
-      --target=$${this_target} $${srcdiroption} @extra_liboffloadmic_configure_flags@ \
+      --target=${target_alias} @extra_liboffloadmic_configure_flags@ \
       || exit 1
 @endif target-liboffloadmic
 

svn blame Makefile.in points to:

r217498 | kyukhin | 2014-11-13 15:03:17 +0100 (Thu, 13 Nov 2014) | 110 lines

[PATCH 2/4] OpenMP 4.0 offloading to Intel MIC: liboffloadmic.

    * Makefile.def: Add liboffloadmic to target_modules.  Make
    liboffloadmic depend on libgomp's configure, libstdc++ and libgcc.
    * Makefile.in: Regenerate.
    * configure: Regenerate.
    * configure.ac: Add liboffloadmic to target binaries.
    Restrict liboffloadmic for POSIX and i*86, and x86_64 architectures.
    Add liboffloadmic to noconfig list when C++ is not supported.


so, did you really regenerate Makefile.in in that patch, or am I missing something ?


Regards,
Bernd.
 		 	   		  

             reply	other threads:[~2014-11-21 18:20 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-21 18:44 Bernd Edlinger [this message]
2014-11-21 18:59 ` Ilya Verbin
2014-11-21 19:01   ` Bernd Edlinger
2014-11-21 19:34     ` Ilya Verbin
2014-11-21 20:07       ` Jakub Jelinek
  -- strict thread matches above, loose matches on Subject: below --
2014-10-21 17:16 [PATCH 0/4] OpenMP 4.0 offloading to Intel MIC Ilya Verbin
2014-10-30 12:45 ` [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing Ilya Verbin
2014-11-06 17:55   ` Jakub Jelinek
2014-11-10 14:51     ` Ilya Verbin
2014-11-11  7:10       ` Jakub Jelinek
2014-11-12  9:18       ` Jakub Jelinek
2014-12-17 22:53       ` Thomas Schwinge
2014-12-18 10:46         ` Jakub Jelinek
2014-12-22 16:37           ` Thomas Schwinge
2014-12-18 15:56   ` Thomas Schwinge
2014-12-18 17:43     ` Ilya Verbin
2014-12-18 17:56       ` Jakub Jelinek
2014-12-22 11:49       ` Thomas Schwinge
2014-12-22 12:50         ` Jakub Jelinek
2015-01-15 19:21           ` Ilya Verbin
2015-01-15 19:25             ` Jakub Jelinek
2015-01-28 17:28               ` Ilya Verbin
2015-01-28 17:42                 ` Jakub Jelinek
2015-01-28 17:51                   ` Ilya Verbin
2015-02-02 14:03                     ` Ilya Verbin
2014-12-26 20:53         ` Ilya Verbin
2015-01-08 16:03           ` Thomas Schwinge
2016-03-13 19:10   ` Thomas Schwinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DUB118-W39F20F36D26B91274E4A4E4770@phx.gbl \
    --to=bernd.edlinger@hotmail.de \
    --cc=andrey.turetskiy@intel.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=iverbin@gmail.com \
    --cc=jakub@redhat.com \
    --cc=kirill.yukhin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).