From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id 9126D3858C56 for ; Fri, 14 Oct 2022 08:24:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9126D3858C56 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=googlemail.com Received: by mail-wm1-x32c.google.com with SMTP id n9so2646196wms.1 for ; Fri, 14 Oct 2022 01:24:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=aEjZlclY7O4FGapACLwADmnjitHXjGx31Kr5Jb4UU1I=; b=JwlYNTPL3btNy2Nwj0Qdl7bWG6jg9iO+/1n/GvUkEJ957Jg2Tp0XtOoDF0C0UKa0Ux 3U7cFgxM4gZjCCRF4ipvTR/mrMNBOC4rHF22RHv50Orb7zNf2jsHF+nl14tzMwPhE6Sc roN/o8eDtaiSPzZ+3uJSBxw7M02BB3QqQAHDlY3V7Jl75HA1hfP3TVAghIOAXBwZsuwU 0c2MibPjyohef68Uf6vRJfIpODsRw1wYx/R674+BC9QcGWiGcCr5+chyQvq8mI6pOZ8q 4T6kaV8R1FBc5XEbXbFqTyVe8BWlm8EhXEu22QHUPEbKO0r7w9vJUu0jHoXQHsKC9IzA UOZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aEjZlclY7O4FGapACLwADmnjitHXjGx31Kr5Jb4UU1I=; b=tfv7y7pTxGBjhuIwx7jvVDI+l10qDcM8KjVcggZ/9q6NSUdbHO5dH0CsqNe2+aSzOo lBpVB0Mm+rA78/zH3D2vgIW0YLBn6jSx3TTg02/DZKf7Ly3uZndIHc0lnBfzUorR2INj w2Ks4yn5n7A6LNTzbEJKJBw7JCs9LSE8QOI2iVsAoMJMmwTU5Ezn0BaogFDGa/DKmPi4 mXXJ4FMvMYidWTBselUSv8UwXDZZt1XgqIBOOJdBCXf8R4NWUD1rb9UA/foGRC5UkUm5 QRa8h1DbKHRXBdY2RR6Ih1W1awZJSWJ8C8wHtlCWmtKLUWNcaRIkk8VbR3NM+3WfnhnK Vl+Q== X-Gm-Message-State: ACrzQf1vnSJXdg2czf+0vUIXulR3iDH1OmW9VNEDY27PVYWKocIQqfr5 Slw9iHYeX5cQiAkwvf7Atpk= X-Google-Smtp-Source: AMsMyM7LNG0HQJyJZE8LQroj8eNCvSYhTa/taxcQbUUrjRZCamJGTdMeDzV2vztupWkTqv6JxHPagw== X-Received: by 2002:a05:600c:1f16:b0:3b4:f20e:6463 with SMTP id bd22-20020a05600c1f1600b003b4f20e6463mr9430389wmb.56.1665735870167; Fri, 14 Oct 2022 01:24:30 -0700 (PDT) Received: from [192.168.1.95] (host81-138-1-83.in-addr.btopenworld.com. [81.138.1.83]) by smtp.googlemail.com with ESMTPSA id i29-20020a1c541d000000b003c41144b3cfsm6452178wmb.20.2022.10.14.01.24.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Oct 2022 01:24:29 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Subject: Re: [PATCH 0/6] Add Intel Sierra Forest Instructions From: Iain Sandoe In-Reply-To: Date: Fri, 14 Oct 2022 09:24:28 +0100 Cc: Haochen Jiang , hongtao.liu@intel.com, GCC Patches Content-Transfer-Encoding: quoted-printable Message-Id: References: <20221014075445.7938-1-haochen.jiang@intel.com> To: Hongtao Liu X-Mailer: Apple Mail (2.3608.120.23.2.7) X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On 14 Oct 2022, at 09:20, Hongtao Liu wrote: >=20 > On Fri, Oct 14, 2022 at 4:14 PM Iain Sandoe via Gcc-patches > wrote: >>=20 >> Hi Haochen >>=20 >>> On 14 Oct 2022, at 08:54, Haochen Jiang via Gcc-patches = wrote: >>>=20 >>=20 >>> These six patches aimed to add Intel Sierra Forest instructions, = including >>> AVX-IFMA, AVX-VNNI0INT8, AVX-NE-CONVERT, CMPccXADD. We also added = intrinsic >>> for vector __bf16 in this series of patch and Sierra Forest Support. >>>=20 >>> The information is based on newly released >>> Intel Architecture Instruction Set Extensions and Future Features. >>>=20 >>> The document comes following: >>> = https://www.intel.com/content/www/us/en/develop/download/intel-architectur= e-instruction-set-extensions-programming-reference.html >>>=20 >>> Regtested on x86_64-pc-linux-gnu. Ok for trunk? >>=20 >> Have you tested that the testcases work on older platforms that do = not have support >> for the new instructions in their assemblers? >>=20 >> I could not see any target-requires changes in the testcases .. hence = my question. >>=20 > Guess you are looking at compile tests? yes, compile tests would need support from the assembler. >=20 > For runtime test, we have add assembler check(target-requires changed) > plus runtime check(builtin_cpu_supports) > .i.e. >=20 > +++ b/gcc/testsuite/gcc.target/i386/avx-ifma-vpmaddhuq-2.c > @@ -0,0 +1,72 @@ > +/* { dg-do run } */ > +/* { dg-options "-O2 -mavxifma" } */ > +/* { dg-require-effective-target avxifma } */ >=20 > Do I miss some? I would need to look at the sources after patching (perhaps they already = have=20 suitable target-requires that did not show up in the patch). Do you have this series as a branch somewhere that I can try on one of = the like affected platforms?=20 Iain