From: FX <fxcoudert@gmail.com>
To: gcc-patches@gcc.gnu.org
Cc: Tobias Burnus <burnus@net-b.de>,
Ian Lance Taylor <iant@google.com>,
Richard Henderson <rth@redhat.com>
Subject: Re: [patch] Separate {OS,CPU}_CPP_BUILTINS macros into C-family and language-independent macros
Date: Wed, 20 Oct 2010 22:34:00 -0000 [thread overview]
Message-ID: <E1BC1F62-6546-4387-BE78-9A47D24AA02B@gmail.com> (raw)
In-Reply-To: <4CB9F146.30804@net-b.de>
ping ** 2
http://gcc.gnu.org/ml/gcc-patches/2010-10/threads.html#00566
This patch needs global reviewers approval.
> The attached patch fixes PR 42954: when Fortran moved to using libcpp directly from the front-end (instead of calling cc1 to do its preprocessing), we lost all target-specific CPP built-in macros. The issue is that part of the code in TARGET_OS_CPP_BUILTINS and TARGET_CPU_CPP_BUILTINS depends on C-only flags, and thus cannot be moved to a directory outside gcc/c-family/.
>
> The patch moves this C-only code to specific TARGET_OS_CPP_BUILTINS_CFAMILY and TARGET_CPU_CPP_BUILTINS_CFAMILY macros. I manually audited all the targets in config/ twice, to check that I did not leave any code behind. I have bootstrapped and regtested an all-language compiler on x86_64-linux and i686-darwin. I have also built C and Fortran cross-compilers (make all-gcc&& make fortran) for the following targets (which cover all gcc/config/ files changed):
>
> avr-elf
> frv-elf
> spu-elf
> i386-pc-netware
> alpha-linux
> ia64-hpux
> mips-linux
> mips-sgi-irix6.5
> hppa2.0w-hp-hpux11.00
> sparc-sun-solaris2.10
> i686-pc-mingw32
> powerpc-darwin
>
> In all cases, the cross-compiler built successfully and seemed to work. In each case, I checked a few of the target-specific macros (but did not check all of them).
>
>
> I also tried to build cross-compilers for the following i386-pc-interix3 and alpha-dec-osf5.1, but they failed to build even without my patch:
>
> -- i386-pc-interix3 fails to build winnt.c over use of undeclared use_pe_aligned_common()
> -- alpha-dec-osf5.1 fails to build mips-tfile.o
>
> Rainer (as osf maintainer) is CC'ed to this mail. Interix hasn't seen a specific patch for it (not part of mechanical changes) since 2003, and I don't know whom to forward this information to.
>
>
> OK to commit?
next prev parent reply other threads:[~2010-10-20 22:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 10:49 FX
2010-10-07 11:14 ` Rainer Orth
2010-10-07 12:31 ` FX
2010-10-07 12:46 ` FX
2010-10-08 8:56 ` Tobias Burnus
2010-10-08 20:29 ` Rainer Orth
2010-10-16 19:44 ` Tobias Burnus
2010-10-20 22:34 ` FX [this message]
2010-11-03 21:29 FX
2010-11-03 22:34 ` Weddington, Eric
2010-11-03 22:35 ` FX
2010-11-04 17:05 ` Rainer Orth
2010-11-06 0:06 ` Jerry DeLisle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1BC1F62-6546-4387-BE78-9A47D24AA02B@gmail.com \
--to=fxcoudert@gmail.com \
--cc=burnus@net-b.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=iant@google.com \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).