[PING] PR 28322 unknown -Wno-* options should cause warnings, not errors

[PING] PR 28322 unknown -Wno-* options should cause warnings, not errors

[Peter Maydell]

This is a ping for this patch:

http://gcc.gnu.org/ml/gcc-patches/2008-06/msg00139.html

which fixes a problem with the initial fix for PR 28322 (which
suppresses messages about unknown -Wno-* options unless some other
diagnostic is being emitted). The code as it stands in SVN means
that -Wno-unrecognised-something sometimes changes the exit status
of gcc, whereas it was intended to never have that effect.

The discussion got derailed into whether the original feature was
a good idea, but nobody seemed to be complaining about the patch
itself. Can it be applied?

thanks
-- Peter Maydell

Re: [PING] PR 28322 unknown -Wno-* options should cause warnings, not errors

[Ian Lance Taylor]

Peter Maydell <pmaydell+gcc@chiark.greenend.org.uk> writes:

> This is a ping for this patch:
>
> http://gcc.gnu.org/ml/gcc-patches/2008-06/msg00139.html
>
> which fixes a problem with the initial fix for PR 28322 (which
> suppresses messages about unknown -Wno-* options unless some other
> diagnostic is being emitted). The code as it stands in SVN means
> that -Wno-unrecognised-something sometimes changes the exit status
> of gcc, whereas it was intended to never have that effect.
>
> The discussion got derailed into whether the original feature was
> a good idea, but nobody seemed to be complaining about the patch
> itself. Can it be applied?

This patch is OK.

Thanks.

Ian

Re: [PING] PR 28322 unknown -Wno-* options should cause warnings, not errors

[Peter Maydell]

Ian Lance Taylor wrote:
>Peter Maydell <pmaydell+gcc@chiark.greenend.org.uk> writes:
>> This is a ping for this patch:
>>
>> http://gcc.gnu.org/ml/gcc-patches/2008-06/msg00139.html

>This patch is OK.

Thanks. What's the process for causing the patch to actually get applied
to SVN? http://gcc.gnu.org/contribute.html isn't clear on the point for
the case where the patch submitter doesn't have write-after-approval.

-- PMM

Re: [PING] PR 28322 unknown -Wno-* options should cause warnings, not errors

[Ian Lance Taylor]

Peter Maydell <pmaydell+gcc@chiark.greenend.org.uk> writes:

> Ian Lance Taylor wrote:
>>Peter Maydell <pmaydell+gcc@chiark.greenend.org.uk> writes:
>>> This is a ping for this patch:
>>>
>>> http://gcc.gnu.org/ml/gcc-patches/2008-06/msg00139.html
>
>>This patch is OK.
>
> Thanks. What's the process for causing the patch to actually get applied
> to SVN? http://gcc.gnu.org/contribute.html isn't clear on the point for
> the case where the patch submitter doesn't have write-after-approval.

Anybody with write access want to volunteer to apply this patch?

Ian

Re: [PING] PR 28322 unknown -Wno-* options should cause warnings, not errors

[Matthias Klose]

Ian Lance Taylor writes:
> Peter Maydell <pmaydell+gcc@chiark.greenend.org.uk> writes:
> 
> > Ian Lance Taylor wrote:
> >>Peter Maydell <pmaydell+gcc@chiark.greenend.org.uk> writes:
> >>> This is a ping for this patch:
> >>>
> >>> http://gcc.gnu.org/ml/gcc-patches/2008-06/msg00139.html
> >
> >>This patch is OK.
> >
> > Thanks. What's the process for causing the patch to actually get applied
> > to SVN? http://gcc.gnu.org/contribute.html isn't clear on the point for
> > the case where the patch submitter doesn't have write-after-approval.
> 
> Anybody with write access want to volunteer to apply this patch?

done.

  Matthias

PATCH for Re: [PING] PR 28322 unknown -Wno-* options should cause warnings, not errors

[Gerald Pfeifer]

Hej Peter,

I know it's been a while, but I had queued your message to actually
improve our documentation.

Please find my first attempt at this below. I have committed this patch, 
so it now shows up at http://gcc.gnu.org/contribute.html.  If you have
any thoughts or suggestions for improvement, please let me know!

(The part relevant to your request is the last part of the patch, the
rest moves and shortens the description of "without further approval").

Gerald

On Wed, 9 Jul 2008, Peter Maydell wrote:
>> This patch is OK.
> Thanks. What's the process for causing the patch to actually get applied
> to SVN? http://gcc.gnu.org/contribute.html isn't clear on the point for
> the case where the patch submitter doesn't have write-after-approval.

Index: contribute.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/contribute.html,v
retrieving revision 1.70
diff -u -3 -p -r1.70 contribute.html
--- contribute.html	6 Aug 2008 21:57:16 -0000	1.70
+++ contribute.html	26 Jan 2009 00:20:48 -0000
@@ -276,20 +276,24 @@ changing.)  For further information on t
 the <a href="svn.html">Anonymous read-only SVN access</a> and <a
 href="svnwrite.html">Read-write SVN access</a> pages.</p>
 
+<p>(Everything listed here still applies if you can check in the patch
+without further approval under the <a
+href="svnwrite.html#policies">GCC write access policies</a>, except
+that ChangeLog entries may be included as part of the patch and diffs
+representing totally new files may be omitted (especially if large).)</p> 
+
+<h3>Pinging patches, Getting patches applied</h3>
+
 <p>If you do not receive a response to a patch that you have submitted
 within two weeks or so, it may be a good idea to chase it by sending a
 follow-up email to the same list(s).  Patches can occasionally fall through
 the cracks.  Please be sure to include a brief summary of the patch and the
 URL of the entry in the mailing list archive of the original submission.</p>
 
-<p>Everything listed here still applies if you can check in the patch
-without further approval under the <a
-href="svnwrite.html#policies">GCC write access policies</a>, except
-that ChangeLog entries may be included as part of the patch since
-no-one else will need to apply it to the tree later and diffs representing
-totally new files may be omitted (especially if large) since they can be
-accessed directly from the repository.</p>
-
+<p>If you do not have write access and a patch of yours has been approved,
+but not committed, please advise the approver of that fact.  You may want
+to point out lack of write access in your initial submission, too.</p>
+ 
 
 <h2><a name="announce">Announcing Changes (to our Users)</a></h2>
 

Re: PATCH for Re: [PING] PR 28322 unknown -Wno-* options should cause warnings, not errors

[Peter Maydell]

Gerald Pfeifer wrote:
>I know it's been a while, but I had queued your message to actually
>improve our documentation.
>
>Please find my first attempt at this below. I have committed this patch, 
>so it now shows up at http://gcc.gnu.org/contribute.html.  If you have
>any thoughts or suggestions for improvement, please let me know!

Thanks, that covers the problem I had.

>(The part relevant to your request is the last part of the patch, the
>rest moves and shortens the description of "without further approval").

The new text here made me do a double-take at the "totally new files
may be omitted" bit -- given the rationale in the old version it makes
sense, but this change deletes the rationale. But of course this bit
of the docs doesn't really apply to me so I don't feel strongly about
it.

-- PMM

Re: PATCH for Re: [PING] PR 28322 unknown -Wno-* options should cause warnings, not errors

[Gerald Pfeifer]

On Mon, 26 Jan 2009, Peter Maydell wrote:
>>(The part relevant to your request is the last part of the patch, the
>>rest moves and shortens the description of "without further approval").
> The new text here made me do a double-take at the "totally new files
> may be omitted" bit -- given the rationale in the old version it makes
> sense, but this change deletes the rationale. But of course this bit
> of the docs doesn't really apply to me so I don't feel strongly about
> it.

Thanks for the additional feedback, Peter.  I committed the patch
below which tweaks that sentence and re-adds the piece you are
referring to.

Gerald

Index: contribute.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/contribute.html,v
retrieving revision 1.71
diff -u -3 -p -r1.71 contribute.html
--- contribute.html	26 Jan 2009 00:24:59 -0000	1.71
+++ contribute.html	26 Jan 2009 19:29:39 -0000
@@ -280,7 +280,8 @@ href="svnwrite.html">Read-write SVN acce
 without further approval under the <a
 href="svnwrite.html#policies">GCC write access policies</a>, except
 that ChangeLog entries may be included as part of the patch and diffs
-representing totally new files may be omitted (especially if large).)</p> 
+representing new files may be omitted, especially if large, since they
+can be accessed directly from the repository.)</p> 
 
 <h3>Pinging patches, Getting patches applied</h3>