From: Ankur Saini <arsenic.secondary@gmail.com>
To: "Martin Liška" <mliska@suse.cz>
Cc: David Malcolm <dmalcolm@redhat.com>,
gcc Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] analyzer: Impose recursion limit on indirect calls.
Date: Mon, 20 Sep 2021 18:06:26 +0530 [thread overview]
Message-ID: <E227408B-B98A-4DF6-B674-3FDAB0D1B9BE@gmail.com> (raw)
In-Reply-To: <b1e823c1-49d3-4f43-12f3-24dc5b4360ba@suse.cz>
[ Sorry for very late response ]
> On 27-Aug-2021, at 6:28 PM, Martin Liška <mliska@suse.cz> wrote:
>
> On 8/27/21 14:44, Ankur Saini wrote:
>> While working on patch to convert most of the 8 whitespace characters to tabs in the analyzer’s source, I see this weird behaviour where at some places indentation looks weird when viewed in patch file ( generated via “git format-patch” ) but looks alright when viewed in text editor.
>
> Yes, I can confirm the patch fixed the white spaces, you can verify that with:
> $ git diff | ./contrib/check_GNU_style.py -
> ...
>
> Note there are some other formatting issues reported by the script.
Yes, I see that too, and have fixed most of them
Unfortunately, I can’t seem to find a way to avoid the following report.
---
=== ERROR type #1: lines should not exceed 80 characters (1 error(s)) ===
gcc/analyzer/diagnostic-manager.cc:2152:80: = cg_superedge.map_expr_from_caller_to_callee (caller_var,
—
Also, does these kinds of patches require some special changelog or should I proceed in usual fashion ?
==
Here is updated patch :
==
Thanks
- Ankur
prev parent reply other threads:[~2021-09-20 12:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 8:09 Ankur Saini
2021-08-25 13:22 ` David Malcolm
2021-08-25 13:54 ` Martin Liška
[not found] ` <9C51062C-3457-4345-9BDC-20F7FE4BFA1E@gmail.com>
2021-08-25 15:05 ` David Malcolm
2021-08-25 15:55 ` Ankur Saini
2021-08-25 17:15 ` David Malcolm
2021-08-27 12:44 ` Ankur Saini
2021-08-27 12:58 ` Martin Liška
2021-09-20 12:36 ` Ankur Saini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E227408B-B98A-4DF6-B674-3FDAB0D1B9BE@gmail.com \
--to=arsenic.secondary@gmail.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).