From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by sourceware.org (Postfix) with ESMTPS id 639D73858C60 for ; Mon, 20 Sep 2021 12:36:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 639D73858C60 Received: by mail-pj1-x1029.google.com with SMTP id v19so11871389pjh.2 for ; Mon, 20 Sep 2021 05:36:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=5AOpIuMjuYswoxhPB9mGRXhRfZWEQYJ/NdnL3fhn1tQ=; b=a8uokLiWy0ge6HcTod//lbUA7u1gMDPOimFVoYkyjuCUnHdRmxPODoqW5YSUajNHZE HpSjxDbgruTAdsMUvE3CuwPDAoct7ToOdN0wudb0idId9FE3Z4T04wH76eGr+0zyq/nR kZ3owWYnOByUHcRPuqCuRh4bqov9vcrZQszPIpHSWb1+QEK5gFtPteS6DHsgtRxqmchW wn/IBsz+J35o9c4JSbZ3U8SYLgO3u7jZbavHY6C4mJJMaNMWgRcY4BaL199W1yGsxmnh pnBQxfT3AxfWeAuAfQLHukUoKxuO6R7H3G90KYf2nn2jwHPQ2s1905EBxEB8CuUUToyr jang== X-Gm-Message-State: AOAM531oK2vtzpCYbLRtZ0UtVU/lwXstBgDlAVvCieprDKOsT1JZxIQ+ G1Q2A6/XfsHRh150//giyOQ= X-Google-Smtp-Source: ABdhPJzIT6vtJ3buR8G2K+KhTb9fX6BdXYR3w6v/MJN9+MH2Rxc+bFw1NR+cke2DyGKUsAzIyw+2hg== X-Received: by 2002:a17:90a:708c:: with SMTP id g12mr37602600pjk.13.1632141392279; Mon, 20 Sep 2021 05:36:32 -0700 (PDT) Received: from [192.168.0.198] ([103.161.56.137]) by smtp.gmail.com with ESMTPSA id v17sm13696961pff.6.2021.09.20.05.36.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Sep 2021 05:36:31 -0700 (PDT) From: Ankur Saini Message-Id: Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.20.0.2.21\)) Subject: Re: [PATCH] analyzer: Impose recursion limit on indirect calls. Date: Mon, 20 Sep 2021 18:06:26 +0530 In-Reply-To: Cc: David Malcolm , gcc Patches To: =?utf-8?Q?Martin_Li=C5=A1ka?= References: <02524C4A-6B71-44BD-90E3-E9328DCE32E7@gmail.com> <5df6e7001a5792e5aeaf03de4658cad2c4bdc6e3.camel@redhat.com> <9C51062C-3457-4345-9BDC-20F7FE4BFA1E@gmail.com> <47cb93b4727ae6e4ff0f37e22947cc72705bf580.camel@redhat.com> <6C8ACAA4-BD3A-480B-BB2D-FA7CD23E4AE0@gmail.com> <7a999e68037cf92b857b2d987ec8e82385a4d6d9.camel@redhat.com> <8DD325D5-194A-42D6-A319-C38225E09F3B@gmail.com> X-Mailer: Apple Mail (2.3654.20.0.2.21) X-Spam-Status: No, score=1.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Sep 2021 12:36:35 -0000 [ Sorry for very late response ] > On 27-Aug-2021, at 6:28 PM, Martin Li=C5=A1ka wrote: >=20 > On 8/27/21 14:44, Ankur Saini wrote: >> While working on patch to convert most of the 8 whitespace characters = to tabs in the analyzer=E2=80=99s source, I see this weird behaviour = where at some places indentation looks weird when viewed in patch file ( = generated via =E2=80=9Cgit format-patch=E2=80=9D ) but looks alright = when viewed in text editor. >=20 > Yes, I can confirm the patch fixed the white spaces, you can verify = that with: > $ git diff | ./contrib/check_GNU_style.py - > ... >=20 > Note there are some other formatting issues reported by the script. Yes, I see that too, and have fixed most of them=20 Unfortunately, I can=E2=80=99t seem to find a way to avoid the following = report. --- =3D=3D=3D ERROR type #1: lines should not exceed 80 characters (1 = error(s)) =3D=3D=3D gcc/analyzer/diagnostic-manager.cc:2152:80: =3D = cg_superedge.map_expr_from_caller_to_callee (caller_var, =E2=80=94 Also, does these kinds of patches require some special changelog or = should I proceed in usual fashion ? =3D=3D Here is updated patch :=20 =3D=3D Thanks - Ankur=20