From: FX Coudert <fxcoudert@gmail.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Iain Sandoe <iain@sandoe.co.uk>
Subject: [PATCH] Testsuite, Darwin: skip PIE test
Date: Mon, 30 Oct 2023 12:43:35 +0100 [thread overview]
Message-ID: <E3D72FE3-B2DE-4EE8-BD31-844F0735CB4B@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 264 bytes --]
Hi,
The recent commit of https://gcc.gnu.org/pipermail/gcc-patches/2023-October/634347.html has made this test invalid. We now don’t emit __PIE__, and the test should be skipped on darwin.
Fixes the new failure on x86_64-apple-darwin21. OK to push?
FX
[-- Attachment #2: 0001-Testsuite-Darwin-skip-PIE-test.patch --]
[-- Type: application/octet-stream, Size: 871 bytes --]
From a0c557690c8d5327deda6e21f8d1deca8451a4cb Mon Sep 17 00:00:00 2001
From: Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
Date: Mon, 30 Oct 2023 12:41:17 +0100
Subject: [PATCH] Testsuite, Darwin: skip PIE test
gcc/testsuite/ChangeLog:
* gcc.dg/pie-2.c: Skip test on darwin.
---
gcc/testsuite/gcc.dg/pie-2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/gcc/testsuite/gcc.dg/pie-2.c b/gcc/testsuite/gcc.dg/pie-2.c
index 1838745a11a..0a1cc27a503 100644
--- a/gcc/testsuite/gcc.dg/pie-2.c
+++ b/gcc/testsuite/gcc.dg/pie-2.c
@@ -2,6 +2,7 @@
/* { dg-options "-fPIE" } */
/* { dg-require-effective-target pie } */
/* { dg-skip-if "__PIC__ is always 1 for MIPS" { mips*-*-* } } */
+/* { dg-skip-if "__PIE__ is often not defined on darwin" { *-*-darwin* } } */
#if __PIC__ != 2
# error __PIC__ is not 2!
--
2.39.3 (Apple Git-145)
next reply other threads:[~2023-10-30 11:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 11:43 FX Coudert [this message]
2023-10-30 11:46 ` Iain Sandoe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E3D72FE3-B2DE-4EE8-BD31-844F0735CB4B@gmail.com \
--to=fxcoudert@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=iain@sandoe.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).