Hi Uros, > On 5 Dec 2022, at 10:37, Uros Bizjak via Gcc-patches wrote: > > On Sun, Dec 4, 2022 at 9:30 PM Iain Sandoe wrote: >> >> gcc/testsuite/ChangeLog: >> >> * gcc.target/x86_64/abi/bf16/args.h: Make xmm_regs, x87_regs extern. >> * gcc.target/x86_64/abi/bf16/m256bf16/args.h: Likewise. >> * gcc.target/x86_64/abi/bf16/m512bf16/args.h: Likewise. >> * gcc.target/x86_64/abi/bf16/asm-support.S: Add Mach-O variant. >> * gcc.target/x86_64/abi/bf16/m256bf16/asm-support.S: Likewise. >> * gcc.target/x86_64/abi/bf16/m512bf16/asm-support.S: Likewise. > > Please note that in other directories asm-support-darwin.s is > introduced and included via .exp file. Is there a reason a different > approach is introduced here? Since it seems that testcases get added and amended without considering any sub-target apart from x86_64-linux-gnu (even by very experienced contributors), I was hoping that the Darwin section might prompt folks to remember that there are several other sub-targets. However, the main thing is to fix the tests .. so here’s a version using separate files. OK? thanks, Iain