From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59162 invoked by alias); 10 Nov 2015 17:02:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 59110 invoked by uid 89); 10 Nov 2015 17:02:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: resqmta-po-09v.sys.comcast.net Received: from resqmta-po-09v.sys.comcast.net (HELO resqmta-po-09v.sys.comcast.net) (96.114.154.168) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 10 Nov 2015 17:02:22 +0000 Received: from resomta-po-03v.sys.comcast.net ([96.114.154.227]) by resqmta-po-09v.sys.comcast.net with comcast id ft1v1r00M4ueUHc01t2LLu; Tue, 10 Nov 2015 17:02:20 +0000 Received: from [172.16.0.8] ([24.4.193.248]) by resomta-po-03v.sys.comcast.net with comcast id ft2J1r00S5N1HX401t2KTV; Tue, 10 Nov 2015 17:02:19 +0000 References: <559F5D7B.6070208@redhat.com> <55B148AB.6010103@redhat.com> <55B28DCB.2080404@redhat.com> In-Reply-To: Mime-Version: 1.0 (1.0) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Message-Id: Cc: Richard Biener , Yuri Rumyantsev , Jeff Law , gcc-patches , Igor Zamyatin From: Mike Stump Subject: Re: [PATCH] Simple optimization for MASK_STORE. Date: Tue, 10 Nov 2015 17:02:00 -0000 To: Ilya Enkovich X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg01247.txt.bz2 On Nov 10, 2015, at 6:56 AM, Ilya Enkovich wrote: > 2015-11-10 17:46 GMT+03:00 Richard Biener : >> On Tue, Nov 10, 2015 at 1:48 PM, Ilya Enkovich = wrote: >>> 2015-11-10 15:33 GMT+03:00 Richard Biener : >>>> On Fri, Nov 6, 2015 at 2:28 PM, Yuri Rumyantsev w= rote: >>>>> Richard, >>>>>=20 >>>>> I tried it but 256-bit precision integer type is not yet supported. >>>>=20 >>>> What's the symptom? The compare cannot be expanded? Just add a patte= rn then. >>>> After all we have modes up to XImode. >>>=20 >>> I suppose problem may be in: >>>=20 >>> gcc/config/i386/i386-modes.def:#define MAX_BITSIZE_MODE_ANY_INT (128) >>>=20 >>> which doesn't allow to create constants of bigger size. Changing it >>> to maximum vector size (512) would mean we increase wide_int structure >>> size significantly. New patterns are probably also needed. >>=20 >> Yes, new patterns are needed but wide-int should be fine (we only need t= o create >> a literal zero AFACS). The "new pattern" would be equality/inequality >> against zero >> compares only. >=20 > Currently 256bit integer creation fails because wide_int for max and > min values cannot be created. > It is fixed by increasing MAX_BITSIZE_MODE_ANY_INT, but it increases > WIDE_INT_MAX_ELTS > and thus increases wide_int structure. If we use 512 for > MAX_BITSIZE_MODE_ANY_INT then > wide_int structure would grow by 48 bytes (16 bytes if use 256 for > MAX_BITSIZE_MODE_ANY_INT). Not answering for Richard, but the design of wide-int was that though the t= emporary space would grow, trees and rtl would not. Most wide-int values a= re short lived.