Re: [Patch Debug] Emit pubnames for reorder & partition case.

[IainS <developer@sandoe-acoustics.co.uk>]

On 20 Dec 2010, at 22:43, IainS wrote:

>
> On 20 Dec 2010, at 22:06, Richard Henderson wrote:
>
>> On 12/20/2010 01:49 PM, IainS wrote:
>>> what I'm after is
>>> (a) avoiding a name clash.
>>> (b) having a generated  tag which is clearly understandable to the  
>>> person debugging ..
>>>
>>> If I prefix (rather than the current post-fix) with  "__hot_" and
>>> "__cold_"  (or even __hot_partition_) that should be safe and not
>>> require the extra hoops?
>>
>> Yes, that should work.  I do question whether you want this symbol
>> to match up with the name generated in the "atom" patch though.
>
>
> Yes, I think that is a good idea - I will amend the other patch to  
> match this one, assuming Mike also OKs it,
> thanks, for your reviews,

I've now amended the darwf2 patch thus:

		  /* There is no real support in DW2 for this .. so we make
		     a work-around.  First, emit the pub name for the segment
		     containing the function label.  Then make and emit a
		     simplified subprogram DIE for the second segment with the
		     name pre-fixed by __hot/cold_sect_of_.  We use the same
		     linkage name for the second die so that gdb will find both
		     sections when given "b foo".  */

<snip>
		  if (fde->in_std_section)
		    {
		      name = concat ("__cold_sect_of_", name, NULL);

etc.

and the config/darwin.c patch to match this.

FAOD, are the two patches now OK to apply, assuming Mike is happy with  
the Darwin aspects?

thanks
Iain