From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 59FEF3858C78 for ; Thu, 9 Nov 2023 15:12:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 59FEF3858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 59FEF3858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.220.29 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699542726; cv=none; b=JVHNzmcunmgiPRq+4fO3emzWlGIRH6seLa9QCXp9c3bEkDc/6I9/65ysWUK03pEY20Tfp0zYMHcI2SQjiXi1HLO9K+VcfnyCXfD/VJw+hWwrsP2uP13hKfM9nF/WgYkxY4Bgl+03pzu3tQzcfmudZ2VMZZs4KYNFguYOal/VGts= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699542726; c=relaxed/simple; bh=gzY+6BnbkbgI/V/Znv4CLG5k9wTLD/KJNOGstVJLhsU=; h=DKIM-Signature:DKIM-Signature:From:Mime-Version:Subject:Date: Message-Id:To; b=pjB0YtuBV8xIryV7fnUCYrW4ypXMpsaSygA7EqRmLaWQRY+4328QzV6HcToHsTkDNS79Ykogo5AyeTQnCQUScIpvrh4VEf/+Y0IMMUNshpnKq7hroHJjUd9EJAkAjuwB4kekV5RmdNXWIFAf4vsHn7WoTMS72tASPHADI2HnnhQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 175231F8B3; Thu, 9 Nov 2023 15:12:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1699542724; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uTP3qGrK7uPYyW3Iqj/KSpjaej59Ti/97GIdQnmA8ic=; b=ngBJmSmJZPfLVHVEhngQ7sOY/1DzqsBzjjTPLZCbbtwR6pegabUNHoIc4ZzlmXe35zKBX1 QMTKk+SdjFE4eqxPjUp4wMZuZ5jW9ULY55EFYhHJftKHu8j8Y5/vQDR8ayLMHvcszubnlN zvbbCZavNEk4G9GBazrBGB+iU0ekhxo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1699542724; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uTP3qGrK7uPYyW3Iqj/KSpjaej59Ti/97GIdQnmA8ic=; b=OD0EfFIFiGlMysRj+GOhWSFbNmuyC5XWMO2stIbVKWGmHtnJ48yOHxKgOot0bh8Uno6iK6 HwEuyRIy1yMpBZDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id ED6C513524; Thu, 9 Nov 2023 15:12:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 5RnsOcP2TGVdBAAAMHmgww (envelope-from ); Thu, 09 Nov 2023 15:12:03 +0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Richard Biener Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v1] Internal-fn: Add FLOATN support for l/ll round and rint [PR/112432] Date: Thu, 9 Nov 2023 16:11:52 +0100 Message-Id: References: <20231109143338.307725-1-pan2.li@intel.com> Cc: gcc-patches@gcc.gnu.org, juzhe.zhong@rivai.ai, kito.cheng@sifive.com, yanzhang.wang@intel.com In-Reply-To: <20231109143338.307725-1-pan2.li@intel.com> To: pan2.li@intel.com X-Mailer: iPhone Mail (20H115) X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Am 09.11.2023 um 15:34 schrieb pan2.li@intel.com: >=20 > =EF=BB=BFFrom: Pan Li >=20 > The defined DEF_EXT_LIB_FLOATN_NX_BUILTINS functions should also > have DEF_INTERNAL_FLT_FLOATN_FN instead of DEF_INTERNAL_FLT_FN for > the FLOATN support. According to the glibc API and gcc builtin, we > have below table for the FLOATN is supported or not. >=20 > +---------+-------+-------------------------------------+ > | | glibc | gcc: DEF_EXT_LIB_FLOATN_NX_BUILTINS | > +---------+-------+-------------------------------------+ > | iceil | N | N | > | ifloor | N | N | > | irint | N | N | > | iround | N | N | > | lceil | N | N | > | lfloor | N | N | > | lrint | Y | Y | > | lround | Y | Y | > | llceil | N | N | > | llfllor | N | N | > | llrint | Y | Y | > | llround | Y | Y | > +---------+-------+-------------------------------------+ >=20 > This patch would like to support FLOATN for: > 1. lrint > 2. lround > 3. llrint > 4. llround >=20 > The below tests are passed within this patch: > 1. x86 bootstrap and regression test. > 2. aarch64 regression test. > 3. riscv regression tests. Ok=20 Richard=20 > PR target/112432 >=20 > gcc/ChangeLog: >=20 > * internal-fn.def (LRINT): Add FLOATN support. > (LROUND): Ditto. > (LLRINT): Ditto. > (LLROUND): Ditto. >=20 > Signed-off-by: Pan Li > --- > gcc/internal-fn.def | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/gcc/internal-fn.def b/gcc/internal-fn.def > index 7f0e3759615..10f88e37bc9 100644 > --- a/gcc/internal-fn.def > +++ b/gcc/internal-fn.def > @@ -365,12 +365,12 @@ DEF_INTERNAL_FLT_FN (IRINT, ECF_CONST, lrint, unary_= convert) > DEF_INTERNAL_FLT_FN (IROUND, ECF_CONST, lround, unary_convert) > DEF_INTERNAL_FLT_FN (LCEIL, ECF_CONST, lceil, unary_convert) > DEF_INTERNAL_FLT_FN (LFLOOR, ECF_CONST, lfloor, unary_convert) > -DEF_INTERNAL_FLT_FN (LRINT, ECF_CONST, lrint, unary_convert) > -DEF_INTERNAL_FLT_FN (LROUND, ECF_CONST, lround, unary_convert) > +DEF_INTERNAL_FLT_FLOATN_FN (LRINT, ECF_CONST, lrint, unary_convert) > +DEF_INTERNAL_FLT_FLOATN_FN (LROUND, ECF_CONST, lround, unary_convert) > DEF_INTERNAL_FLT_FN (LLCEIL, ECF_CONST, lceil, unary_convert) > DEF_INTERNAL_FLT_FN (LLFLOOR, ECF_CONST, lfloor, unary_convert) > -DEF_INTERNAL_FLT_FN (LLRINT, ECF_CONST, lrint, unary_convert) > -DEF_INTERNAL_FLT_FN (LLROUND, ECF_CONST, lround, unary_convert) > +DEF_INTERNAL_FLT_FLOATN_FN (LLRINT, ECF_CONST, lrint, unary_convert) > +DEF_INTERNAL_FLT_FLOATN_FN (LLROUND, ECF_CONST, lround, unary_convert) >=20 > /* FP rounding. */ > DEF_INTERNAL_FLT_FLOATN_FN (CEIL, ECF_CONST, ceil, unary) > --=20 > 2.34.1 >=20