From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124216 invoked by alias); 23 Aug 2015 21:27:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 124199 invoked by uid 89); 23 Aug 2015 21:27:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-wi0-f175.google.com Received: from mail-wi0-f175.google.com (HELO mail-wi0-f175.google.com) (209.85.212.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 23 Aug 2015 21:27:29 +0000 Received: by widdq5 with SMTP id dq5so33345045wid.1; Sun, 23 Aug 2015 14:27:26 -0700 (PDT) X-Received: by 10.180.210.200 with SMTP id mw8mr23794066wic.26.1440365246655; Sun, 23 Aug 2015 14:27:26 -0700 (PDT) Received: from [192.168.1.17] (5-49-98-41.hfc.dyn.abo.bbox.fr. [5.49.98.41]) by smtp.gmail.com with ESMTPSA id lu5sm20180641wjb.9.2015.08.23.14.27.25 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 23 Aug 2015 14:27:25 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.0 \(3083\)) Subject: Re: [patch,libgfortran] Handle invalid command line in EXECUTE_COMMAND_LINE From: FX In-Reply-To: Date: Sun, 23 Aug 2015 21:51:00 -0000 Cc: gcc-patches , gfortran Content-Transfer-Encoding: 7bit Message-Id: References: To: Janne Blomqvist X-SW-Source: 2015-08/txt/msg01380.txt.bz2 > Otherwise looks good, but strncat is C99, and we support targets which > don't have a C99 libc (been there, done that..). Since in this case > you're dealing with string literals rather than user input, it ought > to be safe to just use plain strcat (or strlen+memcpy, if you prefer). Nope, strncat() is C90: http://clc-wiki.net/wiki/strncat Thus, safe to use, I think. I committed as submitted, as revision 227105. Thanks for the review. FX