From: Richard Biener <richard.guenther@gmail.com>
To: Jeff Law <jlaw@ventanamicro.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: RFC -- targets with unsigned bifields
Date: Sun, 17 Dec 2023 09:36:24 +0100 [thread overview]
Message-ID: <E8703963-76E7-4B73-93A0-1D452EFD707F@gmail.com> (raw)
In-Reply-To: <7a5ec7af-fdbf-470f-9414-bf4110331d0a@ventanamicro.com>
> Am 17.12.2023 um 04:29 schrieb Jeff Law <jlaw@ventanamicro.com>:
>
>
> So mcore-elf is the slowest target to test with a simulator. Not because it's simulator is particularly bad, but because some tests timeout as they've gotten into infinite loops. This causes the mcore-elf port to take about 2X longer than most other gdbsim ports.
>
> I tracked this down to the port unconditionally adding -funsigned-bitfields to CC1_SPEC. According to the comment it's how the ABI is defined for the mcore targets.
>
> It'd be nice to get reasonable results from mcore-elf in a reasonable amount of time. The question is how.
>
> I *could* just disable the -funsigned-bitfields within the tester. We certainly have the ability to carry forward patches like this which exist only to help the testing effort.
>
> Another approach would be to add an explicit -fsigned-bifields to the arguments for the affected tests. I'd guess it's on the order of around 35 distinct tests that would need to be updated.
>
> A third approach would be to grub around and see if there's a way to add a -fsigned-bitfields using dejagnu, perhaps in the baseboards file.
When the testcases are simply invalid with unsigned bitfields then I suggest to add a dg effective target we could require? Or are the testcases actually miscompiled?
I suppose neither -f[un]signed-bitfields is the standard behavior but bitfield signedness is determined by the underlying type? Or is this flag about sth else?
I could imagine a test needing the default behavior?
Richard
> Looking for suggestions/recommendations here.
>
> Jeff
next prev parent reply other threads:[~2023-12-17 8:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-17 3:29 Jeff Law
2023-12-17 8:36 ` Richard Biener [this message]
2023-12-18 18:32 ` Joseph Myers
2023-12-18 18:36 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E8703963-76E7-4B73-93A0-1D452EFD707F@gmail.com \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jlaw@ventanamicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).