public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* Re: [Patch] libgfortran: do not assume libm
@ 2012-03-20  9:49 Tobias Burnus
  2012-03-20  9:57 ` Tristan Gingold
  2012-03-22  8:30 ` [Patch V2] " Tristan Gingold
  0 siblings, 2 replies; 14+ messages in thread
From: Tobias Burnus @ 2012-03-20  9:49 UTC (permalink / raw)
  To: Tristan Gingold, GCC Patches, fortran

Hi Tristan,

> I am starting to build fortran for VMS.

Thanks for the patch and this endeavor.

> The first serious issue was with libgfortran/configure.  It checks for
> several math functions, but directly in libm using AC_CHECK_LIB.
> But there is on such things as libm on VMS systems 

I think after building you will run into the same issue when using
gfortran. The linking of -lm is hardcoded in gcc/fortran/gfortranspec.c
(search there for MATH_LIBRARY).

And it is hard coded in libgfortran/libgfortran.spec.in and in the
as-needed check of libgfortran/acinclude.m4 within a libquadmath check.

Talking about libquadmath, its libquadmath/configure.ac has the same issue.

 * * *

To your patch:

First, I am far from being a configure expert and thus would like if
a build maintainer could have a look (or Janne, who seems to have also
more experience.)


I don't understand the purpose of the line:

+# Check for libm
+AC_CHECK_LIB([m],[sin])

Except of printing to stdout and to the logs whether -lm is available and
contains "sin", it doesn't seem to do anything. If that's the purpose, I think
it needs a better comment. If not, I would like to know its purpose.

Otherwise, the patch looks fine to me - but as written, I would like if
someone else (build maintainer, Janne, ...) could have a look.

Tobias

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2012-04-02  7:47 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-20  9:49 [Patch] libgfortran: do not assume libm Tobias Burnus
2012-03-20  9:57 ` Tristan Gingold
2012-03-22  8:30 ` [Patch V2] " Tristan Gingold
2012-03-22 10:07   ` Paolo Bonzini
2012-03-22 20:57     ` Tobias Burnus
2012-03-26  8:44     ` Tristan Gingold
2012-03-26 21:43       ` Janne Blomqvist
2012-03-27  7:51         ` Tristan Gingold
2012-03-27  8:01           ` Tristan Gingold
2012-03-27  8:39             ` Janne Blomqvist
2012-03-27  9:29               ` Tristan Gingold
2012-03-30 10:22               ` Tristan Gingold
2012-03-30 12:40                 ` Paolo Bonzini
2012-04-02  7:47                   ` Tristan Gingold

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).