From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28229 invoked by alias); 26 Oct 2004 00:28:22 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 28222 invoked from network); 26 Oct 2004 00:28:21 -0000 Received: from unknown (HELO smtp2.fuse.net) (216.68.8.175) by sourceware.org with SMTP; 26 Oct 2004 00:28:21 -0000 Received: from gx6.fuse.net ([66.42.186.147]) by smtp2.fuse.net (InterMail vM.6.01.03.04 201-2131-111-106-20040729) with ESMTP id <20041026002808.EFAB21290.smtp2.fuse.net@gx6.fuse.net> for ; Mon, 25 Oct 2004 20:28:08 -0400 Received: from dellpi.pinski.fam ([66.42.186.147]) by gx6.fuse.net (InterMail vG.1.00.00.00 201-2136-104-20040331) with ESMTP id <20041026002801.JUFJ6532.gx6.fuse.net@dellpi.pinski.fam>; Mon, 25 Oct 2004 20:28:01 -0400 Received: from [10.0.0.80] (zhivago.i.pinski.fam [10.0.0.80]) by dellpi.pinski.fam (8.12.2/8.12.1) with ESMTP id i9Q0SAVT029587; Mon, 25 Oct 2004 20:28:12 -0400 (EDT) In-Reply-To: <873c02e46k.fsf@codesourcery.com> References: <873c02e46k.fsf@codesourcery.com> Mime-Version: 1.0 (Apple Message framework v618) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: Content-Transfer-Encoding: 7bit Cc: gcc-patches@gcc.gnu.org, "Joseph S. Myers" From: Andrew Pinski Subject: Re: New C parser [patch] Date: Tue, 26 Oct 2004 01:03:00 -0000 To: Zack Weinberg X-SW-Source: 2004-10/txt/msg02139.txt.bz2 On Oct 25, 2004, at 8:03 PM, Zack Weinberg wrote: >> + c_parser_error (parser, >> + "expected ':', ',', ';' or '__attribute__'"); >> + break; > > These want %<%>ifying. There are several other cases - I'm not going > to call them all out explicitly. But I will say that we have C++ diagnostic regressions because of "%<%>ifying". The reason why we have this problem is because c_parser_error takes a string but only does %s on it rather than passing it on to the diagnostic mechanism. Thanks, Andrew Pinski