From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp002.apm-internet.net (smtp002.apm-internet.net [85.119.248.221]) by sourceware.org (Postfix) with ESMTPS id 7C7CC3858407 for ; Fri, 17 Dec 2021 23:18:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7C7CC3858407 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sandoe.co.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=sandoe.co.uk Received: (qmail 11324 invoked from network); 17 Dec 2021 23:18:44 -0000 X-APM-Out-ID: 16397831241132 X-APM-Authkey: 257869/1(257869/1) 4 Received: from unknown (HELO ?192.168.1.214?) (81.138.1.83) by smtp002.apm-internet.net with SMTP; 17 Dec 2021 23:18:44 -0000 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: [patch] Future-proof and homogenise handling of darwin versions From: Iain Sandoe In-Reply-To: Date: Fri, 17 Dec 2021 23:18:43 +0000 Cc: gcc-patches@gcc.gnu.org Content-Transfer-Encoding: quoted-printable Message-Id: References: To: FX X-Mailer: Apple Mail (2.3445.104.21) X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00, KAM_COUK, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2021 23:18:47 -0000 Hi FX, thanks for the patch > On 17 Dec 2021, at 22:23, FX wrote: >=20 > The current GCC branch will become 12.1.0, which will be the stable = version of GCC when the next macOS version is released. There are some = places in GCC that don=E2=80=99t handle darwin22 as a version, so we = need to future-proof it (gcc/config.gcc and gcc/config/darwin-driver.c). = We align that code with what Apple clang does, i.e. accept all potential = major macOS versions until 99. >=20 > This patch also homogenises the handling of darwin version numbers, = where the majority of places use darwin2*, but some used darwin2[0-9]*. = Since there never was a darwin2.x version, the two are equivalent, and = we prefer the simpler darwin2* >=20 > Bootstrapped and regtested on x86_64-apple-darwin21. > OK to commit? Yes, but please put this ^^ explanation into the git commit log, and = prepend the title line with Darwin: the latter helps locate things that might need backporting, and the = former means that we have an easy-to-find rationale for the patch (one = of the nicer things about this new system!). thanks Iain >=20 > FX >=20 >