From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by sourceware.org (Postfix) with ESMTPS id 380D3383F859 for ; Tue, 5 Jan 2021 08:22:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 380D3383F859 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hainque@adacore.com Received: by mail-wr1-x42c.google.com with SMTP id i9so35275662wrc.4 for ; Tue, 05 Jan 2021 00:22:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore-com.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=2sFYy9xbl+h4fbJLUZrMTyVpMPXwFhpfg3PjkogqEJU=; b=qQxJr6Dky3J04tGx8pcN163s107hP8/g5EgmpY145ac1R5QuYTYQdRczjYe4oxdAuX YdnQqZ0yUYIge356o5R51cLvRGhE1i28T816a0+fXBJy7xzdDnhiS6vJZCP862Kk7Msk /K+pmYOhL/PFZs/4IRSisPho9csk8+D86VhxNKVUMfSQO+YDucoVjrnhK7lF4Ze+Tq2M uF+p/2namfuIG+3Q2do2tUnzmlADPNpHgOw9ZRPTccIKiV9NGDtzrCC8hdoizbr+1SF5 gKVPuvI/rJaxrBsEqvq/3XjYhD4feuIG7ktMCgQ0jvny+Q/BOyMkD6Sgi5njOylKVxqt r1mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=2sFYy9xbl+h4fbJLUZrMTyVpMPXwFhpfg3PjkogqEJU=; b=iXlnopkV3Q0NU/2rSPVtSvU9RQNTtw1GvMInWLW0+K6rOUc02eGMKcZekmAnLnrAz2 bee9vKXDpifNSDFXRZcG8bYT26cpUlLTfplPdBQuth48wLs8C1M12qAfDHjg9zI3QilL Zhtb4l7zoGpWfn9oPo25JqrseB83BzaPgYODAa/MASecavOlLfb9VGBDi12NBPNRv3af d/f/GP7GJH5Oqisr44ZavobaGQe6WJF4Qxs0FROGXzMxzAQk+og128q3H8ll3ND32tam n7R9k4nOW7IL5DBodn4CbfLTQuXebh9R3F1hXPxTCOQBs3EkTRHUDMeRcTerkDTzbLYP ZgSw== X-Gm-Message-State: AOAM531DuJVR+F4g4Hp/rYIlHqqGNeSZN17sJAQQie6Vo7HmxM0smX/u Q1AKn+Uxl7UWdvKv2QdYmzPJcg== X-Google-Smtp-Source: ABdhPJxfvX8Zlb8+iURVh2eP7sAKzQ6Nsw5C6dqd21XfT+QE4xs6OohhvGnwu4VfeUVpmOWEzrMhLQ== X-Received: by 2002:a5d:528a:: with SMTP id c10mr76217415wrv.117.1609834975356; Tue, 05 Jan 2021 00:22:55 -0800 (PST) Received: from imac-2020.home (2a01cb0002912700f891aa383c9c8a53.ipv6.abo.wanadoo.fr. [2a01:cb00:291:2700:f891:aa38:3c9c:8a53]) by smtp.gmail.com with ESMTPSA id v4sm95714126wrw.42.2021.01.05.00.22.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Jan 2021 00:22:54 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: robustify vxworks glimits.h overriding From: Olivier Hainque In-Reply-To: Date: Tue, 5 Jan 2021 09:22:54 +0100 Cc: Olivier Hainque , gcc-patches@gcc.gnu.org Content-Transfer-Encoding: 7bit Message-Id: References: To: Alexandre Oliva X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jan 2021 08:22:57 -0000 > On 5 Jan 2021, at 08:51, Alexandre Oliva wrote: > > > The glimits.h overriding used in gcc/config/t-vxworks was fragile: the > intermediate file would already be there in a rebuild, and so the > adjustments would not be made, so the generated limits.h would miss > them, causing limits-width-[12] tests to fail on that target. > > While changing it, I also replaced the modern $(cmd) shell syntax with > the more portable `cmd` construct. > > Regstrapped on x86_64-linux-gnu, also tested on x-arm-wrs-vxworks7r2. > I'm checking it in unless there are objections in the next 24 hours. > > > for gcc/ChangeLog > > * Makefile.in (T_GLIMITS_H): New. > (stmp-int-hdrs): Depend on it, use it. > * config/t-vxworks (T_GLIMITS_H): Override it. > (vxw-glimits.h): New. Good for me, VxWorks' wise. Thanks!