From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28615 invoked by alias); 13 Apr 2015 05:49:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 28605 invoked by uid 89); 13 Apr 2015 05:49:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.9 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: na01-by2-obe.outbound.protection.outlook.com Received: from mail-by2on0127.outbound.protection.outlook.com (HELO na01-by2-obe.outbound.protection.outlook.com) (207.46.100.127) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA256 encrypted) ESMTPS; Mon, 13 Apr 2015 05:49:24 +0000 Received: from BY2PR02CA0039.namprd02.prod.outlook.com (10.141.216.29) by BN3PR0201MB1058.namprd02.prod.outlook.com (25.161.209.139) with Microsoft SMTP Server (TLS) id 15.1.136.25; Mon, 13 Apr 2015 05:49:21 +0000 Received: from BN1BFFO11FD011.protection.gbl (2a01:111:f400:7c10::1:160) by BY2PR02CA0039.outlook.office365.com (2a01:111:e400:2c40::29) with Microsoft SMTP Server (TLS) id 15.1.136.25 via Frontend Transport; Mon, 13 Apr 2015 05:49:20 +0000 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=amd.com; gcc.gnu.org; dkim=none (message not signed) header.d=none; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) Received: from atltwp02.amd.com (165.204.84.222) by BN1BFFO11FD011.mail.protection.outlook.com (10.58.144.74) with Microsoft SMTP Server id 15.1.142.12 via Frontend Transport; Mon, 13 Apr 2015 05:49:18 +0000 X-M-MSG: Received: from satlvexedge02.amd.com (satlvexedge02.amd.com [10.177.96.29]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by atltwp02.amd.com (Axway MailGate 5.3.1) with ESMTPS id 2C69BBD88F9; Mon, 13 Apr 2015 00:49:12 -0500 (CDT) Received: from SATLEXDAG05.amd.com (10.181.40.11) by SATLVEXEDGE02.amd.com (10.177.96.29) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 13 Apr 2015 00:49:17 -0500 Received: from SATLEXDAG02.amd.com ([fe80::9be:3efa:c185:761d]) by satlexdag05.amd.com ([fe80::48a2:3adb:b398:7181%23]) with mapi id 14.03.0195.001; Mon, 13 Apr 2015 01:49:17 -0400 From: "Gopalasubramanian, Ganesh" To: Richard Biener CC: Uros Bizjak , "gcc-patches@gcc.gnu.org" Subject: RE: [PATCH] Fix bdverN vector cost of cond_[not_]taken_branch_cost Date: Mon, 13 Apr 2015 05:49:00 -0000 Message-ID: References: In-Reply-To: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;BMV:1;SFV:NSPM;SFS:(10019020)(6009001)(428002)(51704005)(24454002)(377454003)(199003)(189002)(164054003)(50466002)(110136001)(33656002)(102836002)(101416001)(55846006)(87936001)(93886004)(106466001)(106116001)(53416004)(77156002)(62966003)(46102003)(86362001)(92566002)(76176999)(54356999)(46406003)(2656002)(105586002)(5250100002)(2950100001)(2920100001)(50986999)(19580395003)(19580405001)(23726002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR0201MB1058;H:atltwp02.amd.com;FPR:;SPF:None;MLV:sfv;A:1;MX:3;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0201MB1058; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(5002010);SRVR:BN3PR0201MB1058;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0201MB1058; X-Forefront-PRVS: 0545EFAC9A X-OriginatorOrg: amd4.onmicrosoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2015 05:49:18.8730 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.222];Helo=[atltwp02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0201MB1058 X-SW-Source: 2015-04/txt/msg00545.txt.bz2 >Note that before the fixes for PR64909 the epilogue/prologue loops had ver= y large costs associated due to a bug in the cost model implementation. Af= ter the fix their cost is reasonable but the cost of the extra jumps is way= under-accounted for due to the numbers for >cond_taken_branch_cost and con= d_not_taken_branch_cost. > The proposes match mitigates that somewhat. Richard! The patch is good. We are done with our benchmarking and found no = regressions. > How did you arrive at the original cost model? The original cost model as you suspect is not based on architecture alone. = Those are the numbers arrived at by analyzing benchmarks and the cost model= bugs then. These initial numbers were copied for subsequent architectures = too. Cost assignments saying "scalar_stmt_cost =3D 6" and "scalar load_cost =3D = 4" doesn't make sense at all. We will have a look into it. Regards Ganesh -----Original Message----- From: Richard Biener [mailto:rguenther@suse.de]=20 Sent: Wednesday, April 08, 2015 1:08 PM To: Gopalasubramanian, Ganesh Cc: Uros Bizjak; gcc-patches@gcc.gnu.org Subject: RE: [PATCH] Fix bdverN vector cost of cond_[not_]taken_branch_cost On Wed, 8 Apr 2015, Gopalasubramanian, Ganesh wrote: > > I have added a person from AMD to comment on the decision. > > Otherwise, the patch looks OK, but please wait a couple of days for pos= sible comments. >=20 > Thank you Uros! > I am checking the changes with few tests and benchmarking them. > Please wait for a couple of days. Note that before the fixes for PR64909 the epilogue/prologue loops had very= large costs associated due to a bug in the cost model implementation. Aft= er the fix their cost is reasonable but the cost of the extra jumps is way = under-accounted for due to the numbers for cond_taken_branch_cost and cond_= not_taken_branch_cost. The proposes match mitigates that somewhat. How did you arrive at the original cost model? Thanks, Richard. -- Richard Biener SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Jennifer Guild, Dil= ip Upmanyu, Graham Norton HRB 21284 (AG Nuernberg)