From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id D8C373858D39 for ; Sun, 22 Oct 2023 20:02:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D8C373858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D8C373858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698004962; cv=none; b=ZcaZkHGyNsfE8MKUH7JroP81MIxx2neaMoRMMOuxNkbS5S3Y2pyvOXFlyv5kffvSaAoDW04Ym70UuhS1CdZ/YN0gxIjtLnfcWhL0v9/oaHTr1qbpK0Di7GKQpg5kX11q3q3UGVhkOFS5bIn2/Fr5ZnPVFsHLZVYokPOYXvYscC0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698004962; c=relaxed/simple; bh=bTFAxGhwbZfVji86xMcOtCtFw92see0CadNcpRq9S6E=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=p56KOtVldxOj6YWzskncAWSfROiwZAsM598j+1SAsB7L7xBZQaPYVaADzC8f2q6K1VXNun5ODSVOKF4wMnkcqZJ1ABtpKMIZ4StlzNeMC04Z+myt6wE6JET2tnVm7MGXqr5dGSP4NiTHUt9s16D6YZPdM1K66EOuONIgBSWINvA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-9be7e3fa1daso384965466b.3 for ; Sun, 22 Oct 2023 13:02:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698004959; x=1698609759; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:to:from:date:from:to:cc:subject:date:message-id :reply-to; bh=VArEILsStr1IlCNCVxqunRN2rV3MGNidWsbMcP88oKw=; b=cXBNohtBFvy+1TOiAE/Djq1/n59Xgy9chVP9uwL03SGoOiiLgpFlPTe58eVdrffhtK MnN+ZZFlNi3gPjQVcyjrR8VkFwPSvGoacnIQlzOMxaGF+CV3wD0VVctE609XMZgVc4H8 k5U2Q8y2B0xvxovUqzu750ZRJ7BsGfe8l4AsWhm/fmpO97797XSV69hMjrwGFSlF+bx0 JdvgsiWxV/zhnoY+Iv3Qc0lEvpj2YRSMqFk2jcJuhpgUCw/VdYLLJgUS83AJHkAewJbC N9U2beiTl8wpEkr2wnZMBkGodcJPcxrpsn7Jf4xygl5+W3tdYPFunnYfvZ7RuR/oSjv3 +vgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698004959; x=1698609759; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VArEILsStr1IlCNCVxqunRN2rV3MGNidWsbMcP88oKw=; b=bpKVi+C9q86H+GxMwscjNqRaUKb08RHsVHUOvisn/ReJSdthBmC1UBWjn3+2X8J9Dl f5Cmm8cB2wPnfgOHXmzeUjDWsPRMwj0pgBSqosj31FV/p8AZ0cm3E81Mj6cgQyt44NuG TUEfRjgfmv3XzrZuymI2fuXHeMPDA45Y6NW7Ur1Nhx37zRijrCkHIBup+POjXp2pP5LP uG8luCJC+jBSRzsbjOhAcpGIpfz2OqJt41GKgAHZ3GdaEYo3VRpo0AhIYuKSTYP2qa5C hCNbLu6oXS0AX4k5yFpNvC4IOzU3t+Ym6pdTAqoulniP5y8j88Q3U4QIJKp37ZlCJIzS LO4g== X-Gm-Message-State: AOJu0YyneBC5Bs3tzVLKS3cG/2lqkY6H0tJL+AGNOEw8aGXzcfpe6daf WPI51y9RjpTaHEHzdNt5ITm9YM7gj94= X-Google-Smtp-Source: AGHT+IGuH4YOHKcNkBhgcHQeMo4gWoY2tAH48uU7tUeRukqmDx9HP667bBPRZi237ai5AathPRchww== X-Received: by 2002:a17:906:7951:b0:99b:ed44:1a79 with SMTP id l17-20020a170906795100b0099bed441a79mr6501105ejo.3.1698004958804; Sun, 22 Oct 2023 13:02:38 -0700 (PDT) Received: from ?IPv6:::1? ([2001:4bb8:104:cf6c::474c:7ce1]) by smtp.gmail.com with ESMTPSA id g15-20020a170906198f00b009b2d46425absm5492958ejd.85.2023.10.22.13.02.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Oct 2023 13:02:38 -0700 (PDT) Date: Sun, 22 Oct 2023 22:02:34 +0200 From: rep.dot.nop@gmail.com To: gcc-patches@gcc.gnu.org, Jeff Law , Andrew Pinski , Florian Weimer Subject: =?US-ASCII?Q?Re=3A_=5BPATCH=5D_gcc=2Ec-torture/execute/b?= =?US-ASCII?Q?uiltins/fputs=2Ec=3A_Define_=5FGNU=5FSOURCE?= In-Reply-To: References: <87zg0bhzep.fsf@oldenburg.str.redhat.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 22 October 2023 21:45:12 CEST, Jeff Law wrote: > > >On 10/22/23 10:09, Andrew Pinski wrote: >> On Sun, Oct 22, 2023 at 12:47=E2=80=AFAM Florian Weimer wrote: >>>=20 >>> Current glibc headers only declare fputs_unlocked for _GNU_SOURCE=2E >>> Defining the macro avoids an implicit function declaration=2E >>=20 >> This does not help targets that don't use glibc though=2E >> Note for builtins testsuite there is a lib-fputs=2Ec file which will >> define a fputs_unlock which is how it will link even if the libc does >> not define a fputs_unlock=2E >But isn't fputs_unlocked glibc specific to begin with? ie, the test real= ly doesn't make sense AFAICT on non-glibc targets=2E I think uClibc had it too, at least at one point in the past=2E