public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tristan Gingold <gingold@adacore.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Tobias Burnus <tobias.burnus@physik.fu-berlin.de>,
	GCC Patches <gcc-patches@gcc.gnu.org>,
	fortran@gcc.gnu.org, Ralf Corsepius <ralf.corsepius@rtems.org>,
	jb@gcc.gnu.org
Subject: Re: [Patch V2] libgfortran: do not assume libm
Date: Mon, 26 Mar 2012 08:44:00 -0000	[thread overview]
Message-ID: <EC7480F6-60BC-425D-BF60-93FEEF0DAE57@adacore.com> (raw)
In-Reply-To: <4F6AF98F.1000005@redhat.com>


On Mar 22, 2012, at 11:06 AM, Paolo Bonzini wrote:

> Il 22/03/2012 09:30, Tristan Gingold ha scritto:
>> Hi,
>> 
>> this is version 2 of the patch.
>> 
>> The initial problem is that libgfortran configure.ac used AC_CHECK_LIB([m]…) to check wether several math functions are available.  That doesn't work on VMS, because there is no such things as a libm.
>> 
>> It seems to me that there are no autoconf macro to check wether a function is available: AC_CHECK_FUNC[S] don't allow to specify additional include files (necessary on VMS as some math functions are renamed through macros), and AC_CHECK_DECL only checks the presence of the declaration (as pointed out by Ralf).
>> 
>> So I have finally learnt a little bit more about autoconf and added a new file: config/math.m4 (build machinery maintainer cc:)
>> libgfortran/configure.ac now uses the new GCC_CHECK_MATH_FUNC macro.
>> 
>> Bootstrapped without gfortran regressions on x86_64-darwin.
>> 
>> Ok for trunk ?
>> 
>> (I will submit a follow-up change in libquadmath once this change is approved).
>> 
>> Tristan.
>> 
>> config/
>> 2012-03-22  Tristan Gingold  <gingold@adacore.com>
>> 
>> 	* math.m4: New file.
>> 
>> libgfortran/
>> 2012-03-22  Tristan Gingold  <gingold@adacore.com>
>> 
>> 	* configure.ac: Use GCC_CHECK_MATH_FUNC for math functions.
>> 	* acinclude.m4: Include ../config/math.m4
>> 	* configure: Regenerate.
>> 	* Makefile.in: Regenerate.
> 
> Ok.

Thanks, now committed.

Tristan.


  parent reply	other threads:[~2012-03-26  8:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-20  9:49 [Patch] " Tobias Burnus
2012-03-20  9:57 ` Tristan Gingold
2012-03-22  8:30 ` [Patch V2] " Tristan Gingold
2012-03-22 10:07   ` Paolo Bonzini
2012-03-22 20:57     ` Tobias Burnus
2012-03-26  8:44     ` Tristan Gingold [this message]
2012-03-26 21:43       ` Janne Blomqvist
2012-03-27  7:51         ` Tristan Gingold
2012-03-27  8:01           ` Tristan Gingold
2012-03-27  8:39             ` Janne Blomqvist
2012-03-27  9:29               ` Tristan Gingold
2012-03-30 10:22               ` Tristan Gingold
2012-03-30 12:40                 ` Paolo Bonzini
2012-04-02  7:47                   ` Tristan Gingold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=EC7480F6-60BC-425D-BF60-93FEEF0DAE57@adacore.com \
    --to=gingold@adacore.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jb@gcc.gnu.org \
    --cc=pbonzini@redhat.com \
    --cc=ralf.corsepius@rtems.org \
    --cc=tobias.burnus@physik.fu-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).