From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99117 invoked by alias); 29 Oct 2015 16:25:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 99107 invoked by uid 89); 29 Oct 2015 16:25:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f169.google.com Received: from mail-wi0-f169.google.com (HELO mail-wi0-f169.google.com) (209.85.212.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 29 Oct 2015 16:25:43 +0000 Received: by wicll6 with SMTP id ll6so47599090wic.1 for ; Thu, 29 Oct 2015 09:25:40 -0700 (PDT) X-Received: by 10.194.109.99 with SMTP id hr3mr3614754wjb.25.1446135940088; Thu, 29 Oct 2015 09:25:40 -0700 (PDT) Received: from android-4c5a376a18c0e957.fritz.box (p5B0E5FD5.dip0.t-ipconnect.de. [91.14.95.213]) by smtp.gmail.com with ESMTPSA id uj4sm2538485wjc.34.2015.10.29.09.25.39 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 29 Oct 2015 09:25:39 -0700 (PDT) User-Agent: K-9 Mail for Android In-Reply-To: <56323C3D.7010209@redhat.com> References: <87eggdu1z4.fsf@e105548-lin.cambridge.arm.com> <56323C3D.7010209@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Subject: Re: Robustify REAL_MODE_FORMAT From: Richard Biener Date: Thu, 29 Oct 2015 16:29:00 -0000 To: Bernd Schmidt ,gcc-patches@gcc.gnu.org,richard.sandiford@arm.com Message-ID: X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg03221.txt.bz2 On October 29, 2015 4:33:17 PM GMT+01:00, Bernd Schmidt wrote: >On 10/29/2015 04:30 PM, Richard Sandiford wrote: >> Make sure that REAL_MODE_FORMAT aborts if it is passed an invalid >mode, >> rather than stepping beyond the bounds of an array. It turned out >that >> some code was passing non-float modes to the real.h routines. > >> gcc/ >> * real.h (REAL_MODE_FORMAT): Abort if the mode isn't a >> SCALAR_FLOAT_MODE_P. > >I'm assuming that the code you mention has already been fixed so that >we >don't trigger the abort. Ok. Rather than the weird macro can't we turn real_mode_format to an inline function? Richard. > >Bernd