From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2502 invoked by alias); 11 Sep 2017 12:32:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 2476 invoked by uid 89); 11 Sep 2017 12:32:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1749, OK, whilst, wright X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 11 Sep 2017 12:32:35 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-MBX-04.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1drNt9-0003VA-QA from Iain_Sandoe@mentor.com ; Mon, 11 Sep 2017 05:32:31 -0700 Received: from [127.0.0.1] (137.202.0.87) by SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Mon, 11 Sep 2017 13:32:26 +0100 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCH]: PR target/80204 (Darwin macosx-version-min problem) From: Iain Sandoe In-Reply-To: <20170904194843.GA2323@tucnak> Date: Mon, 11 Sep 2017 12:32:00 -0000 CC: GCC Patches , Jeff Law , Jakub Jelinek Content-Transfer-Encoding: quoted-printable Message-ID: References: <5E361A99-1EC7-4363-B8F2-007A38318F2F@pushface.org> <20170904194843.GA2323@tucnak> To: Simon Wright X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) X-SW-Source: 2017-09/txt/msg00571.txt.bz2 > On 4 Sep 2017, at 21:48, Jakub Jelinek wrote: >=20 > On Mon, Sep 04, 2017 at 08:47:07PM +0100, Simon Wright wrote: >> On 1 Sep 2017, at 23:05, Simon Wright wrote: >>>=20 >>> 2017-09-01 Simon Wright >>>=20 >>> PR target/80204 >>> * config/darwin-driver.c (darwin_find_version_from_kernel): eliminate = calculation of the >>> minor version, always output as 0. >>=20 >> Like this? >>=20 >> Do you need the patch to be resubmitted as well? >>=20 >> gcc/Changelog >>=20 >> 2017-09-01 Simon Wright >>=20 >> PR target/80204 >> * config/darwin-driver.c (darwin_find_version_from_kernel): >> Eliminate calculation of the minor version, always output as 0. >=20 > Better >=20 > 2017-09-01 Simon Wright >=20 > PR target/80204 > * config/darwin-driver.c (darwin_find_version_from_kernel): Eliminate > calculation of the minor version, always output as 0. >=20 > Jakub Very sorry that no-one from the Darwin folks has reviewed this to date, and= thanks for the patch (and to Jakub and Jeff for taking care of it). In general, I would prefer that a change like this would be made to apply t= o only versions of Darwin >=3D to the ones affected (so that the behaviour = for earlier versions is unchanged). As I read your patch, it alters things= for all versions. Having said that, the risk of bad effects is fairly low, and we can deal wi= th them if they occur, so it=E2=80=99s a reasonable patch (as has been OK= =E2=80=99d). Please CC me directly on Darwin patches; in case I miss them in other list = traffic. Whilst I cannot approve them - at least I will try to review and= make suggestions. Iain Sandoe CodeSourcery / Mentor Embedded / Siemens