On Jan 29, 2015, at 3:12 PM, Joseph Myers <joseph@codesourcery.com> wrote:
> On Mon, 26 Jan 2015, Mike Stump wrote:
> 
>> +  if (!INTEGRAL_TYPE_P (TREE_TYPE (expr))
>> +      || TREE_CODE (expr) != INTEGER_CST
>> +      || (lunroll = tree_to_shwi (expr)) < 0
>> +      || lunroll > USHRT_MAX)
>> +    {
>> +      c_parser_error (parser, "%<#pragma GCC unroll%> requires a non-negative number");
> 
> That error seems misleading for the case where a number above USHRT_MAX is 
> passed.

Fixed.

> There should also be tests for the error cases.

Fixed.

>> +      unroll = (unsigned short)lunroll;
> 
> Casts should have spaces in, "(unsigned short) lunroll"; see 
> codingconventions.html.

Fixed.