From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 73E723858D1E for ; Sat, 6 Apr 2024 05:50:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 73E723858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 73E723858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712382648; cv=none; b=m65hcG+SYQ1zLx9C2GBhqKm3i/CENhrCnzGzjTuzzf+asPFryTfKOLsPpaUUAQWpF7xelYGxWSj1s313H5aBGC0fU3Ku1W1VjtcxUynmboHmWgfXrO81UyNh5sBL1fltcPz3DoAmhr1IBBgcaFLyoctqoZYeGyLkoQiTum/5sx8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712382648; c=relaxed/simple; bh=p+13I6IUE8U+1ykgkT+o/M+tfrOCRHg2cq/z4REX3dU=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: Mime-Version:Subject:Date:Message-Id:To; b=t7GB2vem4dE3wg8CFS7Ea668IwQGU0Itf5siTmMgV+bfHQ4KQVlB/Tdj35zOwgA2/54ML5tQ8F6jgwnnNGKg+vux6LiE0cyr17EX7231pkTm0ZyER0UY4bhMl7YEtqq4ih3wqykghy4gwbRssMs9ZasrMbnc1BFtzq8Y+78xACA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0144221AE3; Sat, 6 Apr 2024 05:50:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712382644; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=19vQ8NdqadHItgwOsLvNXQPxUXAY8zD2eXASvD4OJfM=; b=kC4xX/up5+Qtjv3/ABO2ZMrSuCU9bv4oS0YLLIwxRkOTwNxHt55yH13k0AFmNIgwpEuoex 8IdZjgpuXqTMPyv3Tf+E6ym3QfK9uWwoPd909lUq6BaFq2MXecgSI6JdupMETBixSpNdZA QiNfzaiIWkZ7p8xd2FOXKHHaCJD//DI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712382644; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=19vQ8NdqadHItgwOsLvNXQPxUXAY8zD2eXASvD4OJfM=; b=kqPTRbS0GU6cKLOuk+4+0JcPJbke7bi52aIfbULybRXUJvX46UwMcqSRot7W3KtYxG5PZ6 7si+LZEtrIH816DQ== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712382643; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=19vQ8NdqadHItgwOsLvNXQPxUXAY8zD2eXASvD4OJfM=; b=ohmRx/8GnCV68anXKQ8n4ISPT0USd6Qxw8Fs3xiuHra5ZC2TcrXF69F/hsg5qLPsky3NJn 5v8+yOObR62NBC9TQfF58n/a+sgcMxonJhQiwZMw3tOhoFKBBSqYSSaFzZa1GUc8MkDbnK +rbbaN14igFznrRj1nk8xF1K5FYpi4U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712382643; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=19vQ8NdqadHItgwOsLvNXQPxUXAY8zD2eXASvD4OJfM=; b=Y1Q+2fVl80PkBKUiP0hGf+8ekAlCeKImR+4UCJiCpzyX9By9QzqrUUdpBgJnqAsSmUZxeN TRWmbXC3PDrHeCDg== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id E8459138E7; Sat, 6 Apr 2024 05:50:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap2.dmz-prg2.suse.org with ESMTPSA id +9OyOLLiEGZlQAAAn2gu4w (envelope-from ); Sat, 06 Apr 2024 05:50:42 +0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Richard Biener Mime-Version: 1.0 (1.0) Subject: Re: [PATCH 0/2] Condition coverage fixes Date: Sat, 6 Apr 2024 07:50:32 +0200 Message-Id: References: <20240405195831.2728853-1-j@lambda.is> Cc: gcc-patches@gcc.gnu.org, hjl.tools@gmail.com, hubicka@ucw.cz, ro@cebitec.uni-bielefeld.de In-Reply-To: <20240405195831.2728853-1-j@lambda.is> To: =?utf-8?Q?J=C3=B8rgen_Kvalsvik?= X-Mailer: iPhone Mail (21E236) X-Spam-Score: 0.16 X-Spam-Level: X-Spamd-Result: default: False [0.16 / 50.00]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; BAYES_HAM(-0.04)[57.42%]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_CC(0.00)[gcc.gnu.org,gmail.com,ucw.cz,cebitec.uni-bielefeld.de]; RCVD_TLS_ALL(0.00)[]; APPLE_IOS_MAILER_COMMON(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_TWO(0.00)[2]; TAGGED_RCPT(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap2.dmz-prg2.suse.org:helo,imap2.dmz-prg2.suse.org:rdns,gnu.org:url,lambda.is:email] X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Am 05.04.2024 um 21:59 schrieb J=C3=B8rgen Kvalsvik : >=20 > =EF=BB=BFHi, >=20 > I propose these fixes for the current issues with the condition > coverage. >=20 > Rainer, I propose to simply delete the test with __sigsetjmp. I don't > think it actually detects anything reasonable any more, I kept it around > to prevent a regression. Since then I have built a lot of programs (with > optimization enabled) and not really seen this problem. >=20 > H.J., the problem you found with -O2 was really a problem of > tree-inlining, which was actually caught earlier by Jan [1]. It probably > warrants some more testing, but I could reproduce by tuning your test > case to use always_inline and not -O2 and trigger the error. >=20 > [1] https://gcc.gnu.org/pipermail/gcc-patches/2024-April/648785.html Ok Thanks, Richard=20 > Thanks, > J=C3=B8rgen >=20 > J=C3=B8rgen Kvalsvik (2): > Remove unecessary and broken MC/DC compile test > Copy condition->expr map when inlining [PR114599] >=20 > gcc/testsuite/gcc.misc-tests/gcov-19.c | 11 --------- > gcc/testsuite/gcc.misc-tests/gcov-pr114599.c | 25 ++++++++++++++++++++ > gcc/tree-inline.cc | 20 +++++++++++++++- > 3 files changed, 44 insertions(+), 12 deletions(-) > create mode 100644 gcc/testsuite/gcc.misc-tests/gcov-pr114599.c >=20 > -- > 2.30.2 >=20