From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29633 invoked by alias); 27 Jul 2007 20:47:37 -0000 Received: (qmail 29615 invoked by uid 22791); 27 Jul 2007 20:47:36 -0000 X-Spam-Check-By: sourceware.org Received: from ug-out-1314.google.com (HELO ug-out-1314.google.com) (66.249.92.168) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 27 Jul 2007 20:47:34 +0000 Received: by ug-out-1314.google.com with SMTP id m2so864253ugc for ; Fri, 27 Jul 2007 13:47:31 -0700 (PDT) Received: by 10.66.220.17 with SMTP id s17mr3189198ugg.1185569251757; Fri, 27 Jul 2007 13:47:31 -0700 (PDT) Received: from ?144.82.208.57? ( [144.82.208.57]) by mx.google.com with ESMTPS id g17sm126173nfd.2007.07.27.13.47.30 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 27 Jul 2007 13:47:31 -0700 (PDT) In-Reply-To: <46AA4AAD.4000301@gmail.com> References: <46AA4AAD.4000301@gmail.com> Mime-Version: 1.0 (Apple Message framework v752.3) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Cc: gfortran , gcc-patches Content-Transfer-Encoding: 7bit From: FX Coudert Subject: Re: [Patch, fortran] PR 32909 Replace gfc_c_int_type_node with integer_type_node Date: Fri, 27 Jul 2007 22:04:00 -0000 To: Janne Blomqvist X-Mailer: Apple Mail (2.752.3) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-07/txt/msg02016.txt.bz2 > this is yet another obvious patch which I intend to commit in 24h, > barring objections. In many places in the frontend we were creating > a tree gfc_c_int_type_node to represent a C int. This is > unnecessary, since the middle-end already defines such a tree, > integer_type_node, which fwiw was already used in some places in > gfortran. Looks OK to me; I do remember introducing some of these occurences of gfc_c_int_type_node myself! :-) > 2007-07-27 Janne Blomqvist > > PR fortran/32909 > * trans-stmt.c (gfc_trans_character_select): Replace occurrences > of gfc_c_int_type_node with integer_type_node. > * trans-decl.c (gfc_build_intrinsic_function_decls): Likewise. > (gfc_build_builtin_function_decls): Likewise. > (gfc_generate_function_code): Likewise. > * trans-io.c (gfc_build_io_library_fndecls): Likewise.