From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 454473858D3C for ; Wed, 24 May 2023 14:22:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 454473858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34OEAYqh008464; Wed, 24 May 2023 14:22:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=GFV43advZxtAFuomGQBcrWj4Fx28/ji7VaR+P+uqDPs=; b=HD/9TkoUdlf5tJkeXZVSpfIJQLl/Z9Pn0+WB4p4zn/z6Ipgq+DED+jQMHmfGUiprDrmB q5kkeOCk9htWgXDJdSwZX/Wn3JKs4RqKqsLPQnZYKEh4BEkvCI5Z5lDmw6AfD/uvE7LE IaBeXNtyrwJTf8kkxoVSK5z9EfLiOzL0JQ6hcZ586FgIaX132LLr5+xLC6FaMyHckPNO omkudiKOoB/bYzImtEEm+bDkd74pfbRxUFoiwjTjBV7PxkxDPS7MyJiPDTg8nOO/VyEg uhaRqhVKx0NEsKHE8759/NjZl7jLvHy3YnPk1YsbL7QAAYLkM8R6TuXqktCEXdFux9eN OQ== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3qsm3j01rs-25 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 May 2023 14:22:12 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 34ODtV61016200; Wed, 24 May 2023 14:09:23 GMT Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam02lp2044.outbound.protection.outlook.com [104.47.51.44]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3qqk6ktmg7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 May 2023 14:09:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lIn8p5752rbzo8xVVKZvnOijzaa6rBLFmQ5IjRlxUMceQ10ijm0FcV0PyWmu+OZqKXv87Op7anznDvv1PL5wcnVZt3Brs+17i/hNJ+ctsWgK0P4GjAbrEZGGlhSPsYatANANeFKE4xHZhiJfw8pL6PNwcn4RmFH/P+VY5GJSlis8E3va6lx5LzjsBltVUaWjaksAMcItLTR6BRzzoT8Z0Tjy+OV0vvM2h5/yzCx9oRFjrgllKM13qft0AK1UeVIf+D2LJAFOg+mnxBY4MjDgC00jLNveQIL19F+HREpTmgdZK00TwdA1tnt5lWC0YUfrNUjU59Z0zKVoZpcpt03sxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GFV43advZxtAFuomGQBcrWj4Fx28/ji7VaR+P+uqDPs=; b=j9hCXye62Esqt8m6YjHMOWEcpPrtZ29xwo1MMrm8tarDG8qyBD/k/1UN8QKmIl71Irk9APBzmtDLZ6/owp+XJ40Eg7u0Fac8WsHtfBFNHltGMj3CmMvl76ZAq2xE5HcNKxWu0A0K+8ReGaL751YXL50MVMWrvjQ3L5dwPzJytWm+5ckxJ1vcpduUEOHlmPtqLxQLobNQlqryJfAt0fP0daLLCR57clUetXBk235+a7q9xRsOiuVKtLfTyLXa0kL6K9niRw5j5RLDaZHO1//77lbIdBNXhYkJlnMisOu4iF2aQ7hkTHkz3+8wkKEKr/ktbML0G5Hf7adqUerLa/Bc/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GFV43advZxtAFuomGQBcrWj4Fx28/ji7VaR+P+uqDPs=; b=JPFxww3abhxuzbgBTtcrfqQ/oVrnJc6jxETa4vT3+wRQCoFDe4Gb5QcTScMYX6axX+stER3QnBLqXEL8AdbGPZojf5m9pO6sMULEaEWZCmY5/qWHxE1forcUys5FT0eocjLU5esQMh93APyzCK0hg9wLk/ak+64NModc5rc0e2c= Received: from CH2PR10MB4344.namprd10.prod.outlook.com (2603:10b6:610:af::19) by DS0PR10MB6126.namprd10.prod.outlook.com (2603:10b6:8:c6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Wed, 24 May 2023 14:09:21 +0000 Received: from CH2PR10MB4344.namprd10.prod.outlook.com ([fe80::7aa1:df38:105a:21fa]) by CH2PR10MB4344.namprd10.prod.outlook.com ([fe80::7aa1:df38:105a:21fa%7]) with mapi id 15.20.6411.028; Wed, 24 May 2023 14:09:21 +0000 From: Qing Zhao To: Bernhard Reutner-Fischer CC: Qing Zhao via Gcc-patches , "joseph@codesourcery.com" , "richard.guenther@gmail.com" , "jakub@redhat.com" , "keescook@chromium.org" , "siddhesh@gotplt.org" , "uecker@tugraz.at" Subject: Re: [V7][PATCH 1/2] Handle component_ref to a structre/union field including flexible array member [PR101832] Thread-Topic: [V7][PATCH 1/2] Handle component_ref to a structre/union field including flexible array member [PR101832] Thread-Index: AQHZipN7tY8it/pvIEGa+hbI+f1zVq9iOVmAgAdEKYA= Date: Wed, 24 May 2023 14:09:21 +0000 Message-ID: References: <20230519204948.237791-1-qing.zhao@oracle.com> <20230519204948.237791-2-qing.zhao@oracle.com> <20230520011133.1d813add@nbbrfq.loc> In-Reply-To: <20230520011133.1d813add@nbbrfq.loc> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.3) x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH2PR10MB4344:EE_|DS0PR10MB6126:EE_ x-ms-office365-filtering-correlation-id: 26ee9063-32de-4e55-fdc8-08db5c6078c7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fMw7ZWju4BHtMVTCDFK3cWvXVZkQ8/kbbPFqssN0zhrcsxHjyZguaujqPw0vdey5KEX+5iKi2U7H+U/rC9L46VuHZQk1n7s6VmLFsFkP8/T81jxP+uXY3jPVXDyxyQWF9poGoN0RfjaVxFMknVzwapmXarUiz4xrTqe4Kw0kIuhvuMvEl2juWXMKLFX1ZSyTXEELDSy2qsTp750BGdNCKaNMfCRWpi0a5OXnqL/8aDcYN/oaqyOPFKIh4JzTic3OkKMCqUdVwwfUxWqOc6oevI61L2a/khku7hJTPZMMB/1LXMUsSH1ekFR9QXy6Fuhk+Npi2kYpdpmvGo6wxtf84+zGUqGcuISyiUHtuI45URgkyZSvQGAPLAGen406rWvIn7FX2XSnF6J3ZBvBNdjusrm4yEblOY2e5MSKctr2gIsVuoghXQ3iibSvVtJeAC3Q7yrkilN8BveQVi3hbBCF/+LfTho+RAiF6vXI9YTo3a4YKYmYSJiz35PHN0kO96nwclxal1kj5KrTxWqZM9CzsjaFwdCWvkCPLUElmLxtNKgIJ8bAwXlgKOE4hcC6PfvT0Y9g54DzR3Kcjwg9zDpRZ0n4sjebpM9C/TmMBlewoLMlRhTRh/YTiNxAtQjsntwykS+k+SqZal6KfAELsMl8DQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR10MB4344.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(396003)(136003)(366004)(346002)(376002)(451199021)(2906002)(54906003)(5660300002)(8676002)(8936002)(44832011)(91956017)(41300700001)(66556008)(4326008)(76116006)(6916009)(66946007)(66446008)(64756008)(66476007)(316002)(478600001)(36756003)(71200400001)(33656002)(6486002)(53546011)(6512007)(6506007)(122000001)(86362001)(38100700002)(2616005)(186003)(83380400001)(38070700005)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6v/BDNM5vO776asfTLfihG5v0uOv6b2UvY06dWhm3f8Y0taY2Z8Dsu9O6woK?= =?us-ascii?Q?Xm9k3xL+yGOUNxO681Kohty6+qG1o5qH5Jlc+tQDIcilcXMuCaRks0dsPB3O?= =?us-ascii?Q?vO/q5y60JSiD10ksapQSOuM3C3pd7SN+AbQvnRaH2MdHkEr3cV8EyZLVvr8S?= =?us-ascii?Q?vQwGAXOQDNCOyEzjIPYJD5rbR2rN+lUgjvwByRHG1B9ieqwAo4+qX4uvG3PP?= =?us-ascii?Q?QAKKlrx9wT0kkvd6doEzJDkXM7JH2geqjP0txgXuXifplcXSWxoW5jZwwzFg?= =?us-ascii?Q?ayNtwiCotFK0L0DabjyrPTy7fUS2PkpiESQUU6e7+/V3xweLNwYnwFz/aRLq?= =?us-ascii?Q?L4KLUYxrfskSPk78mh0Jq8kOd3MgraKz5QJv0akwhTg8hsgW8WXJnObcbL89?= =?us-ascii?Q?LUk2av1x2v/x0Wma/K3rSNlKqM1ocZJEBvakGJcrUclTvdVIxazcckR+MFgm?= =?us-ascii?Q?rwLODU+IetIcibeUw3bTs2OH6OWKr7YspvZdmX+m7SmLgki3r1IU2n6bpy2a?= =?us-ascii?Q?PXlDIaeeC7YgQz0jLj0Jcbm8LvnU89VySaaK5R5a5sCRFyIKp3pfb0npAF1g?= =?us-ascii?Q?hB5B9EQuZ/JOPJo/cyDz2vxQpfVjIIPSZPrLVn8hNGLkgVkZpTMh4AmQjG91?= =?us-ascii?Q?XJwJrTX1CNIqvXRj4wdzbC1Pp5iMzE/NR36q8RxnUn1LwSnVtXIG/3yHfsUI?= =?us-ascii?Q?/JL0eVy/LyZ/XSP9K8322P4hywo5pKCsjOyIDe80Bzkmb8N+U6M9ibz4kWNJ?= =?us-ascii?Q?BTaUtD8X7E0n0exLm+6gbAPkW8lmohkwbXkVBRlN2y7Pp0OLGxuS5POyK9IV?= =?us-ascii?Q?++Hi5yQFiNOFxNCVMe1iCAe5hqLYRY0nkc4+QZMsjloqTNw9LWTphDUtJ2kb?= =?us-ascii?Q?8EotanA9eXkvoSXuyGwb6YLqGb2vD3pAHjlCDfuq/isoa6HzA0O+yE2GRVLM?= =?us-ascii?Q?i2jCPubDdybBceeUMoh7yZVXk3ADRhuwFMdAGJ/bDU1+svn0GX1EPuiGfLZP?= =?us-ascii?Q?OxSJZT4OoiDciKp8BHM8I0qzIZDB2kjccfVSIPNDwk+pzwmmjfcVuZsqBej/?= =?us-ascii?Q?s31d9+9mfuzaUs4gn00e0A2uhaJtIVr8Pm0PgOTPRsNSSsbIupS2oVdbWoC3?= =?us-ascii?Q?m15oI3eLb0fKmT7aC/N1xCp/4GI3vTQ5j/L81a82taA8b0tvyZYprel/n0ps?= =?us-ascii?Q?tS3PTMQdjx7FdhQsDsYh+K7QskGc4nxYrEVi0JpwPreYyxV1ZUgWQSF0EDSo?= =?us-ascii?Q?kX1z4odFQnEL3zUTFTHvyWZpDmKu6mXNjuo35UgXi82BTKgn/Q0h/9CxmhdA?= =?us-ascii?Q?KdzPSbqZM3ZLEnj63K8UB7xaSQena0b5IujfQ90gWEfJiVyDkC8kFv7pp+55?= =?us-ascii?Q?L48VYRouPBQbRd8WYXS9VUarzyfEZNQVVatNRbhdT2xa6OOpUWfOtKT6yS6g?= =?us-ascii?Q?NP7OcYg/JFogW2N+VYFNb9Ar9m7TcIuU+Y5LNamqjuXcKHCqJPEE4Fhk6qcv?= =?us-ascii?Q?ajR/2PMxNFvZvWNnk8rad6a0sFadu8bcsVC6uup3LTzwbMeidWCl3oCYDcGO?= =?us-ascii?Q?MqwFwavhhzghanM00K3J++uEgviD9RxDjBJsJjhGxlMVXvqGnsYkFG3rQTKx?= =?us-ascii?Q?fXy52Kt7BuPM52/6GUiwCQE=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <6D4BB55663557146B9C88DE0BC1F35D4@namprd10.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?H3/aIDmXP2E/lR6+PMXWimp3S8Pi00NitHxfWmfg5afwqSJffYIZMCEWpLQy?= =?us-ascii?Q?sRp35/qNvEvYRTX0AAT8mwfIelKqRREQbqKA/56qRp7QM3ME3s8suku37k+j?= =?us-ascii?Q?ZnM6iUPyLjwR+ccfPIM+nZyu+Eh/N11L1XVEgflnEvxZdhP6/Et8yXq8vI5r?= =?us-ascii?Q?5NIvp1yORICELqtqf3OKG7JaDlKCSpymHdXfoMf5nBWCUDeiSe9roOyCZe0y?= =?us-ascii?Q?Fr0TcxFKJUbJ1V0EZjC2TCbClDNAcBCvSdZdh1bTkmLHz9hf6qHJKMBmA2aP?= =?us-ascii?Q?+og8jrzVo/HV6bDi2Kb2GeFONM9Ue+aeXEgUFVc5DH9X8sEYLi//NwDEeLA6?= =?us-ascii?Q?9BBj6EALadJpdjA89wPM5VyPyVz0JZp1llhZ3oM0bm/XsjjS0b5VvR4KCZOH?= =?us-ascii?Q?CgU0GYxeZ68piLLldCcOqL21AzP5EssmMGw5dsXkEghElWReGVkjoXAF+KLJ?= =?us-ascii?Q?RqmBvRLD4hVQOOBJvUGQGTQd26W45FW8hRjonjp07V8I2s5F2EaEjtQ6jVBg?= =?us-ascii?Q?8GX/GzYXFb/6iuuPy0vqr8k/bZZm8rrwu1DSHd6ZssZvFdhcYxVbuP12hQJZ?= =?us-ascii?Q?eAT6Eue5lZbAvJ0vCSX+9j2HDLpqyixqdb+hQR6WjhoqmcTlFvBHQmpdKSaw?= =?us-ascii?Q?lRbmJRdKWuIh710hPo4WnJ5blYYAaT25JIkwaeaSpSUCfbJCPIqgsdbhxS87?= =?us-ascii?Q?iJAdBdxLfYlf17MedC977LbSaEtUapF8aF0H73w0sUrRK28GdZMADUFYaRTb?= =?us-ascii?Q?wi42N+4Pvxj0IBBbS0ARSI0qUyHqgauivwWCVBkvp3gjiNNaYgA7LQ+eyNqQ?= =?us-ascii?Q?KAAuAH0nHa5IZp07dCpmq47rSdgjQCH0uOcThgeIdVY235fn87Vr1A98RKSM?= =?us-ascii?Q?JUL69bmxixOQ//Q+gfDx9TuTMyv6fYZRcY/MlNnTpH6zuzi4gzfkllzEOShT?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4344.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 26ee9063-32de-4e55-fdc8-08db5c6078c7 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2023 14:09:21.5866 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RcoM8HS7cHGvB3vNw4fGZQXxZ/MiD4YiHH3xbd5WUTc4SjK13iSgDHV0/A2Hh7mqlKiNFocNubIPcVPzQzgKXw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6126 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-05-24_09,2023-05-24_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 bulkscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305240115 X-Proofpoint-ORIG-GUID: aU9BZmfBGYehPdK1KBf7Ta9cjO0qCsir X-Proofpoint-GUID: aU9BZmfBGYehPdK1KBf7Ta9cjO0qCsir X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Bernhard, Thanks a lot for your comments. > On May 19, 2023, at 7:11 PM, Bernhard Reutner-Fischer wrote: >=20 > On Fri, 19 May 2023 20:49:47 +0000 > Qing Zhao via Gcc-patches wrote: >=20 >> GCC extension accepts the case when a struct with a flexible array membe= r >> is embedded into another struct or union (possibly recursively). >=20 > Do you mean TYPE_TRAILING_FLEXARRAY()? The following might be more accurate description: GCC extension accepts the case when a struct with a flexible array member is embedded into another struct or union (possibly recursively) as the las= t field. >=20 >> diff --git a/gcc/tree.h b/gcc/tree.h >> index 0b72663e6a1..237644e788e 100644 >> --- a/gcc/tree.h >> +++ b/gcc/tree.h >> @@ -786,7 +786,12 @@ extern void omp_clause_range_check_failed (const_tr= ee, const char *, int, >> (...) prototype, where arguments can be accessed with va_start and >> va_arg), as opposed to an unprototyped function. */ >> #define TYPE_NO_NAMED_ARGS_STDARG_P(NODE) \ >> - (TYPE_CHECK (NODE)->type_common.no_named_args_stdarg_p) >> + (FUNC_OR_METHOD_CHECK (NODE)->type_common.no_named_args_stdarg_p) >> + >> +/* True if this RECORD_TYPE or UNION_TYPE includes a flexible array mem= ber >> + at the last field recursively. */ >> +#define TYPE_INCLUDE_FLEXARRAY(NODE) \ >> + (RECORD_OR_UNION_CHECK (NODE)->type_common.no_named_args_stdarg_p) >=20 > Until i read the description above i read TYPE_INCLUDE_FLEXARRAY as an > option to include or not include something. The description hints more > at TYPE_INCLUDES_FLEXARRAY (with an S) to be a type which has at least > one member which has a trailing flexible array or which itself has a > trailing flexible array. Yes, TYPE_INCLUDES_FLEXARRAY (maybe with a S is a better name) means the st= ructure/union TYPE includes a flexible array member or includes a struct wi= th a flexible array member as the last field. Hope this is clear. thanks. Qing >=20 >>=20 >> /* In an IDENTIFIER_NODE, this means that assemble_name was called with >> this string as an argument. */ >=20