From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27579 invoked by alias); 26 Sep 2016 15:55:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 27562 invoked by uid 89); 26 Sep 2016 15:55:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Shell, H*Ad:U*devel X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-wm0-f67.google.com Received: from mail-wm0-f67.google.com (HELO mail-wm0-f67.google.com) (74.125.82.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Sep 2016 15:55:46 +0000 Received: by mail-wm0-f67.google.com with SMTP id b184so14785902wma.3; Mon, 26 Sep 2016 08:55:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:in-reply-to:references:mime-version :content-transfer-encoding:subject:from:date:to:cc:message-id; bh=c4AJ46AJx5gMKNZg0p/b+M0bLLwDtjc9waFU0N02H9E=; b=KZD7Y3FzuuaQyr8XEgOt081nxiR8ZhGXPm7xqUweavvQiYcd2nKN/LT3MpRUxYezb1 epyAVKiBkIagy9QoGoQD9fn/c5GsQ6NSomfG53YMZh4ittEX8Clj7EgPn7WzuWUELTB+ 6XhXLUsKPpiskKTAOjMaP77paaHuFn7eVTKaFZIVwjQVhDZckW5WrHYn3hi11hQZ6Uuq 5CEVoIEw8tymx38eSoiUCJkoO10pSN8/1fPOoc8LnpAU3YIxRgnQ+aGY18Rf+rkIirZB CTqrQ4xnSXxAukzJuPx4tsMibsDEhAlI+LcRR1cIY2bAntNwe0kFNHiXkLxrrz89nX9p q60A== X-Gm-Message-State: AA6/9RnRTDyl9kr/ghSQzXFLVsFeNZ9Y1sxmYwZKSwS9+1TZrQwjYf3ap2lTn87Od9Sg+Q== X-Received: by 10.28.134.8 with SMTP id i8mr14174773wmd.59.1474905344414; Mon, 26 Sep 2016 08:55:44 -0700 (PDT) Received: from [10.62.130.241] (089144194241.atnat0003.highway.a1.net. [89.144.194.241]) by smtp.gmail.com with ESMTPSA id q10sm11909284wme.6.2016.09.26.08.55.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Sep 2016 08:55:43 -0700 (PDT) In-Reply-To: References: <1474534063-8867-1-git-send-email-sebastian.huber@embedded-brains.de> <5FFB22EA-59B1-4E74-A8E6-3247012D4097@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH v2] [RTEMS] Always use atomic builtins for libstdc++ From: Bernhard Reutner-Fischer Date: Mon, 26 Sep 2016 15:59:00 -0000 To: Andreas Schwab CC: Sebastian Huber ,gcc-patches@gcc.gnu.org,libstdc++@gcc.gnu.org,devel@rtems.org Message-ID: X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg01854.txt.bz2 On 26 September 2016 10:27:13 CEST, Andreas Schwab wrote: >On Sep 22 2016, Bernhard Reutner-Fischer wrote: > >> On 22 September 2016 11:11:42 CEST, Andreas Schwab >wrote: >>>On Sep 22 2016, Sebastian Huber >>>wrote: >>> >>>> diff --git a/libstdc++-v3/acinclude.m4 b/libstdc++-v3/acinclude.m4 >>>> index 6d897be..d7db435 100644 >>>> --- a/libstdc++-v3/acinclude.m4 >>>> +++ b/libstdc++-v3/acinclude.m4 >>>> @@ -3490,9 +3490,10 @@ EOF >>>> AC_LANG_RESTORE >>>> >>>> # Set atomicity_dir to builtins if all but the long long test >>>above passes. >>>> - if test "$glibcxx_cv_atomic_bool" = yes \ >>>> + if { test "$glibcxx_cv_atomic_bool" = yes \ >>>> && test "$glibcxx_cv_atomic_short" = yes \ >>>> - && test "$glibcxx_cv_atomic_int" = yes; then >>>> + && test "$glibcxx_cv_atomic_int" = yes } \ >>> >>>You need a semicolon (or newline) before }. >> >> Please remind me why you need curly braces at all? > >Shell operand precedence is non-intuitive. [ ... -a ... -a ... ] as per at least SUSv4. thanks