public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andrew Pinski <pinskia@physics.uc.edu>
To: Richard Henderson <rth@redhat.com>
Cc: "gcc-patches@gcc.gnu.org Patches" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] fix PR middle-end/17885, gimplifing of volatile &a->b
Date: Mon, 18 Oct 2004 18:41:00 -0000	[thread overview]
Message-ID: <F4F3800E-2131-11D9-B4B8-000A95D692F4@physics.uc.edu> (raw)
In-Reply-To: <20041018175459.GB24159@redhat.com>


On Oct 18, 2004, at 1:54 PM, Richard Henderson wrote:

> On Mon, Oct 18, 2004 at 10:24:45AM -0400, Andrew Pinski wrote:
>> 	* gimplify.c (gimplify_expr): Handle ADDR_EXPR when
>> 	we have volatile types but the expression it self is
>> 	not volatile.
>
> Without further information, I think this is wrong.  Why
> in the world is TREE_SIDE_EFFECTS for such an ADDR_EXPR?

Because the COMPONENT_REF has its TREE_SIDE_EFFECTS set
then by recompute_tree_invarant_for_addr_expr
so does the ADDR_EXPR, this might be a bug in
that function though.

Thanks,
Andrew Pinski

  reply	other threads:[~2004-10-18 18:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-18 14:25 Andrew Pinski
2004-10-18 17:56 ` Richard Henderson
2004-10-18 18:41   ` Andrew Pinski [this message]
2004-10-18 21:22     ` Richard Henderson
2004-10-18 21:35     ` Richard Henderson
2004-10-18 19:49 ` Jeffrey A Law
2004-10-18 19:41 Richard Kenner
2004-10-18 19:46 ` Jason Merrill
2004-10-18 19:50 Richard Kenner
2004-10-18 19:57 Richard Kenner
2004-10-18 20:39 ` Andrew Pinski
2004-10-18 21:00 Richard Kenner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F4F3800E-2131-11D9-B4B8-000A95D692F4@physics.uc.edu \
    --to=pinskia@physics.uc.edu \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).