From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id C12EA3858D35 for ; Tue, 27 Dec 2022 16:54:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C12EA3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wm1-x334.google.com with SMTP id m26-20020a05600c3b1a00b003d9811fcaafso3189740wms.5 for ; Tue, 27 Dec 2022 08:54:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:from:to:cc:subject:date:message-id :reply-to; bh=eJOTX7cYFSC64zekysvz56m6WVz39M40ds0eskQrnag=; b=BHgMBLoEHsGzAMywkWZEDgcIrh2mE954jsYP9E4PaLWAv4CH2DfUP5MMm9cyHmyTmT dA8wDWNP2JoZOLnsJj/LGlVRvbzBKP648OX1wku1+wqakxVXhXjU6DKiTZh1V6rQm0gn IImusW0oL/VARxTODLwQGn+PrwJE1PgujUevSOAkO4ZW0Xr64CsraDw+jEkPp35Ja33s QbOw5FFoVc3Lrchwiw6m49lciS9wHPWyWDss8tEfg/EdCFqvCKnOmJXlYsnbscf1Cm57 xclvOzEMsV7OfR+Zfovo/eT8Rx8QWOJwXQ/OimB92SR7POfW2mTu9BkZnTiDMcvIambS KJ9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eJOTX7cYFSC64zekysvz56m6WVz39M40ds0eskQrnag=; b=f4x552gTY3AYEjEr5qkbv1yHerV2dof04gkCROD0skMN5mjR0PUbWadJ7D5CbAag35 Yj4oTAJPmPwDcjZv7QnPGJ9GGrvJBJEyo8AYuWT2KektXyKTZlGLHBGhEm+Le+nDkafB AT4dvBOLiX6loMWDzF8UOUJSHQgiBi7JRcO5UP5YyO4u710cG9Nf8GeUBVqlT+AK2FH3 HgDIkCVcOS1Hmz6pqv19MDb4HpCqYARa7Vs8GBgWVJtyjFAd9uyyF1dSMDaemYdFUn4R WWvoGe0CVyw0kqu4QnzY2ho9GXzfhNCglWjCnB+ifU3SRrRsWBCM2qHXR6JQYpovhWJ0 U8qQ== X-Gm-Message-State: AFqh2kqeTKOd8t6BW+/tfweFuDD5inY5EJUirgJvuxsaBmGD8ZoIW52G uU+7tLDJ8Zb0ylcNhLEkraZxYw== X-Google-Smtp-Source: AMrXdXtvV3mL6rSYAPNXH66JKKJA4Peoee845FGw3Rp1EkS2gEGzCX/4DloPKtHkIwEqSBzZIIifwQ== X-Received: by 2002:a05:600c:d2:b0:3d2:2b70:f2fd with SMTP id u18-20020a05600c00d200b003d22b70f2fdmr16042712wmm.21.1672160073370; Tue, 27 Dec 2022 08:54:33 -0800 (PST) Received: from smtpclient.apple ([2a01:e0a:4f5:c610:98bb:7730:1122:e81f]) by smtp.gmail.com with ESMTPSA id bd25-20020a05600c1f1900b003cfd4cf0761sm22870764wmb.1.2022.12.27.08.54.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Dec 2022 08:54:32 -0800 (PST) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable From: Arnaud Charlet Mime-Version: 1.0 (1.0) Subject: Re: [11/13] ada: don't map NULL decl to locus Date: Tue, 27 Dec 2022 17:54:21 +0100 Message-Id: References: <9f969824-dc72-404c-13a4-182b13702cec@gmail.com> Cc: Alexandre Oliva , gcc-patches@gcc.gnu.org, Eric Botcazou , =?utf-8?Q?Marc_Poulhi=C3=A8s?= , Pierre-Marie de Rodat In-Reply-To: <9f969824-dc72-404c-13a4-182b13702cec@gmail.com> To: Jeff Law X-Mailer: iPhone Mail (20B110) X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> When decl is NULL, don't record its mapping in the >> decl_to_instance_map. >> Regstrapped on x86_64-linux-gnu. Ok to install? >> for gcc/ada/ChangeLog >> * gcc-interface/trans.cc (Sloc_to_locus): Don't map NULL decl. > OK assuming that a NULL "decl" is valid -- you're in a much better positio= n than me to assess validity of a NULL "decl" here. I confirm that this is OK and expected. Arno=