* [patch] PR 79842 - i18n: subword translation in "Can't use the same %smodule"
@ 2019-04-11 9:57 Dominique d'Humières
2019-04-13 15:29 ` Dominique d'Humières
0 siblings, 1 reply; 2+ messages in thread
From: Dominique d'Humières @ 2019-04-11 9:57 UTC (permalink / raw)
To: roland.illig, Paul Richard Thomas; +Cc: gfortran, gcc-patches
Hi all,
I am planning to commit the following patch
--- ../_clean/gcc/fortran/module.c 2019-03-21 20:46:46.000000000 +0100
+++ gcc/fortran/module.c 2019-04-11 10:28:37.000000000 +0200
@@ -7144,8 +7144,12 @@ gfc_use_module (gfc_use_list *module)
for (p = gfc_state_stack; p; p = p->previous)
if ((p->state == COMP_MODULE || p->state == COMP_SUBMODULE)
&& strcmp (p->sym->name, module_name) == 0)
- gfc_fatal_error ("Cannot USE the same %smodule we're building",
- p->state == COMP_SUBMODULE ? "sub" : "");
+ {
+ if (p->state == COMP_SUBMODULE)
+ gfc_fatal_error ("Cannot USE a submodule that is currently built");
+ else
+ gfc_fatal_error ("Cannot USE a module that is currently built");
+ }
init_pi_tree ();
init_true_name_tree ();
While testing it I did not find any coverage of these errors in the test suite.
TIA
Dominique
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch] PR 79842 - i18n: subword translation in "Can't use the same %smodule"
2019-04-11 9:57 [patch] PR 79842 - i18n: subword translation in "Can't use the same %smodule" Dominique d'Humières
@ 2019-04-13 15:29 ` Dominique d'Humières
0 siblings, 0 replies; 2+ messages in thread
From: Dominique d'Humières @ 2019-04-13 15:29 UTC (permalink / raw)
To: roland.illig, Paul Richard Thomas; +Cc: gfortran, gcc-patches
Committed as revision r270338.
Dominique
> Le 11 avr. 2019 à 11:54, Dominique d'Humières <dominiq@lps.ens.fr> a écrit :
>
> Hi all,
>
> I am planning to commit the following patch
>
> --- ../_clean/gcc/fortran/module.c 2019-03-21 20:46:46.000000000 +0100
> +++ gcc/fortran/module.c 2019-04-11 10:28:37.000000000 +0200
> @@ -7144,8 +7144,12 @@ gfc_use_module (gfc_use_list *module)
> for (p = gfc_state_stack; p; p = p->previous)
> if ((p->state == COMP_MODULE || p->state == COMP_SUBMODULE)
> && strcmp (p->sym->name, module_name) == 0)
> - gfc_fatal_error ("Cannot USE the same %smodule we're building",
> - p->state == COMP_SUBMODULE ? "sub" : "");
> + {
> + if (p->state == COMP_SUBMODULE)
> + gfc_fatal_error ("Cannot USE a submodule that is currently built");
> + else
> + gfc_fatal_error ("Cannot USE a module that is currently built");
> + }
>
> init_pi_tree ();
> init_true_name_tree ();
>
> While testing it I did not find any coverage of these errors in the test suite.
>
> TIA
>
> Dominique
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-13 11:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-11 9:57 [patch] PR 79842 - i18n: subword translation in "Can't use the same %smodule" Dominique d'Humières
2019-04-13 15:29 ` Dominique d'Humières
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).