From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by sourceware.org (Postfix) with ESMTPS id F12813854803 for ; Tue, 3 Nov 2020 10:24:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F12813854803 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hainque@adacore.com Received: by mail-wr1-x42c.google.com with SMTP id n15so17944700wrq.2 for ; Tue, 03 Nov 2020 02:24:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=IUezN8o25ZGJr51EKdhwMKL7hYxhUMaOvnb/ns3nPJw=; b=sHORQTCfdVM9T43/PhEVm8pwmGDjeRTnO3cpDuiRKjarCTNv2gi+BK1nY02YRbI2Ms 86X3rf8oaqRBXha75admKQltyMHBLqpPg5+CAR5+O8d7FuHz+QpAV00ag9586i9CuB9x FwX8d0Kv/gio8iJrGw3yLucEP+DxqJnt9ts5bnNnwnWxRwO9B7aYxv3tIro5tOJS97aR jvp4/pk0WYyW4hG4dYCHyz7MAmk1Iyxio1Vs507wiS/LivoJVg7vPYvmHadkPElLEeTN GnbAxPbMqY8lJcMHzzoYD3Ye8BydqHHte36oawr/tqbNi+9zQFl06CpcV2fiMBEG16YP Lh2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=IUezN8o25ZGJr51EKdhwMKL7hYxhUMaOvnb/ns3nPJw=; b=XTdTlWTG2A7ogPpvnWvsSHF+lDSXD+10Wj34QZR0ntVabnH7d/CF431T3K+hoxue/x mYZpXbRNHa6umhTe1qJJTxI3ImSYUdRAmpjS+urVHTsPl+HhohqhdpSzb/OXBhvWIERH Dldrj+E7FVsntaDDriaUflWyqhDvD8Tt/3x21bQhCmoRwX89RNCzNX64/boKo2TzaMuP Nr85hUCQ9Tsh/LD73rHSw0sDrDYZt1D5sAaFN/rnPz/Gb2DIU1cQkiX24aAptJeClJeN GfDWmkV4UsTZ0xI2tilQSy6BvFPwN+7ssKeOQ3TcsDVeUg5IR/kfyelRMvN75PeHQcE6 S+Zg== X-Gm-Message-State: AOAM531S406GYT7PPjC5inWB8T/CMt2eXS3/REWrKKAY1DU7B10U8cls PC29a/mZ0UMzOZowi8TrciF6ZA== X-Google-Smtp-Source: ABdhPJx5b4LaAAIi5ymDqiYH59ZrmUOcC91ZWsTlSME+b4rZRqPQLc8/Py6D76gQJzU21Sr+8gVQmg== X-Received: by 2002:adf:fc8b:: with SMTP id g11mr25445222wrr.300.1604399065022; Tue, 03 Nov 2020 02:24:25 -0800 (PST) Received: from imac-2020.home (2a01cb0002912700c921525f97225fe4.ipv6.abo.wanadoo.fr. [2a01:cb00:291:2700:c921:525f:9722:5fe4]) by smtp.gmail.com with ESMTPSA id b7sm24758288wrp.16.2020.11.03.02.24.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Nov 2020 02:24:24 -0800 (PST) From: Olivier Hainque Message-Id: Content-Type: multipart/mixed; boundary="Apple-Mail=_7B1C53FB-CA2C-41E6-B437-1F7E724F8733" Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: [patch] i386 tests: Add dg-require-effective-target fpic to gcc.target/i386 tests Date: Tue, 3 Nov 2020 11:24:24 +0100 In-Reply-To: <20201103083053.GM3788@tucnak> Cc: Olivier Hainque , GCC Patches To: Jakub Jelinek References: <9FFB6F0E-EDAF-419B-9D1D-FACA9E8896E0@adacore.com> <20201103083053.GM3788@tucnak> X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2020 10:24:28 -0000 --Apple-Mail=_7B1C53FB-CA2C-41E6-B437-1F7E724F8733 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii > On 3 Nov 2020, at 09:30, Jakub Jelinek wrote: > 70% of the tests you've changed have a target *-linux* or similar > right above that line, what is the point of adding the fpic > effective targets to those? Those surely aren't run on vxWorks > and on x86 Linux fpic is always supported. Good point. We had quite a few actual failures and I did a pretty systematic search, missing the linux implication. > No objection to adding it to the rest. Ok, amended change below. Thanks for your prompt feedback on this Jakub! Best Regards, Olivier 2020-11-03 Olivier Hainque gcc/testsuite/ * gcc.target/i386/pr45352-1.c: Add dg-require-effective-target fpic. * gcc.target/i386/pr47602.c: Likewise. * gcc.target/i386/pr55151.c: Likewise. * gcc.target/i386/pr55458.c: Likewise. * gcc.target/i386/pr56348.c: Likewise. * gcc.target/i386/pr57097.c: Likewise. * gcc.target/i386/pr65753.c: Likewise. * gcc.target/i386/pr65915.c: Likewise. * gcc.target/i386/pr66232-5.c: Likewise. * gcc.target/i386/pr66334.c: Likewise. * gcc.target/i386/pr66819-2.c: Likewise. * gcc.target/i386/pr67265.c: Likewise. * gcc.target/i386/pr81481.c: Likewise. * gcc.target/i386/pr83994.c: Likewise. --Apple-Mail=_7B1C53FB-CA2C-41E6-B437-1F7E724F8733 Content-Disposition: attachment; filename=dg-require-fpic-i386-not-linux.txt Content-Type: text/plain; x-unix-mode=0640; name="dg-require-fpic-i386-not-linux.txt" Content-Transfer-Encoding: quoted-printable --- gcc/testsuite/gcc.target/i386/pr45352-1.c | 1 + gcc/testsuite/gcc.target/i386/pr47602.c | 1 + gcc/testsuite/gcc.target/i386/pr55151.c | 1 + gcc/testsuite/gcc.target/i386/pr55458.c | 1 + gcc/testsuite/gcc.target/i386/pr56348.c | 1 + gcc/testsuite/gcc.target/i386/pr57097.c | 1 + gcc/testsuite/gcc.target/i386/pr65753.c | 1 + gcc/testsuite/gcc.target/i386/pr65915.c | 1 + gcc/testsuite/gcc.target/i386/pr66232-5.c | 1 + gcc/testsuite/gcc.target/i386/pr66334.c | 1 + gcc/testsuite/gcc.target/i386/pr66819-2.c | 1 + gcc/testsuite/gcc.target/i386/pr67265.c | 1 + gcc/testsuite/gcc.target/i386/pr81481.c | 1 + gcc/testsuite/gcc.target/i386/pr83994.c | 1 + 14 files changed, 14 insertions(+) diff --git a/gcc/testsuite/gcc.target/i386/pr45352-1.c = b/gcc/testsuite/gcc.target/i386/pr45352-1.c index 5cd1bd842d80..f5e96b270166 100644 --- a/gcc/testsuite/gcc.target/i386/pr45352-1.c +++ b/gcc/testsuite/gcc.target/i386/pr45352-1.c @@ -1,4 +1,5 @@ /* { dg-do compile } */ +/* { dg-require-effective-target fpic } */ /* { dg-options "-mtune=3Damdfam10 -O3 -fpeel-loops = -fselective-scheduling2 -fsel-sched-pipelining -fPIC" } */ =20 static int FIR_Tab_16[16][16]; diff --git a/gcc/testsuite/gcc.target/i386/pr47602.c = b/gcc/testsuite/gcc.target/i386/pr47602.c index fa5f5bd7d351..5ed1e1fd490c 100644 --- a/gcc/testsuite/gcc.target/i386/pr47602.c +++ b/gcc/testsuite/gcc.target/i386/pr47602.c @@ -1,5 +1,6 @@ /* { dg-do compile } */ /* { dg-require-effective-target ia32 } */ +/* { dg-require-effective-target fpic } */ /* { dg-options "-fPIC" } */ =20 /* Test verifies that %ebx is no longer fixed when generating PIC code = on i686. */ diff --git a/gcc/testsuite/gcc.target/i386/pr55151.c = b/gcc/testsuite/gcc.target/i386/pr55151.c index 62da8cb7781e..d6255a83dee7 100644 --- a/gcc/testsuite/gcc.target/i386/pr55151.c +++ b/gcc/testsuite/gcc.target/i386/pr55151.c @@ -1,5 +1,6 @@ /* PR rtl-optimization/55151 */ /* { dg-do compile { target { ! ia32 } } } */ +/* { dg-require-effective-target fpic } */ /* { dg-options "-fPIC" } */ =20 int a, b, c, d, e, f, g, h, i, j, k, l; diff --git a/gcc/testsuite/gcc.target/i386/pr55458.c = b/gcc/testsuite/gcc.target/i386/pr55458.c index 7164ca905db2..1dea55c50c9e 100644 --- a/gcc/testsuite/gcc.target/i386/pr55458.c +++ b/gcc/testsuite/gcc.target/i386/pr55458.c @@ -1,5 +1,6 @@ /* { dg-do compile } */ /* { dg-require-effective-target ia32 } */ +/* { dg-require-effective-target fpic } */ /* { dg-options "-fPIC" } */ =20 /* Test verifies that %ebx is no longer fixed when generating PIC code = on i686. */ diff --git a/gcc/testsuite/gcc.target/i386/pr56348.c = b/gcc/testsuite/gcc.target/i386/pr56348.c index c31814f60f47..93423d9190d9 100644 --- a/gcc/testsuite/gcc.target/i386/pr56348.c +++ b/gcc/testsuite/gcc.target/i386/pr56348.c @@ -1,5 +1,6 @@ /* PR target/56348 */ /* { dg-do compile { target ia32 } } */ +/* { dg-require-effective-target fpic } */ /* { dg-options "-O2 -fPIC -mfpmath=3Dsse -msse2" } */ =20 typedef unsigned int size_t; diff --git a/gcc/testsuite/gcc.target/i386/pr57097.c = b/gcc/testsuite/gcc.target/i386/pr57097.c index 2f0093840df5..debacbfc048b 100644 --- a/gcc/testsuite/gcc.target/i386/pr57097.c +++ b/gcc/testsuite/gcc.target/i386/pr57097.c @@ -1,4 +1,5 @@ /* { dg-do compile } */ +/* { dg-require-effective-target fpic } */ /* { dg-options "-O2 -fPIC" } */ extern double ad[], bd[], cd[], dd[]; extern long long all[], bll[], cll[], dll[]; diff --git a/gcc/testsuite/gcc.target/i386/pr65753.c = b/gcc/testsuite/gcc.target/i386/pr65753.c index 562f54bff6bd..117d6ed0cf17 100644 --- a/gcc/testsuite/gcc.target/i386/pr65753.c +++ b/gcc/testsuite/gcc.target/i386/pr65753.c @@ -1,4 +1,5 @@ /* { dg-do compile } */ +/* { dg-require-effective-target fpic } */ /* { dg-options "-fPIC -O2" } */ /* { dg-final { scan-assembler-not "call" } } */ =20 diff --git a/gcc/testsuite/gcc.target/i386/pr65915.c = b/gcc/testsuite/gcc.target/i386/pr65915.c index 990c5aaa2e4d..6588de47c4a2 100644 --- a/gcc/testsuite/gcc.target/i386/pr65915.c +++ b/gcc/testsuite/gcc.target/i386/pr65915.c @@ -1,4 +1,5 @@ /* { dg-do run } */ +/* { dg-require-effective-target fpic } */ /* { dg-options "-O2 -mavx512f -fpic -mcmodel=3Dmedium" } */ /* { dg-require-effective-target avx512f } */ /* { dg-require-effective-target lp64 } */ diff --git a/gcc/testsuite/gcc.target/i386/pr66232-5.c = b/gcc/testsuite/gcc.target/i386/pr66232-5.c index 87f93802694f..76705a529848 100644 --- a/gcc/testsuite/gcc.target/i386/pr66232-5.c +++ b/gcc/testsuite/gcc.target/i386/pr66232-5.c @@ -1,5 +1,6 @@ /* { dg-do compile { target { ! ia32 } } } */ /* { dg-require-effective-target maybe_x32 } */ +/* { dg-require-effective-target fpic } */ /* { dg-options "-O2 -fpic -mx32" } */ =20 extern void (*bar) (void); diff --git a/gcc/testsuite/gcc.target/i386/pr66334.c = b/gcc/testsuite/gcc.target/i386/pr66334.c index 97dfecc8725c..19c2396073cd 100644 --- a/gcc/testsuite/gcc.target/i386/pr66334.c +++ b/gcc/testsuite/gcc.target/i386/pr66334.c @@ -1,5 +1,6 @@ /* { dg-do compile } */ /* { dg-require-effective-target ia32 } */ +/* { dg-require-effective-target fpic } */ /* { dg-options "-O2 -fpic -fexceptions -fasynchronous-unwind-tables" } = */ /* { dg-final { scan-assembler "movl\[ \\t\].+, %ebx" } } */ extern int foo (int); diff --git a/gcc/testsuite/gcc.target/i386/pr66819-2.c = b/gcc/testsuite/gcc.target/i386/pr66819-2.c index 9de4f97a9063..ad2a33e7fd24 100644 --- a/gcc/testsuite/gcc.target/i386/pr66819-2.c +++ b/gcc/testsuite/gcc.target/i386/pr66819-2.c @@ -1,4 +1,5 @@ /* { dg-do compile { target ia32 } } */ +/* { dg-require-effective-target fpic } */ /* { dg-options "-fPIC -O2 -mregparm=3D3" } */ /* { dg-final { scan-assembler-not "call" } } */ =20 diff --git a/gcc/testsuite/gcc.target/i386/pr67265.c = b/gcc/testsuite/gcc.target/i386/pr67265.c index 2671acc043ad..1708d537b98a 100644 --- a/gcc/testsuite/gcc.target/i386/pr67265.c +++ b/gcc/testsuite/gcc.target/i386/pr67265.c @@ -3,6 +3,7 @@ =20 /* { dg-do compile } */ /* { dg-require-stack-check "" } */ +/* { dg-require-effective-target fpic } */ /* { dg-options "-O -fstack-check -fPIC" } */ =20 int a, b, c, d, e; diff --git a/gcc/testsuite/gcc.target/i386/pr81481.c = b/gcc/testsuite/gcc.target/i386/pr81481.c index a5b936fdacc1..49f7821ea5be 100644 --- a/gcc/testsuite/gcc.target/i386/pr81481.c +++ b/gcc/testsuite/gcc.target/i386/pr81481.c @@ -1,5 +1,6 @@ /* { dg-do compile } */ /* { dg-require-effective-target ssse3 } */ +/* { dg-require-effective-target fpic } */ /* { dg-options "-O2 -fpic -mssse3" } */ /* { dg-final { scan-assembler-not "pshufb\[ \t\]\\(%esp\\)" } } */ #include diff --git a/gcc/testsuite/gcc.target/i386/pr83994.c = b/gcc/testsuite/gcc.target/i386/pr83994.c index dc0b7cb44c44..1eb47e3cf0a2 100644 --- a/gcc/testsuite/gcc.target/i386/pr83994.c +++ b/gcc/testsuite/gcc.target/i386/pr83994.c @@ -1,4 +1,5 @@ /* { dg-do compile } */ +/* { dg-require-effective-target fpic } */ /* { dg-options "-O2 -march=3Di686 -fpic -fstack-clash-protection" } */ /* { dg-require-effective-target ia32 } */ =20 --=20 2.17.1 --Apple-Mail=_7B1C53FB-CA2C-41E6-B437-1F7E724F8733--