From: Richard Biener <richard.guenther@gmail.com>
To: "Martin Liška" <mliska@suse.cz>
Cc: gcc-patches@gcc.gnu.org, Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [PATCH] profile-count: fix /= and *= operators
Date: Fri, 24 Jun 2022 10:38:09 +0200 [thread overview]
Message-ID: <FA4ACB05-5D2C-4D10-A095-93D6AC3B4A0F@gmail.com> (raw)
In-Reply-To: <cfed4047-6ffb-7c43-ac14-436a5b0c8760@suse.cz>
> Am 24.06.2022 um 10:14 schrieb Martin Liška <mliska@suse.cz>:
>
> Hi.
>
> As noticed in the PR, I wrongly introduced /= and *= operators.
> Problem was that these operators need to modify *this object.
>
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>
> Ready to be installed?
Ok
> Thanks,
> Martin
>
> PR middle-end/106059
>
> gcc/ChangeLog:
>
> * profile-count.h: *= and /= operators need to modify this
> object.
> ---
> gcc/profile-count.h | 20 ++++++++++++--------
> 1 file changed, 12 insertions(+), 8 deletions(-)
>
> diff --git a/gcc/profile-count.h b/gcc/profile-count.h
> index be6e2d57cf7..141a8827001 100644
> --- a/gcc/profile-count.h
> +++ b/gcc/profile-count.h
> @@ -605,9 +605,10 @@ public:
> return apply_scale (num, 1);
> }
>
> - profile_probability operator*= (int64_t den) const
> + profile_probability operator*= (int64_t num)
> {
> - return *this * den;
> + *this = apply_scale (num, 1);
> + return *this;
> }
>
> profile_probability operator/ (int64_t den) const
> @@ -615,9 +616,10 @@ public:
> return apply_scale (1, den);
> }
>
> - profile_probability operator/= (int64_t den) const
> + profile_probability operator/= (int64_t den)
> {
> - return *this / den;
> + *this = apply_scale (1, den);
> + return *this;
> }
>
> /* Get the value of the count. */
> @@ -1017,9 +1019,10 @@ public:
> return apply_scale (num, 1);
> }
>
> - profile_count operator*= (int64_t den) const
> + profile_count operator*= (int64_t num)
> {
> - return *this * den;
> + *this = apply_scale (num, 1);
> + return *this;
> }
>
> profile_count operator/ (int64_t den) const
> @@ -1027,9 +1030,10 @@ public:
> return apply_scale (1, den);
> }
>
> - profile_count operator/= (int64_t den) const
> + profile_count operator/= (int64_t den)
> {
> - return *this / den;
> + *this = apply_scale (1, den);
> + return *this;
> }
>
> /* Return true when value is not zero and can be used for scaling.
> --
> 2.36.1
>
prev parent reply other threads:[~2022-06-24 8:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 8:13 Martin Liška
2022-06-24 8:38 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FA4ACB05-5D2C-4D10-A095-93D6AC3B4A0F@gmail.com \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).