From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 5DECE3857B9D for ; Sun, 3 Dec 2023 18:59:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5DECE3857B9D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5DECE3857B9D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701629993; cv=none; b=wv4bSBYKQhP5Jvab3S77N4IvWIqOefrQWy033TXU0Bvcl1wfXGxdrZOnG0Wru7HyK2qstEnpwt/zS8h7Hdk08PhgPMCbsVIhGwu2ZfKzq3xNBNdTqXa77hbuN8QWbMh47upVRrg8NiJaEj/PCsYK4TW4ohQHy9LqwGFtxMHtkQs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701629993; c=relaxed/simple; bh=v/5cpFgvRhpdD60KhjIeC4sAHvQrNHD9Vu5u2TV/T20=; h=DKIM-Signature:DKIM-Signature:From:Mime-Version:Subject:Date: Message-Id:To; b=uCB/+4h9S+wx2flKKlsehzQnAe4tWATgbulHK5fEs43UC8PFNt3RLD27ps7tdrR6ZrY58qainy+al7tVnWDD5li85hFhn0V2634YB2loIU5zEt4bDiRZOVB1KcpVTYBf0y6zKZwrgAGU8CH6hzgTmiy/W705maUT/D7k2QtNksQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 28BDE21EBE; Sun, 3 Dec 2023 18:59:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1701629991; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2G6pNDU8CUERB6LYnP/Me7ZfxNbvXuXvyCwB925sDqY=; b=RIfixhrDZmPxZcxE8I293Fmbsl+1mLS8GYon53MdqjEVvvZUdPy4V0TUT5HxUpXYv4hTUF 7j5U7CgHfkeGIKKwTtMhosAwY+GbmoPWWZZv0qlpOTx5CTSJVoJHUzPWdV8sIziJvh4gR6 ck7u8mEnLIOpbjwb1hSVlsiGmlj7mqg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1701629991; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2G6pNDU8CUERB6LYnP/Me7ZfxNbvXuXvyCwB925sDqY=; b=Deasz8nw5etMFq6DARyWMnzlk9oGGyx97ZB0lwFbEcolrGJyAVFfsZpfB9FiZXQjWjIDTq HuCQgHlxaVnIl9AQ== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 09CCE138E6; Sun, 3 Dec 2023 18:59:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id wjAYAifQbGXCCgAAn2gu4w (envelope-from ); Sun, 03 Dec 2023 18:59:51 +0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Richard Biener Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] testsuite: Fix up gcc.target/aarch64/pr112406.c for modern C [PR112406] Date: Sun, 3 Dec 2023 19:59:40 +0100 Message-Id: References: Cc: Robin Dapp , fweimer@tucnak.zalov.cz, gcc-patches@gcc.gnu.org In-Reply-To: To: Jakub Jelinek X-Mailer: iPhone Mail (21B101) Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spamd-Result: default: False [0.70 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; MV_CASE(0.50)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.999]; BAYES_HAM(-0.00)[22.31%]; DBL_BLOCKED_OPENRESOLVER(0.00)[gcc.target:url]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[gmail.com,tucnak.zalov.cz,gcc.gnu.org]; RCVD_TLS_ALL(0.00)[]; SUSPICIOUS_RECIPS(1.50)[] X-Spam-Score: 0.70 X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Am 03.12.2023 um 19:32 schrieb Jakub Jelinek : >=20 > =EF=BB=BFOn Fri, Nov 17, 2023 at 02:04:01PM +0100, Robin Dapp wrote: >>> Yes, your version is also OK. >>=20 >> The attached was bootstrapped and regtested on aarch64, x86 and >> regtested on riscv. Going to commit it later unless somebody objects. >=20 > Unfortunately the aarch64/pr112406.c was reduced too much and is rejected > since the switch to modern C patchset. >=20 > The following patch fixes that, I've verified the testcase > before/after the changes still ICEs in r14-5563 and doesn't with > r14-5564 and after the changes compiles fine with even latest trunk. > Everything admittedly with a cross-compiler, but that shouldn't change > anything. >=20 > Ok for trunk? Ok > Note, one of the modern C changes is that at least when people use > cvise/creduce/delta scripts which ensure no further errors are introduced > during the reduction then expected originally such reductions will not > appear anymore. >=20 > 2023-12-03 Jakub Jelinek >=20 > PR middle-end/112406 > * gcc.target/aarch64/pr112406.c (MagickPixelPacket): Add missing > semicolon. > (GetImageChannelMoments_image): Avoid using implicit int. > (SetMagickPixelPacket): Use void return type instead of implicit int. > (GetImageChannelMoments): Likewise. Use __builtin_atan instead of > atan. >=20 > --- gcc/testsuite/gcc.target/aarch64/pr112406.c.jj 2023-11-18 09:35:20.= 944084686 +0100 > +++ gcc/testsuite/gcc.target/aarch64/pr112406.c 2023-12-03 19:05:16.109= 365791 +0100 > @@ -2,10 +2,10 @@ > /* { dg-options "-march=3Darmv8-a+sve -w -Ofast" } */ >=20 > typedef struct { > - int red > + int red; > } MagickPixelPacket; >=20 > -GetImageChannelMoments_image, GetImageChannelMoments_image_0, > +int GetImageChannelMoments_image, GetImageChannelMoments_image_0, > GetImageChannelMoments___trans_tmp_1, GetImageChannelMoments_M11_0, > GetImageChannelMoments_pixel_3, GetImageChannelMoments_y, > GetImageChannelMoments_p; > @@ -15,10 +15,12 @@ double GetImageChannelMoments_M00_0, Get >=20 > MagickPixelPacket GetImageChannelMoments_pixel; >=20 > +void > SetMagickPixelPacket(int color, MagickPixelPacket *pixel) { > pixel->red =3D color; > } >=20 > +void > GetImageChannelMoments() { > for (; GetImageChannelMoments_y; GetImageChannelMoments_y++) { > SetMagickPixelPacket(GetImageChannelMoments_p, > @@ -33,5 +35,5 @@ GetImageChannelMoments() { > GetImageChannelMoments_M01_1 +=3D > GetImageChannelMoments_y * GetImageChannelMoments_p++; > } > - GetImageChannelMoments___trans_tmp_1 =3D atan(GetImageChannelMoments_M1= 1_0); > + GetImageChannelMoments___trans_tmp_1 =3D __builtin_atan(GetImageChannel= Moments_M11_0); > } >=20 >=20 > Jakub >=20