public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Olivier Hainque <hainque@adacore.com>
To: Iain Sandoe <idsandoe@googlemail.com>
Cc: Olivier Hainque <hainque@adacore.com>,
	Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>,
	Pierre-Marie de Rodat <derodat@adacore.com>,
	gcc-patches@gcc.gnu.org
Subject: Re: [Ada] Fix 32/64bit mistake on SYSTEM_INFO component in s-win32
Date: Fri, 20 Sep 2019 12:21:00 -0000	[thread overview]
Message-ID: <FC61E839-FACE-4CEF-A2E3-D8B9C6D3EADC@adacore.com> (raw)
In-Reply-To: <302E3795-445D-48F8-82A8-0A645D2D21E4@adacore.com>

[-- Attachment #1: Type: text/plain, Size: 629 bytes --]

Hello Iain & Rainer,

> On 19 Sep 2019, at 18:40, Olivier Hainque <hainque@adacore.com> wrote:

>>> Given that the test cannot compile on anything but *-*-linux* and
>>> *-*-mingw*, I'd rather restrict the test to those two (or more targets
>>> that decide to implement the missing interface).

> Works for me as well.
[...]
> We can take care of adding the required filter.

I have just committed the attached patch to this effect.
Thanks again for the heads-up!

Cheers,

Olivier

---

2019-09-20  Olivier Hainque  <hainque@adacore.com>

	testsuite/

        * gnat.dg/system_info1.adb: Restrict to *-*-linux* and *-*-mingw*.


[-- Attachment #2: system_info1.diff --]
[-- Type: application/octet-stream, Size: 738 bytes --]

diff --git a/gcc/testsuite/gnat.dg/system_info1.adb b/gcc/testsuite/gnat.dg/system_info1.adb
index 493a18e..e299bc4 100644
--- a/gcc/testsuite/gnat.dg/system_info1.adb
+++ b/gcc/testsuite/gnat.dg/system_info1.adb
@@ -1,4 +1,9 @@
---  { dg-do run }
+--  A basic test initially intended to check that
+--  System.Task_Info.Number_Of_Processors yields sensible results on
+--  both 32bit and 64bit Windows. Additional configurations where the
+--  feature was verified to work can opt-in.
+
+--  { dg-do run { target *-*-mingw* *-*-linux* } }
 
 with System.Multiprocessors;
 with System.Task_Info;
@@ -20,4 +25,4 @@ begin
    if Nprocs /= Integer (Ncpus) then
       raise Program_Error;
    end if;
-end;
\ No newline at end of file
+end;

  reply	other threads:[~2019-09-20 12:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-18  8:40 Pierre-Marie de Rodat
2019-09-19 14:41 ` Iain Sandoe
2019-09-19 14:56   ` Rainer Orth
2019-09-19 15:02     ` Iain Sandoe
2019-09-19 16:40       ` Olivier Hainque
2019-09-20 12:21         ` Olivier Hainque [this message]
2019-09-20 13:02           ` Rainer Orth
2019-09-20 14:12             ` Arnaud Charlet
2019-09-23 10:12               ` Rainer Orth
2019-09-20 12:57       ` Rainer Orth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FC61E839-FACE-4CEF-A2E3-D8B9C6D3EADC@adacore.com \
    --to=hainque@adacore.com \
    --cc=derodat@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=idsandoe@googlemail.com \
    --cc=ro@CeBiTec.Uni-Bielefeld.DE \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).