From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp001-out.apm-internet.net (smtp001-out.apm-internet.net [85.119.248.222]) by sourceware.org (Postfix) with ESMTPS id 765793858438 for ; Wed, 28 Sep 2022 06:37:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 765793858438 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sandoe.co.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=sandoe.co.uk Received: (qmail 54039 invoked from network); 28 Sep 2022 06:37:24 -0000 X-APM-Out-ID: 16643470435403 X-APM-Authkey: 257869/1(257869/1) 5 Received: from unknown (HELO ?192.168.1.95?) (81.138.1.83) by smtp001.apm-internet.net with SMTP; 28 Sep 2022 06:37:24 -0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Subject: Re: [PATCH] rs6000: Rework option -mpowerpc64 handling [PR106680] From: Iain Sandoe In-Reply-To: <9d9f1f43-b528-387d-45a7-1d89400de0fc@linux.ibm.com> Date: Wed, 28 Sep 2022 07:37:23 +0100 Cc: GCC Patches , Peter Bergner , David Edelsohn , Segher Boessenkool Content-Transfer-Encoding: quoted-printable Message-Id: References: <9d9f1f43-b528-387d-45a7-1d89400de0fc@linux.ibm.com> To: "Kewen.Lin" X-Mailer: Apple Mail (2.3608.120.23.2.7) X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00,KAM_COUK,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Kewen, > On 28 Sep 2022, at 06:30, Kewen.Lin via Gcc-patches = wrote: > PR106680 shows that -m32 -mpowerpc64 is different from > -mpowerpc64 -m32, this is determined by the way how we > handle option powerpc64 in rs6000_handle_option. >=20 > Segher pointed out this difference should be taken as > a bug and we should ensure that option powerpc64 is > independent of -m32/-m64. So this patch removes the > handlings in rs6000_handle_option and add some necessary > supports in rs6000_option_override_internal instead. >=20 > With this patch, if users specify -m{no-,}powerpc64, the > specified value is honoured, otherwise, for 64bit it > always enables OPTION_MASK_POWERPC64 while for 32bit > it disables OPTION_MASK_POWERPC64 if OS_MISSING_POWERPC64. >=20 > Bootstrapped and regress-tested on: > - powerpc64-linux-gnu P7 and P8 {-m64,-m32} > - powerpc64le-linux-gnu P9 and P10 > - powerpc-ibm-aix7.2.0.0 {-maix64,-maix32} >=20 > Hi Iain, could you help to test this on darwin to ensure > it won't break darwin's build and new tests are fine? > Thanks in advance! Will do, it will take a day or so, thanks, Iain