From: "Moore, Catherine" <Catherine_Moore@mentor.com>
To: Robert Suchanek <Robert.Suchanek@imgtec.com>,
Richard Sandiford <richard.sandiford@arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Matthew Fortune <Matthew.Fortune@imgtec.com>
Subject: RE: [PATCH MIPS RFA] Regression cleanup for nan2008 toolchain
Date: Tue, 03 Feb 2015 17:42:00 -0000 [thread overview]
Message-ID: <FD3DCEAC5B03E9408544A1E416F11242018914C0ED@NA-MBX-04.mgc.mentorg.com> (raw)
In-Reply-To: <B5E67142681B53468FAF6B7C31356562441195CD@hhmail02.hh.imgtec.org>
> -----Original Message-----
> From: Robert Suchanek [mailto:Robert.Suchanek@imgtec.com]
> Sent: Monday, February 02, 2015 11:18 AM
> To: Richard Sandiford
> Cc: gcc-patches@gcc.gnu.org; Matthew Fortune; Moore, Catherine
> Subject: RE: [PATCH MIPS RFA] Regression cleanup for nan2008 toolchain
>
>
> > Please could you add a comment explaining that the mips_nanlegacy is
> > there because of the #include of system headers that might not compile
> > with -mnan=legacy? I agree that that's a good reason, but it's not
> > obvious without a comment. (And without a comment this could start a
> > precendent of things being skipped in cases where the mips.exp options
> > machinery could be updated instead.)
> >
>
> True. Clarification added.
>
> Ok for trunk?
>
> Regards,
> Robert
>
> 2015-02-02 Robert Suchanek <robert.suchanek@imgtec.com>
>
> * gcc.target/mips/loongson-simd.c: Update comment to clarify the need
> for mips_nanlegacy target.
>
> diff --git a/gcc/testsuite/gcc.target/mips/loongson-simd.c
> b/gcc/testsuite/gcc.target/mips/loongson-simd.c
> index 949632e..9c3ebce 100644
> --- a/gcc/testsuite/gcc.target/mips/loongson-simd.c
> +++ b/gcc/testsuite/gcc.target/mips/loongson-simd.c
> @@ -21,7 +21,10 @@ along with GCC; see the file COPYING3. If not see
> /* { dg-do run } */
> /* loongson.h does not handle or check for MIPS16ness or
> microMIPSness. There doesn't seem any good reason for it to, given
> - that the Loongson processors do not support either. */
> + that the Loongson processors do not support either. The effective target
> + mips_nanlegacy is required for a toolchain without the legacy NaN support
> + because inclusion of some system headers e.g. stdint.h will fail due to not
> + finding stubs-o32_hard.h. */
> /* { dg-require-effective-target mips_nanlegacy } */
> /* { dg-options "isa=loongson -mhard-float -mno-micromips -mno-mips16 -
> flax-vector-conversions" } */
>
Thanks for the update. This is OK.
Catherine
next prev parent reply other threads:[~2015-02-03 17:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 13:23 Robert Suchanek
2015-01-26 17:25 ` Moore, Catherine
2015-01-28 10:27 ` Robert Suchanek
2015-01-31 19:20 ` Richard Sandiford
2015-02-02 16:18 ` Robert Suchanek
2015-02-03 17:42 ` Moore, Catherine [this message]
2015-02-04 11:36 ` Robert Suchanek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FD3DCEAC5B03E9408544A1E416F11242018914C0ED@NA-MBX-04.mgc.mentorg.com \
--to=catherine_moore@mentor.com \
--cc=Matthew.Fortune@imgtec.com \
--cc=Robert.Suchanek@imgtec.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).