From: "Moore, Catherine" <Catherine_Moore@mentor.com>
To: "sellcey@imgtec.com" <sellcey@imgtec.com>,
"Kumar, Venkataramanan" <Venkataramanan.Kumar@amd.com>
Cc: Segher Boessenkool <segher@kernel.crashing.org>,
"Jeff Law (law@redhat.com)" <law@redhat.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"maxim.kuvyrkov@linaro.org" <maxim.kuvyrkov@linaro.org>,
Matthew Fortune <Matthew.Fortune@imgtec.com>
Subject: RE: [RFC]: Remove Mem/address type assumption in combiner
Date: Tue, 12 May 2015 22:02:00 -0000 [thread overview]
Message-ID: <FD3DCEAC5B03E9408544A1E416F112420192C2DBA4@NA-MBX-01.mgc.mentorg.com> (raw)
In-Reply-To: <1431449431.14613.240.camel@ubuntu-sellcey>
> -----Original Message-----
> From: Steve Ellcey [mailto:sellcey@imgtec.com]
> Sent: Tuesday, May 12, 2015 12:51 PM
> To: Kumar, Venkataramanan
> Cc: Segher Boessenkool; Jeff Law (law@redhat.com); gcc-
> patches@gcc.gnu.org; maxim.kuvyrkov@linaro.org; Matthew Fortune;
> Moore, Catherine
> Subject: RE: [RFC]: Remove Mem/address type assumption in combiner
>
> On Tue, 2015-05-12 at 05:21 +0000, Kumar, Venkataramanan wrote:
> > Hi Steve,
> >
> > Yes this is expected. As Segher pointed out, we need to change .md
> > patterns in target to be based on shifts instead of mults.
> >
> > Regards,
> > Venkat.
>
> Here is my patch to change this. I tested it with the mips-mti-linux-gnu and
> mips-mti-elf targets and it fixed the MIPS specific tests that were scanning
> for an lsa instruction and it also had no regressions.
>
> Since the lsa instruction was the only one using the 'y' operand code and my
> change got rid of the only use of it, I removed it as part of this patch.
>
> Matthew or Catherine is this OK to checkin?
>
> 2015-05-12 Steve Ellcey <sellcey@imgtec.com>
>
> * config/mips/mips.c (mips_print_operand): Remove 'y' operand
> code.
> * config/mips/mips.md (<GPR:d>lsa): Rewrite with shift operator.
> * config/mips/predicates.md (const_immlsa_operand): Remove log
> call.
>
This is OK.
Catherine
next prev parent reply other threads:[~2015-05-12 21:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 9:29 Kumar, Venkataramanan
2015-04-29 17:38 ` Segher Boessenkool
2015-04-29 19:23 ` Jeff Law
2015-05-01 15:18 ` Segher Boessenkool
2015-05-05 16:14 ` Kumar, Venkataramanan
2015-05-05 17:15 ` Segher Boessenkool
2015-05-07 11:01 ` Kumar, Venkataramanan
2015-05-11 17:50 ` Steve Ellcey
2015-05-11 18:27 ` Segher Boessenkool
2015-05-11 19:44 ` Steve Ellcey
2015-05-11 19:46 ` Jeff Law
2015-05-11 19:46 ` Jeff Law
2015-05-11 20:17 ` Matthew Fortune
2015-05-11 20:30 ` Segher Boessenkool
2015-05-11 20:54 ` Matthew Fortune
2015-05-12 6:43 ` Kumar, Venkataramanan
2015-05-12 16:57 ` Steve Ellcey
2015-05-12 22:02 ` Moore, Catherine [this message]
2015-05-16 6:09 ` Hans-Peter Nilsson
2015-05-16 14:36 ` Segher Boessenkool
2015-05-16 16:43 ` Hans-Peter Nilsson
2015-05-16 17:40 ` Segher Boessenkool
2015-05-17 8:53 ` Hans-Peter Nilsson
2015-05-17 13:32 ` Segher Boessenkool
2015-05-17 13:48 ` Hans-Peter Nilsson
2015-05-19 17:30 ` Jeff Law
2015-04-29 19:22 ` Jeff Law
2015-04-29 19:31 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FD3DCEAC5B03E9408544A1E416F112420192C2DBA4@NA-MBX-01.mgc.mentorg.com \
--to=catherine_moore@mentor.com \
--cc=Matthew.Fortune@imgtec.com \
--cc=Venkataramanan.Kumar@amd.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=maxim.kuvyrkov@linaro.org \
--cc=segher@kernel.crashing.org \
--cc=sellcey@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).