From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54842 invoked by alias); 31 Jul 2015 19:10:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 54816 invoked by uid 89); 31 Jul 2015 19:10:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 31 Jul 2015 19:09:59 +0000 Received: from svr-orw-fem-03.mgc.mentorg.com ([147.34.97.39]) by relay1.mentorg.com with esmtp id 1ZLFgp-0003QL-JM from Catherine_Moore@mentor.com ; Fri, 31 Jul 2015 12:09:55 -0700 Received: from NA-MBX-04.mgc.mentorg.com ([169.254.4.176]) by SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) with mapi id 14.03.0224.002; Fri, 31 Jul 2015 12:09:55 -0700 From: "Moore, Catherine" To: Simon Dardis , "gcc-patches@gcc.gnu.org" Subject: RE: [PATCH][MIPS] Scheduler fix for the 74k & 24k. Date: Fri, 31 Jul 2015 19:50:00 -0000 Message-ID: References: In-Reply-To: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2015-07/txt/msg02711.txt.bz2 > -----Original Message----- > From: gcc-patches-owner@gcc.gnu.org [mailto:gcc-patches- > owner@gcc.gnu.org] On Behalf Of Simon Dardis > Sent: Tuesday, July 21, 2015 6:39 AM > To: gcc-patches@gcc.gnu.org > Subject: [PATCH][MIPS] Scheduler fix for the 74k & 24k. >=20 > Hello, >=20 > This patch fixes a bug with the 74k & 24k schedulers. >=20 > Back in 2006 (2ca4dfa486bd358c6e466328839977250d160393) a > mips_store_data_bypass_p was added to the mips backend. Unfortunately > it was defined in terms of !store_data_bypass_p, though it was correctly > used for the sb1 processor pipeline descriptor at that time. Later during= a > code-cleanup in 2012 (e053750d33e14ca245e14e1c467709a9bf6c6282) the 24k > & 74k bypasses were changed from the correct !store_data_bypass_p to > !mips_store_data_bypass_p. This lead to those bypasses having inverted > guard conditions. >=20 > This patch brings mips_store_data_bypass_p into line with its comments and > the comments of store_data_bypass_p. It also corrects the sb1's pipeline > description. >=20 > Thanks, > Simon >=20 > gcc/ > * config/mips/mips.c (mips_store_data_bypass_p): Bring code into > line with comments. > * config/mips/sb1.md: Update usage of mips_store_data_bypass_p. >=20 This patch is OK.