From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69958 invoked by alias); 7 Oct 2015 20:18:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 69949 invoked by uid 89); 7 Oct 2015 20:18:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Oct 2015 20:18:38 +0000 Received: from svr-orw-fem-03.mgc.mentorg.com ([147.34.97.39]) by relay1.mentorg.com with esmtp id 1ZjvAY-00054M-Vj from Catherine_Moore@mentor.com ; Wed, 07 Oct 2015 13:18:35 -0700 Received: from NA-MBX-04.mgc.mentorg.com ([169.254.4.113]) by SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) with mapi id 14.03.0224.002; Wed, 7 Oct 2015 13:18:34 -0700 From: "Moore, Catherine" To: "sellcey@imgtec.com" CC: Matthew Fortune , GCC Patches Subject: RE: [PATCH, MIPS] Frame header optimization for MIPS O32 ABI Date: Wed, 07 Oct 2015 20:18:00 -0000 Message-ID: References: <1441315205.26051.58.camel@ubuntu-sellcey> <6D39441BF12EF246A7ABCE6654B02353212620CB@LEMAIL01.le.imgtec.org> <1441994741.16610.6.camel@ubuntu-sellcey> <1444065344.8687.224.camel@ubuntu-sellcey> <6D39441BF12EF246A7ABCE6654B0235361C0A62A@LEMAIL01.le.imgtec.org> <1444168969.8687.268.camel@ubuntu-sellcey> In-Reply-To: <1444168969.8687.268.camel@ubuntu-sellcey> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2015-10/txt/msg00751.txt.bz2 > -----Original Message----- > From: Steve Ellcey [mailto:sellcey@imgtec.com] > Sent: Tuesday, October 06, 2015 6:03 PM > To: Moore, Catherine > Cc: Matthew Fortune; GCC Patches > Subject: RE: [PATCH, MIPS] Frame header optimization for MIPS O32 ABI >=20 > On Tue, 2015-10-06 at 12:02 +0000, Moore, Catherine wrote: >=20 > > > Moore, Catherine writes: > > > > The patch itself looks good, but the tests that you added need a li= ttle > more > > > work. >=20 > Here is a new patch for just the tests. I added NOMIPS16 and the > -mabi=3D32 flag as Matthew suggested and I also added -mno-abicalls. >=20 > Without the -mno-abicalls the MIPS linux compiler defaulted to > -mabicalls and allocated 32 bytes without the optimization and the MIPS > elf compiler defaulted to -mno-abicalls and allocated 24 bytes without > the optimization. This synchronizes them so they both allocate 24 bytes > without the optimization and 8 bytes with it. Everything should pass > now, it passed for me using mips-mti-linux-gnu and mips-mti-elf. >=20 > Steve Ellcey > sellcey@imgtec.com >=20 >=20 > 2015-10-06 Steve Ellcey >=20 > * gcc.target/mips/mips.exp (mips_option_groups): Add -mframe- > header-opt > and -mno-frame-header-opt options. > * gcc.target/mips/frame-header-1.c: New file. > * gcc.target/mips/frame-header-2.c: New file. > * gcc.target/mips/frame-header-3.c: New file. >=20 >=20 This looks good to go now. Thanks, Catherine