[PATCH] Print relative names in UNSUPPORTED AutoFDO tests

[PATCH] Print relative names in UNSUPPORTED AutoFDO tests

[Yuri Gribov]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

Hi,

This patch fixes AutoFDO Dejagnu tests to print relative filenames
instead of absolute ones when AutoFDO is unsupported. This is to
prevent spurious differences in dg-cmp-results.sh, like this:
  NA->UNSUPPORTED:
/home/yugr/src/gcc-57371/gcc/testsuite/g++.dg/bprob/g++-bprob-1.C
-fauto-profile
  UNSUPPORTED->NA:
/home/yugr/src/gcc/gcc/testsuite/g++.dg/bprob/g++-bprob-1.C
-fauto-profile

Ok for trunk?

-Y

[-- Attachment #2: autofdo-unsup-fix-1.patch --]
[-- Type: application/octet-stream, Size: 1038 bytes --]

2017-07-09  Yury Gribov  <tetra2005@gmail.com>

gcc/testsuite/
        * lib/profopt.exp: Print relative names in UNSUPPORTED
	AutoFDO tests.

diff -rupN gcc/gcc/testsuite/lib/profopt.exp gcc-compare-checks/gcc/testsuite/lib/profopt.exp
--- gcc/gcc/testsuite/lib/profopt.exp	2017-07-09 17:58:39.000000000 +0200
+++ gcc-compare-checks/gcc/testsuite/lib/profopt.exp	2017-07-09 17:53:45.000000000 +0200
@@ -285,7 +285,7 @@ proc auto-profopt-execute { src } {
 
     if { ! [check_profiling_available "-fauto-profile"] } {
         regsub "(?q)$srcdir/" $src "" testcase
-        unsupported "$src -fauto-profile"
+        unsupported "$testcase -fauto-profile"
         return
     }
     set profile_wrapper [profopt-perf-wrapper]
@@ -451,7 +451,7 @@ proc profopt-execute { src } {
 		verbose "Running $cmd"
 		set id [remote_spawn "" $cmd]
 		if { $id < 0 } {
-		    unsupported "$src -fauto-profile: cannot run create_gcov"
+		    unsupported "$testcase -fauto-profile: cannot run create_gcov"
 		    set status "fail"
 		    return
 		}

Re: [PATCH] Print relative names in UNSUPPORTED AutoFDO tests

[Mike Stump]

On Jul 9, 2017, at 12:00 PM, Yuri Gribov <tetra2005@gmail.com> wrote:
> 
> This patch fixes AutoFDO Dejagnu tests to print relative filenames
> instead of absolute ones when AutoFDO is unsupported. This is to
> prevent spurious differences in dg-cmp-results.sh, like this:
>  NA->UNSUPPORTED:
> /home/yugr/src/gcc-57371/gcc/testsuite/g++.dg/bprob/g++-bprob-1.C
> -fauto-profile
>  UNSUPPORTED->NA:
> /home/yugr/src/gcc/gcc/testsuite/g++.dg/bprob/g++-bprob-1.C
> -fauto-profile
> 
> Ok for trunk?

Ok.

Seeing the change in test case name would be useful.  It should have g++.dg/bprob/g++-bprob-1.C in the name, not just g++-bprob-1.C.