* [PATCH] Detangle gcc/configure for Darwin
@ 2016-01-21 14:50 David Edelsohn
2016-01-21 18:12 ` Mike Stump
0 siblings, 1 reply; 2+ messages in thread
From: David Edelsohn @ 2016-01-21 14:50 UTC (permalink / raw)
To: Mike Stump; +Cc: GCC Patches
A gcc/configure stanza to test for PowerPC mfcrf support became
tangled with Darwin test for .machine directive. This patch detangles
and separates the two tests.
I don't have a Darwin system to test.
* configure.ac (gcc_cv_as_powerpc_mfcrf, gcc_cv_as_machine_directive): Detangle.
Okay?
Thanks, David
Index: configure.ac
===================================================================
--- configure.ac (revision 232675)
+++ configure.ac (working copy)
@@ -4172,10 +4172,8 @@
;;
powerpc*-*-*)
+
case $target in
- *-*-aix*) conftest_s=' .machine "pwr5"
- .csect .text[[PR]]
- mfcr 3,128';;
*-*-darwin*)
gcc_GAS_CHECK_FEATURE([.machine directive support],
gcc_cv_as_machine_directive,,,
@@ -4185,7 +4183,14 @@
echo you can get it from:
ftp://gcc.gnu.org/pub/gcc/infrastructure/cctools-528.5.dmg >&2
test x$build = x$target && exit 1
fi
- conftest_s=' .text
+ ;;
+ esac
+
+ case $target in
+ *-*-aix*) conftest_s=' .machine "pwr5"
+ .csect .text[[PR]]
+ mfcr 3,128';;
+ *-*-darwin*) conftest_s=' .text
mfcr r3,128';;
*) conftest_s=' .machine power4
.text
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Detangle gcc/configure for Darwin
2016-01-21 14:50 [PATCH] Detangle gcc/configure for Darwin David Edelsohn
@ 2016-01-21 18:12 ` Mike Stump
0 siblings, 0 replies; 2+ messages in thread
From: Mike Stump @ 2016-01-21 18:12 UTC (permalink / raw)
To: David Edelsohn; +Cc: GCC Patches
On Jan 21, 2016, at 6:50 AM, David Edelsohn <dje.gcc@gmail.com> wrote:
> A gcc/configure stanza to test for PowerPC mfcrf support became
> tangled with Darwin test for .machine directive. This patch detangles
> and separates the two tests.
>
> I don't have a Darwin system to test.
>
> * configure.ac (gcc_cv_as_powerpc_mfcrf, gcc_cv_as_machine_directive): Detangle.
>
> Okay?
Ok.
Would have been slightly easier to back out the patch that went wrong, and review the re-application of that patch as it should have been originally.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-21 18:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-21 14:50 [PATCH] Detangle gcc/configure for Darwin David Edelsohn
2016-01-21 18:12 ` Mike Stump
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).