From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id 02F8B3858C39 for ; Tue, 9 Apr 2024 13:59:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 02F8B3858C39 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=googlemail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 02F8B3858C39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::42a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712671169; cv=none; b=n5jwrLKMyR98E7kDOR9o9t94Xwx+L7Cuq9PBtIFam5oDrKmWZWsRBDunEU+y4ClUYKotPiCRtIJG93fhjNln7hajuXNXBBtidrR1EFtWDC97YvgDXY/eQJbfma0j3V2jok0CsYnH1PB3h+z3oi5Ycg59wnC2Vo5uxB3loZIISH4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712671169; c=relaxed/simple; bh=btHqUyppJbwZ+29l9pBFVGV8mONWDjmyTCHNpo/yHGQ=; h=DKIM-Signature:Mime-Version:Subject:From:Date:Message-Id:To; b=Bgi0U4SU8EyWqBZzqRMFU1szJgcDAHw3Din/6CZ0lCpakfvdYjW8Ie1NCmzUuDuZl5Ykt6W0T7yx8mo6eiABulNJRobsni7otmYoVQyGWTyh6andsj6lslW12NDU5mgHyPIb+IZpskoNFLYQr4ZINMkb9zDuygB15C6qzGRHNes= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-343f1957ffcso2203394f8f.0 for ; Tue, 09 Apr 2024 06:59:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20230601; t=1712671166; x=1713275966; darn=gcc.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=btHqUyppJbwZ+29l9pBFVGV8mONWDjmyTCHNpo/yHGQ=; b=VEQfkM7G6fcTrASNc82pHiWXLqSJrtkEB1Maqrd78ROKrzUxKbVaVqqG3kOPJ9j2O2 wbyfDLFiVLr751OVsOKnSamJRjWIHX0o/K9LF5rKQMRrJL5pDZLnMeRFPYJE14tfguWR ymLyaoRJ0iHIGw0tSi3pAs+lpAMo/DOuZ8XHuZc84lItfddRt4mUOCEBl40iovm/jySu dZhsTcizCdozgF41BzJQ1lQCN7+p9+mZC9lBuJXKm/Ul6DnJ0X96T8iLwt0/R44FwHFV jn+A1/tVJCAWD0Gg6fgOyVjLfDnN9GzZ4eSYbxJVus8hT0ug8T+/K409KF/Up8r3d7MO Eflg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712671166; x=1713275966; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=btHqUyppJbwZ+29l9pBFVGV8mONWDjmyTCHNpo/yHGQ=; b=jg0yJLxRCoVdg6tSZZ2tUqlz1bv8KvQ0M+ZEaG+JwK+p7jquRNMPpGRbcUbkEQI4nS 6kdFwAN7eHslf7aU/kJmGr4DTsatsYIez7p6Br/ifaF6Ir+8GsdjVaS0ug793Pfk3eNu HTMCUyfFuNfMmU9FCb7Pi8DTooC/BKl7OgmrGgSfKeuWWtrkY0VccwWjP8Wg2ZfpKala cEnqigzvX3sPY5EfJOQrYq1wQdrf22APcLb09czrx6qYK3202PD6Odkch85U6h3WsYNs pQ1YExfsw9y42mH1+rwYpkpSUPwjKqxtbV1zyt5nfuZePig7mBCU8KY3Up+FXiK3pzpE LUXQ== X-Forwarded-Encrypted: i=1; AJvYcCUctJeJStxgDqrRz+ufEIUuCs38lintW+/J2LCYaxeQPMWsYcpYQeZjp+LRNzjA895UTNQx6gPr11bhf25XFEhwftyI3eyNPQ== X-Gm-Message-State: AOJu0YyZfCLWkibdFxUD3YBwqfP+f3hHcV8CBfal/0YqxQ2raQa+tfkV TkYOsYLxtChQqqdy6TyMb6jFMTW+h86Kdzz8s5zfzb9txfQO7+3R4a0dFaJFFFw= X-Google-Smtp-Source: AGHT+IGw2kfAQxvajhfXDdGRc1aECrui/qTkxNlM8As1hZ9uEOkkOt8VpOSCi3pLNw0irbY4Yz1APw== X-Received: by 2002:a5d:5f90:0:b0:343:8e97:d78c with SMTP id dr16-20020a5d5f90000000b003438e97d78cmr3293788wrb.22.1712671165436; Tue, 09 Apr 2024 06:59:25 -0700 (PDT) Received: from smtpclient.apple (host81-138-1-83.in-addr.btopenworld.com. [81.138.1.83]) by smtp.googlemail.com with ESMTPSA id g19-20020adfa493000000b003464150a642sm785528wrb.108.2024.04.09.06.59.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Apr 2024 06:59:25 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.8\)) Subject: Re: [PATCH/RFC] On the use of -funreachable-traps to deal with PR 109627 From: Iain Sandoe In-Reply-To: Date: Tue, 9 Apr 2024 14:59:24 +0100 Cc: Richard Biener , Jeff Law , GCC Patches Content-Transfer-Encoding: quoted-printable Message-Id: References: <56A9A5FB-8294-47CB-A6C4-22FD5561C71A@googlemail.com> To: Jakub Jelinek , Jason Merrill X-Mailer: Apple Mail (2.3696.120.41.1.8) X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On 9 Apr 2024, at 08:53, Iain Sandoe wrote: >=20 >=20 >=20 >> On 9 Apr 2024, at 08:48, Jakub Jelinek wrote: >>=20 >> On Tue, Apr 09, 2024 at 09:44:01AM +0200, Richard Biener wrote: >>> (why not do it at each such switch?) >>=20 >> Because the traps would then be added even to the bbs which later >> end up in the middle of the function. >=20 > If we defer the unreachable =3D> trap change until expand, then it = would > not affect any of the current decisions made by the middle end. >=20 > Since the default expansion of unreachable is to a barrier - would = this > actually make material difference to RTL optimizations? Here is an implementation of this: https://gcc.gnu.org/pipermail/gcc-patches/2024-April/649074.html Taking a solution to PR109267 out of the equation - it would still be = good to get an answer to the original question =E2=80=9Cis = -funreachable-traps behaving as expected=E2=80=9D? (since it does not substitute in the TU we=E2=80=99v= e been discussing) thanks Iain