From: Richard Biener <richard.guenther@gmail.com>
To: Bernd Schmidt <bschmidt@redhat.com>,Uros Bizjak
<ubizjak@gmail.com>,"gcc-patches@gcc.gnu.org"
<gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, rtl-optimization]: Fix PR77452, ICE: in plus_constant, at explow.c
Date: Mon, 05 Sep 2016 11:23:00 -0000 [thread overview]
Message-ID: <FF97CFA4-4E27-4E73-BE87-256C16C28AF9@gmail.com> (raw)
In-Reply-To: <0cbecf48-b40b-844e-63b6-1f6d7ea2fd05@redhat.com>
On September 5, 2016 12:11:47 PM GMT+02:00, Bernd Schmidt <bschmidt@redhat.com> wrote:
>On 09/04/2016 02:12 PM, Uros Bizjak wrote:
>> As shown in the PR [1], combine is able to simplify lowpart
>> CONST_VECTOR constant pool reference to its inner-mode reference.
>> However, plus_constant was not able to extract the constant from
>> narrowed access.
>>
>> Attached patch teaches plus_constant how to handle this situation.
>
>Ok. It looks like accesses to non-lowpart subregs would be handled by
>not optimizing them as well rather than crashing.
Are we missing similar handling for complex integer constants?
Richard.
>
>Bernd
prev parent reply other threads:[~2016-09-05 10:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-04 14:08 Uros Bizjak
2016-09-05 10:34 ` Bernd Schmidt
2016-09-05 11:23 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FF97CFA4-4E27-4E73-BE87-256C16C28AF9@gmail.com \
--to=richard.guenther@gmail.com \
--cc=bschmidt@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).