From: Bernd Edlinger <bernd.edlinger@hotmail.de>
To: Jakub Jelinek <jakub@redhat.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Bernd Schmidt <bschmidt@redhat.com>,
Eric Botcazou <ebotcazou@adacore.com>,
"jason@redhat.com" <jason@redhat.com>
Subject: Re: [PATCH] Fix expansion of TREE_ADDRESSABLE bitwise copies (PR c++/69851)
Date: Fri, 19 Feb 2016 20:46:00 -0000 [thread overview]
Message-ID: <HE1PR07MB09054C502BCAF9899B73519AE4A00@HE1PR07MB0905.eurprd07.prod.outlook.com> (raw)
In-Reply-To: <20160219200842.GZ3017@tucnak.redhat.com>
Excuse me,
I have still another question.
Why are you adding braces here?
+ || (bitsize % BITS_PER_UNIT != 0)
+ || (bitpos % BITS_PER_UNIT != 0)
+ || (compare_tree_int (DECL_SIZE (TREE_OPERAND (exp, 1)), bitsize)
+ != 0)))
I think everywhere in that function we omit braces around == terms
inside || terms even long ones.
|| a == b
|| c == d
|| e == f)
I know many like to add braces here, but GCC does not do that
unnecessarily, right?
Thanks
Bernd.
next prev parent reply other threads:[~2016-02-19 20:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 18:42 Bernd Edlinger
2016-02-19 19:04 ` Jakub Jelinek
2016-02-19 20:04 ` Bernd Edlinger
2016-02-19 20:08 ` Jakub Jelinek
2016-02-19 20:18 ` Bernd Edlinger
2016-02-19 20:45 ` Bernd Edlinger
2016-02-19 20:57 ` Jakub Jelinek
2016-02-19 20:46 ` Bernd Edlinger [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-02-19 14:03 Jakub Jelinek
2016-02-19 18:30 ` Jason Merrill
2016-02-19 18:41 ` Jakub Jelinek
2016-02-19 19:00 ` Jason Merrill
2016-02-19 19:07 ` Jakub Jelinek
2016-02-19 19:11 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HE1PR07MB09054C502BCAF9899B73519AE4A00@HE1PR07MB0905.eurprd07.prod.outlook.com \
--to=bernd.edlinger@hotmail.de \
--cc=bschmidt@redhat.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).