From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113168 invoked by alias); 17 Sep 2019 17:18:10 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 113150 invoked by uid 89); 17 Sep 2019 17:18:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.7 required=5.0 tests=AWL,BAYES_00,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com Received: from mail-eopbgr150042.outbound.protection.outlook.com (HELO EUR01-DB5-obe.outbound.protection.outlook.com) (40.107.15.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Sep 2019 17:18:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6ir0WUgKIX+hpg4VNHy+mRUv5yUpuHjBO5D1dvXq2mU=; b=PckeWwN7NvILpzRdJRTSRvBNhsYgPKjQnQbGnCW2YG2FDflaTZGvF+/DIUr8JpD9drqHr50xIl0ZIkV0b4UFyZ/cKDPpYYCNVpLz0eq3ZykV2w/ZnR/aVOML2Nr7vTsKrm2fdSAD2gEELDO10WV4NXKiN3g+u1yzAcNjfOVpMeo= Received: from VI1PR08CA0224.eurprd08.prod.outlook.com (2603:10a6:802:15::33) by AM6PR08MB4486.eurprd08.prod.outlook.com (2603:10a6:20b:72::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.17; Tue, 17 Sep 2019 17:18:04 +0000 Received: from VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::208) by VI1PR08CA0224.outlook.office365.com (2603:10a6:802:15::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2263.17 via Frontend Transport; Tue, 17 Sep 2019 17:18:04 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;gcc.gnu.org; dmarc=none action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT009.mail.protection.outlook.com (10.152.18.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2263.14 via Frontend Transport; Tue, 17 Sep 2019 17:18:02 +0000 Received: ("Tessian outbound 55d20e99e8e2:v31"); Tue, 17 Sep 2019 17:18:02 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 73647c52ca2da088 X-CR-MTA-TID: 64aa7808 Received: from d19bf8cc433e.2 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.5.50]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id CBB04AD5-724C-47CF-BB13-E65BBBB89C82.1; Tue, 17 Sep 2019 17:17:57 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2050.outbound.protection.outlook.com [104.47.5.50]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d19bf8cc433e.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 17 Sep 2019 17:17:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QJcvx6YhiUcIp9s1Bv9LofIScCUFRD9qc+Ov9p+1xFluG2tTyI1vmFmY8EuMX4caDB0uE6awjxH/b7AUk3QjrHonMYgSlk2J7WfE+gbCxevhd34XGheCfk0SnBrKk9d6zDStW8Mm1ywdgWqE/7fHW5XboOrgZvEOzjgvR7kDk79SmSwF7pbF9gk+0mKBQzOi8e72T2fIRgWo4xRYCOMZPFVIrpOklircZ/DsGL3uaDTCw/i2Jl5UrjbaNw6Am6c9jlI3IheRbNpMowkiEIJ03I1TYsCVFqLYeZI9SAsLKq3zE1mPCXgis5BRiOgStGocT+syQpJO88/wdVcYk3GqvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6ir0WUgKIX+hpg4VNHy+mRUv5yUpuHjBO5D1dvXq2mU=; b=A2/GUt6SqGpKdir4WkR/bJFgs7KSn/kyigK2Cl3kqm1R1a2odXeLVJ00L0Jmo9grqKtSRDlYkVKIOdvlSzwRa7He8wY/g4bvaAJFrG6KyjIOHhDxwgOui+Dv+cG0DOhxHDjCAtyKlh7e2SzjG/ppdRxOABA4ph5INzgr8wKrlbMQLJP+fWPxy6LATRnMG0zCERAW0JNAOBCByI6/Ejoh8Y7qRKfIBEE4PPbzVToxccNkJ3sSa3nqrs0KqBWv2REcpXSe6aVoXAdRBklTRF5dr7ilw70lxzzZxhXuylnazGK+YJAzOiaQRJEt9gMsJztKZMd+/XZUleImJkzlhHMLBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6ir0WUgKIX+hpg4VNHy+mRUv5yUpuHjBO5D1dvXq2mU=; b=PckeWwN7NvILpzRdJRTSRvBNhsYgPKjQnQbGnCW2YG2FDflaTZGvF+/DIUr8JpD9drqHr50xIl0ZIkV0b4UFyZ/cKDPpYYCNVpLz0eq3ZykV2w/ZnR/aVOML2Nr7vTsKrm2fdSAD2gEELDO10WV4NXKiN3g+u1yzAcNjfOVpMeo= Received: from HE1PR0801MB2121.eurprd08.prod.outlook.com (10.168.146.10) by HE1PR0801MB1818.eurprd08.prod.outlook.com (10.168.143.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.23; Tue, 17 Sep 2019 17:17:54 +0000 Received: from HE1PR0801MB2121.eurprd08.prod.outlook.com ([fe80::48e:e338:40d:c424]) by HE1PR0801MB2121.eurprd08.prod.outlook.com ([fe80::48e:e338:40d:c424%5]) with mapi id 15.20.2263.023; Tue, 17 Sep 2019 17:17:54 +0000 From: Wilco Dijkstra To: Richard Biener CC: Prathamesh Kulkarni , GCC Patches , Kyrylo Tkachov , Richard Earnshaw , nd Subject: Re: [PATCH][ARM] Enable code hoisting with -Os (PR80155) Date: Tue, 17 Sep 2019 17:18:00 -0000 Message-ID: References: , In-Reply-To: Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Wilco.Dijkstra@arm.com; X-Microsoft-Antispam-Untrusted: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600167)(711020)(4605104)(1401327)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);SRVR:HE1PR0801MB1818; X-MS-Exchange-PUrlCount: 1 x-ms-exchange-transport-forked: True x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(346002)(39860400002)(376002)(366004)(396003)(136003)(189003)(199004)(9686003)(6506007)(7696005)(99286004)(76176011)(446003)(4744005)(102836004)(71190400001)(66446008)(52536014)(54906003)(11346002)(316002)(186003)(5660300002)(476003)(486006)(26005)(256004)(14444005)(66066001)(14454004)(81166006)(7736002)(4326008)(6436002)(478600001)(55016002)(305945005)(6306002)(6246003)(33656002)(966005)(81156014)(25786009)(76116006)(66556008)(64756008)(71200400001)(66476007)(6916009)(6116002)(3846002)(229853002)(8936002)(74316002)(2906002)(86362001)(8676002)(66946007);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0801MB1818;H:HE1PR0801MB2121.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: m8QiYkxjfWqat9X0Ohj4rYCU4SOWtRAprMXGe5BjUhM3s7qztowuTS4NudED1+DsZRq2FxmDdTFuV8XgmSmMf6p9QCKVRd2nwJlIvF3hX7aEBkI7ZcQRlVnkF1bLoakf4DmUtDBIN+LWC+GhK4Io8GQRqNgwPVr+4EDbu0Q6wHqIODqRA5nLKYkiYxVqkghkdrS7iL1wrKFSJMU4XWhcpLFM1YCCppbHMV4YOxWvl0LtVWSSMEJ5CnHyqWiiV2qZd49pT5+ck7nm7Bx4RRAfVZEGY2j8+/I38nkQeFV8laUe35W8rANzOF6oNoU9usYzReOagrGhkiV+B5HVrQ5VZczOYPWPOhxTRAqjJyfqHmfBX/B0TyuSaU7654wZ3KEKEnfYZQQNMoHpC1qlCt+Og+TCE5LTWvTu/eC/xWVa8XI= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Wilco.Dijkstra@arm.com; Return-Path: Wilco.Dijkstra@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 1c4c022b-7280-4029-fd8c-08d73b92fa59 X-SW-Source: 2019-09/txt/msg01020.txt.bz2 Hi Richard, > The issue with the bugzilla is that it lacked appropriate testcase(s) and= thus > it is now a mess.=A0 There are clear testcases (maybe not in the benchmar= ks you Agreed - it's not clear whether any of the proposed changes would actually help the original issue. My patch absolutely does. > care about) that benefit from code hoisting as enabler, mainly when contr= ol > flow can be then converted to data flow.=A0 Also note that "size optimiza= tions" > are important for all cases where followup transforms have size limits on= the IL > in place. The gain from -fcode-hoisting is about 0.2% overall on Thumb-2. Ie. it's de= finitely useful, but there are much larger gains to be had from other tweaks [1]. So= we can live without it until a better solution is found. [1] https://gcc.gnu.org/ml/gcc-patches/2019-07/msg01739.html Wilco