* [PATCH][Arm] Test suite failures resulting from deprecation of -mstructure-size-boundary
@ 2017-08-05 23:25 Michael Collison
2017-08-07 12:32 ` Richard Earnshaw (lists)
0 siblings, 1 reply; 6+ messages in thread
From: Michael Collison @ 2017-08-05 23:25 UTC (permalink / raw)
To: gcc-patches, Richard Earnshaw; +Cc: nd
[-- Attachment #1: Type: text/plain, Size: 629 bytes --]
This patch fixes test case failures on arm targets due to '-mstructure-size-boundary' being deprecated. The test cases were failing because a warning was being issued and due to the fact that the size of packed and unpacked structures is the same after deprecating '-mstructure-size-boundary'
Okay for trunk?
2017-08-04 Michael Collison <michael.collison@arm.com>
* testsuite/g++.dg/ext/packed8.C: Skip test for arm_eabi.
* testsuite/g++.dg/init/array16.C: Skip test for arm_eabi.
* testsuite/g++.dg/other/crash-4.C: Skip test for arm_eabi.
* testsuite/gcc.dg/builtin-stringop-chk-1.c: Skip test for arm_eabi.
[-- Attachment #2: pr7519v1.patch --]
[-- Type: application/octet-stream, Size: 2556 bytes --]
diff --git a/gcc/testsuite/g++.dg/ext/packed8.C b/gcc/testsuite/g++.dg/ext/packed8.C
index 91ee8b3..4f38670 100644
--- a/gcc/testsuite/g++.dg/ext/packed8.C
+++ b/gcc/testsuite/g++.dg/ext/packed8.C
@@ -2,7 +2,7 @@
// NOTE: This test assumes packed structure layout differs from unpacked
// structure layout. This isn't true, e.g., with the default
// arm-none-elf options.
-// { dg-options "-mstructure-size-boundary=8" { target arm*-*-* } }
+// { dg-skip-if "packed structure layout does not differ from unpacked layout" { { arm*-*-* } && { arm_eabi } } }
class A
{
diff --git a/gcc/testsuite/g++.dg/init/array16.C b/gcc/testsuite/g++.dg/init/array16.C
index 188d1a8..3334e25 100644
--- a/gcc/testsuite/g++.dg/init/array16.C
+++ b/gcc/testsuite/g++.dg/init/array16.C
@@ -1,7 +1,7 @@
// Causes timeout for the MMIX simulator on a 3GHz P4 and we can't
// have "compile" for some targets and "run" for others.
// { dg-do run { target { ! mmix-*-* } } }
-// { dg-options "-mstructure-size-boundary=8" { target arm*-*-* } }
+// { dg-skip-if "packed structure layout does not differ from unpacked layout" { { arm*-*-* } && { arm_eabi } } }
// Copyright (C) 2004 Free Software Foundation, Inc.
// Contributed by Nathan Sidwell 8 Dec 2004 <nathan@codesourcery.com>
diff --git a/gcc/testsuite/g++.dg/other/crash-4.C b/gcc/testsuite/g++.dg/other/crash-4.C
index a77fe05..8530f44 100644
--- a/gcc/testsuite/g++.dg/other/crash-4.C
+++ b/gcc/testsuite/g++.dg/other/crash-4.C
@@ -7,7 +7,7 @@
// NOTE: This test assumes packed structure layout differs from unpacked
// structure layout. This isn't true, e.g., with the default
// arm-none-elf options.
-// { dg-options "-mstructure-size-boundary=8" { target arm*-*-* } }
+// { dg-skip-if "packed structure layout does not differ" { { arm*-*-* } && { arm_eabi } } }
struct a
{
diff --git a/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c b/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c
index e265578..d839097 100644
--- a/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c
+++ b/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c
@@ -2,7 +2,7 @@
are emitted properly. */
/* { dg-do compile } */
/* { dg-options "-O2 -Wno-format -std=gnu99 -ftrack-macro-expansion=0" } */
-/* { dg-additional-options "-mstructure-size-boundary=8" { target arm*-*-* } } */
+// { dg-skip-if "packed structure layout does not differ from unpacked layout" { { arm*-*-* } && { arm_eabi } } }
// { dg-skip-if "packed attribute missing for t" { "epiphany-*-*" } }
extern void abort (void);
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][Arm] Test suite failures resulting from deprecation of -mstructure-size-boundary
2017-08-05 23:25 [PATCH][Arm] Test suite failures resulting from deprecation of -mstructure-size-boundary Michael Collison
@ 2017-08-07 12:32 ` Richard Earnshaw (lists)
2017-08-09 5:25 ` Michael Collison
0 siblings, 1 reply; 6+ messages in thread
From: Richard Earnshaw (lists) @ 2017-08-07 12:32 UTC (permalink / raw)
To: Michael Collison, gcc-patches; +Cc: nd
On 06/08/17 00:25, Michael Collison wrote:
> This patch fixes test case failures on arm targets due to '-mstructure-size-boundary' being deprecated. The test cases were failing because a warning was being issued and due to the fact that the size of packed and unpacked structures is the same after deprecating '-mstructure-size-boundary'
>
> Okay for trunk?
>
> 2017-08-04 Michael Collison <michael.collison@arm.com>
>
> * testsuite/g++.dg/ext/packed8.C: Skip test for arm_eabi.
> * testsuite/g++.dg/init/array16.C: Skip test for arm_eabi.
> * testsuite/g++.dg/other/crash-4.C: Skip test for arm_eabi.
> * testsuite/gcc.dg/builtin-stringop-chk-1.c: Skip test for arm_eabi.
>
Why would we want to skip the test? If you delete the
-mstructure-size-boundary option then the test should execute correctly
on all arm-eabi based platforms and most other ARM platforms where 8 was
the default anyway.
R.
>
> pr7519v1.patch
>
>
> diff --git a/gcc/testsuite/g++.dg/ext/packed8.C b/gcc/testsuite/g++.dg/ext/packed8.C
> index 91ee8b3..4f38670 100644
> --- a/gcc/testsuite/g++.dg/ext/packed8.C
> +++ b/gcc/testsuite/g++.dg/ext/packed8.C
> @@ -2,7 +2,7 @@
> // NOTE: This test assumes packed structure layout differs from unpacked
> // structure layout. This isn't true, e.g., with the default
> // arm-none-elf options.
> -// { dg-options "-mstructure-size-boundary=8" { target arm*-*-* } }
> +// { dg-skip-if "packed structure layout does not differ from unpacked layout" { { arm*-*-* } && { arm_eabi } } }
>
> class A
> {
> diff --git a/gcc/testsuite/g++.dg/init/array16.C b/gcc/testsuite/g++.dg/init/array16.C
> index 188d1a8..3334e25 100644
> --- a/gcc/testsuite/g++.dg/init/array16.C
> +++ b/gcc/testsuite/g++.dg/init/array16.C
> @@ -1,7 +1,7 @@
> // Causes timeout for the MMIX simulator on a 3GHz P4 and we can't
> // have "compile" for some targets and "run" for others.
> // { dg-do run { target { ! mmix-*-* } } }
> -// { dg-options "-mstructure-size-boundary=8" { target arm*-*-* } }
> +// { dg-skip-if "packed structure layout does not differ from unpacked layout" { { arm*-*-* } && { arm_eabi } } }
>
> // Copyright (C) 2004 Free Software Foundation, Inc.
> // Contributed by Nathan Sidwell 8 Dec 2004 <nathan@codesourcery.com>
> diff --git a/gcc/testsuite/g++.dg/other/crash-4.C b/gcc/testsuite/g++.dg/other/crash-4.C
> index a77fe05..8530f44 100644
> --- a/gcc/testsuite/g++.dg/other/crash-4.C
> +++ b/gcc/testsuite/g++.dg/other/crash-4.C
> @@ -7,7 +7,7 @@
> // NOTE: This test assumes packed structure layout differs from unpacked
> // structure layout. This isn't true, e.g., with the default
> // arm-none-elf options.
> -// { dg-options "-mstructure-size-boundary=8" { target arm*-*-* } }
> +// { dg-skip-if "packed structure layout does not differ" { { arm*-*-* } && { arm_eabi } } }
>
> struct a
> {
> diff --git a/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c b/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c
> index e265578..d839097 100644
> --- a/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c
> +++ b/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c
> @@ -2,7 +2,7 @@
> are emitted properly. */
> /* { dg-do compile } */
> /* { dg-options "-O2 -Wno-format -std=gnu99 -ftrack-macro-expansion=0" } */
> -/* { dg-additional-options "-mstructure-size-boundary=8" { target arm*-*-* } } */
> +// { dg-skip-if "packed structure layout does not differ from unpacked layout" { { arm*-*-* } && { arm_eabi } } }
> // { dg-skip-if "packed attribute missing for t" { "epiphany-*-*" } }
>
> extern void abort (void);
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH][Arm] Test suite failures resulting from deprecation of -mstructure-size-boundary
2017-08-07 12:32 ` Richard Earnshaw (lists)
@ 2017-08-09 5:25 ` Michael Collison
2017-08-09 8:21 ` Richard Earnshaw (lists)
0 siblings, 1 reply; 6+ messages in thread
From: Michael Collison @ 2017-08-09 5:25 UTC (permalink / raw)
To: Richard Earnshaw, gcc-patches; +Cc: nd
Because the comment (for example) in g+=.dg/ext/packed8.C says
// NOTE: This test assumes packed structure layout differs from unpacked
// structure layout. This isn't true, e.g., with the default
// arm-none-elf options.
If we could just delete the -mstructure-size-boundary=8 option why was it added in the first place?
-----Original Message-----
From: Richard Earnshaw (lists) [mailto:Richard.Earnshaw@arm.com]
Sent: Monday, August 7, 2017 5:32 AM
To: Michael Collison <Michael.Collison@arm.com>; gcc-patches@gcc.gnu.org
Cc: nd <nd@arm.com>
Subject: Re: [PATCH][Arm] Test suite failures resulting from deprecation of -mstructure-size-boundary
On 06/08/17 00:25, Michael Collison wrote:
> This patch fixes test case failures on arm targets due to '-mstructure-size-boundary' being deprecated. The test cases were failing because a warning was being issued and due to the fact that the size of packed and unpacked structures is the same after deprecating '-mstructure-size-boundary'
>
> Okay for trunk?
>
> 2017-08-04 Michael Collison <michael.collison@arm.com>
>
> * testsuite/g++.dg/ext/packed8.C: Skip test for arm_eabi.
> * testsuite/g++.dg/init/array16.C: Skip test for arm_eabi.
> * testsuite/g++.dg/other/crash-4.C: Skip test for arm_eabi.
> * testsuite/gcc.dg/builtin-stringop-chk-1.c: Skip test for arm_eabi.
>
Why would we want to skip the test? If you delete the -mstructure-size-boundary option then the test should execute correctly on all arm-eabi based platforms and most other ARM platforms where 8 was the default anyway.
R.
>
> pr7519v1.patch
>
>
> diff --git a/gcc/testsuite/g++.dg/ext/packed8.C
> b/gcc/testsuite/g++.dg/ext/packed8.C
> index 91ee8b3..4f38670 100644
> --- a/gcc/testsuite/g++.dg/ext/packed8.C
> +++ b/gcc/testsuite/g++.dg/ext/packed8.C
> @@ -2,7 +2,7 @@
> // NOTE: This test assumes packed structure layout differs from unpacked
> // structure layout. This isn't true, e.g., with the default
> // arm-none-elf options.
> -// { dg-options "-mstructure-size-boundary=8" { target arm*-*-* } }
> +// { dg-skip-if "packed structure layout does not differ from
> +unpacked layout" { { arm*-*-* } && { arm_eabi } } }
>
> class A
> {
> diff --git a/gcc/testsuite/g++.dg/init/array16.C
> b/gcc/testsuite/g++.dg/init/array16.C
> index 188d1a8..3334e25 100644
> --- a/gcc/testsuite/g++.dg/init/array16.C
> +++ b/gcc/testsuite/g++.dg/init/array16.C
> @@ -1,7 +1,7 @@
> // Causes timeout for the MMIX simulator on a 3GHz P4 and we can't
> // have "compile" for some targets and "run" for others.
> // { dg-do run { target { ! mmix-*-* } } } -// { dg-options
> "-mstructure-size-boundary=8" { target arm*-*-* } }
> +// { dg-skip-if "packed structure layout does not differ from
> +unpacked layout" { { arm*-*-* } && { arm_eabi } } }
>
> // Copyright (C) 2004 Free Software Foundation, Inc.
> // Contributed by Nathan Sidwell 8 Dec 2004 <nathan@codesourcery.com>
> diff --git a/gcc/testsuite/g++.dg/other/crash-4.C
> b/gcc/testsuite/g++.dg/other/crash-4.C
> index a77fe05..8530f44 100644
> --- a/gcc/testsuite/g++.dg/other/crash-4.C
> +++ b/gcc/testsuite/g++.dg/other/crash-4.C
> @@ -7,7 +7,7 @@
> // NOTE: This test assumes packed structure layout differs from unpacked
> // structure layout. This isn't true, e.g., with the default
> // arm-none-elf options.
> -// { dg-options "-mstructure-size-boundary=8" { target arm*-*-* } }
> +// { dg-skip-if "packed structure layout does not differ" { {
> +arm*-*-* } && { arm_eabi } } }
>
> struct a
> {
> diff --git a/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c
> b/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c
> index e265578..d839097 100644
> --- a/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c
> +++ b/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c
> @@ -2,7 +2,7 @@
> are emitted properly. */
> /* { dg-do compile } */
> /* { dg-options "-O2 -Wno-format -std=gnu99
> -ftrack-macro-expansion=0" } */
> -/* { dg-additional-options "-mstructure-size-boundary=8" { target
> arm*-*-* } } */
> +// { dg-skip-if "packed structure layout does not differ from
> +unpacked layout" { { arm*-*-* } && { arm_eabi } } }
> // { dg-skip-if "packed attribute missing for t" { "epiphany-*-*" } }
>
> extern void abort (void);
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][Arm] Test suite failures resulting from deprecation of -mstructure-size-boundary
2017-08-09 5:25 ` Michael Collison
@ 2017-08-09 8:21 ` Richard Earnshaw (lists)
2017-08-09 15:06 ` Michael Collison
0 siblings, 1 reply; 6+ messages in thread
From: Richard Earnshaw (lists) @ 2017-08-09 8:21 UTC (permalink / raw)
To: Michael Collison, gcc-patches; +Cc: nd
On 09/08/17 06:25, Michael Collison wrote:
> Because the comment (for example) in g+=.dg/ext/packed8.C says
>
> // NOTE: This test assumes packed structure layout differs from unpacked
> // structure layout. This isn't true, e.g., with the default
> // arm-none-elf options.
>
> If we could just delete the -mstructure-size-boundary=8 option why was it added in the first place?
>
Because the comment it out of date. It was added at a time when the
default structure size boundard (pre eabi) was 32.
R.
> -----Original Message-----
> From: Richard Earnshaw (lists) [mailto:Richard.Earnshaw@arm.com]
> Sent: Monday, August 7, 2017 5:32 AM
> To: Michael Collison <Michael.Collison@arm.com>; gcc-patches@gcc.gnu.org
> Cc: nd <nd@arm.com>
> Subject: Re: [PATCH][Arm] Test suite failures resulting from deprecation of -mstructure-size-boundary
>
> On 06/08/17 00:25, Michael Collison wrote:
>> This patch fixes test case failures on arm targets due to '-mstructure-size-boundary' being deprecated. The test cases were failing because a warning was being issued and due to the fact that the size of packed and unpacked structures is the same after deprecating '-mstructure-size-boundary'
>>
>> Okay for trunk?
>>
>> 2017-08-04 Michael Collison <michael.collison@arm.com>
>>
>> * testsuite/g++.dg/ext/packed8.C: Skip test for arm_eabi.
>> * testsuite/g++.dg/init/array16.C: Skip test for arm_eabi.
>> * testsuite/g++.dg/other/crash-4.C: Skip test for arm_eabi.
>> * testsuite/gcc.dg/builtin-stringop-chk-1.c: Skip test for arm_eabi.
>>
>
> Why would we want to skip the test? If you delete the -mstructure-size-boundary option then the test should execute correctly on all arm-eabi based platforms and most other ARM platforms where 8 was the default anyway.
>
> R.
>
>>
>> pr7519v1.patch
>>
>>
>> diff --git a/gcc/testsuite/g++.dg/ext/packed8.C
>> b/gcc/testsuite/g++.dg/ext/packed8.C
>> index 91ee8b3..4f38670 100644
>> --- a/gcc/testsuite/g++.dg/ext/packed8.C
>> +++ b/gcc/testsuite/g++.dg/ext/packed8.C
>> @@ -2,7 +2,7 @@
>> // NOTE: This test assumes packed structure layout differs from unpacked
>> // structure layout. This isn't true, e.g., with the default
>> // arm-none-elf options.
>> -// { dg-options "-mstructure-size-boundary=8" { target arm*-*-* } }
>> +// { dg-skip-if "packed structure layout does not differ from
>> +unpacked layout" { { arm*-*-* } && { arm_eabi } } }
>>
>> class A
>> {
>> diff --git a/gcc/testsuite/g++.dg/init/array16.C
>> b/gcc/testsuite/g++.dg/init/array16.C
>> index 188d1a8..3334e25 100644
>> --- a/gcc/testsuite/g++.dg/init/array16.C
>> +++ b/gcc/testsuite/g++.dg/init/array16.C
>> @@ -1,7 +1,7 @@
>> // Causes timeout for the MMIX simulator on a 3GHz P4 and we can't
>> // have "compile" for some targets and "run" for others.
>> // { dg-do run { target { ! mmix-*-* } } } -// { dg-options
>> "-mstructure-size-boundary=8" { target arm*-*-* } }
>> +// { dg-skip-if "packed structure layout does not differ from
>> +unpacked layout" { { arm*-*-* } && { arm_eabi } } }
>>
>> // Copyright (C) 2004 Free Software Foundation, Inc.
>> // Contributed by Nathan Sidwell 8 Dec 2004 <nathan@codesourcery.com>
>> diff --git a/gcc/testsuite/g++.dg/other/crash-4.C
>> b/gcc/testsuite/g++.dg/other/crash-4.C
>> index a77fe05..8530f44 100644
>> --- a/gcc/testsuite/g++.dg/other/crash-4.C
>> +++ b/gcc/testsuite/g++.dg/other/crash-4.C
>> @@ -7,7 +7,7 @@
>> // NOTE: This test assumes packed structure layout differs from unpacked
>> // structure layout. This isn't true, e.g., with the default
>> // arm-none-elf options.
>> -// { dg-options "-mstructure-size-boundary=8" { target arm*-*-* } }
>> +// { dg-skip-if "packed structure layout does not differ" { {
>> +arm*-*-* } && { arm_eabi } } }
>>
>> struct a
>> {
>> diff --git a/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c
>> b/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c
>> index e265578..d839097 100644
>> --- a/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c
>> +++ b/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c
>> @@ -2,7 +2,7 @@
>> are emitted properly. */
>> /* { dg-do compile } */
>> /* { dg-options "-O2 -Wno-format -std=gnu99
>> -ftrack-macro-expansion=0" } */
>> -/* { dg-additional-options "-mstructure-size-boundary=8" { target
>> arm*-*-* } } */
>> +// { dg-skip-if "packed structure layout does not differ from
>> +unpacked layout" { { arm*-*-* } && { arm_eabi } } }
>> // { dg-skip-if "packed attribute missing for t" { "epiphany-*-*" } }
>>
>> extern void abort (void);
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH][Arm] Test suite failures resulting from deprecation of -mstructure-size-boundary
2017-08-09 8:21 ` Richard Earnshaw (lists)
@ 2017-08-09 15:06 ` Michael Collison
2017-08-09 16:11 ` Richard Earnshaw (lists)
0 siblings, 1 reply; 6+ messages in thread
From: Michael Collison @ 2017-08-09 15:06 UTC (permalink / raw)
To: Richard Earnshaw, gcc-patches; +Cc: nd
[-- Attachment #1: Type: text/plain, Size: 5616 bytes --]
Patch updated to remove -mstructure-size-boundary from tests based on comments from Richard. Outdated comments also removed.
Okay for trunk?
2017-08-01 Michael Collison <michael.collison@arm.com>
* testsuite/g++.dg/ext/packed8.C: Remove -mstructure-size boundary
option and fix comment.
* testsuite/g++.dg/init/array16.C: Remove -mstructure-size boundary
option and fix comment.
* testsuite/g++.dg/other/crash-4.C: Remove -mstructure-size boundary
option and fix comment.
* testsuite/gcc.dg/builtin-stringop-chk-1.c: Remove
-mstructure-size boundary option.
-----Original Message-----
From: Richard Earnshaw (lists) [mailto:Richard.Earnshaw@arm.com]
Sent: Wednesday, August 9, 2017 1:21 AM
To: Michael Collison <Michael.Collison@arm.com>; gcc-patches@gcc.gnu.org
Cc: nd <nd@arm.com>
Subject: Re: [PATCH][Arm] Test suite failures resulting from deprecation of -mstructure-size-boundary
On 09/08/17 06:25, Michael Collison wrote:
> Because the comment (for example) in g+=.dg/ext/packed8.C says
>
> // NOTE: This test assumes packed structure layout differs from unpacked
> // structure layout. This isn't true, e.g., with the default
> // arm-none-elf options.
>
> If we could just delete the -mstructure-size-boundary=8 option why was it added in the first place?
>
Because the comment it out of date. It was added at a time when the default structure size boundard (pre eabi) was 32.
R.
> -----Original Message-----
> From: Richard Earnshaw (lists) [mailto:Richard.Earnshaw@arm.com]
> Sent: Monday, August 7, 2017 5:32 AM
> To: Michael Collison <Michael.Collison@arm.com>;
> gcc-patches@gcc.gnu.org
> Cc: nd <nd@arm.com>
> Subject: Re: [PATCH][Arm] Test suite failures resulting from
> deprecation of -mstructure-size-boundary
>
> On 06/08/17 00:25, Michael Collison wrote:
>> This patch fixes test case failures on arm targets due to '-mstructure-size-boundary' being deprecated. The test cases were failing because a warning was being issued and due to the fact that the size of packed and unpacked structures is the same after deprecating '-mstructure-size-boundary'
>>
>> Okay for trunk?
>>
>> 2017-08-04 Michael Collison <michael.collison@arm.com>
>>
>> * testsuite/g++.dg/ext/packed8.C: Skip test for arm_eabi.
>> * testsuite/g++.dg/init/array16.C: Skip test for arm_eabi.
>> * testsuite/g++.dg/other/crash-4.C: Skip test for arm_eabi.
>> * testsuite/gcc.dg/builtin-stringop-chk-1.c: Skip test for arm_eabi.
>>
>
> Why would we want to skip the test? If you delete the -mstructure-size-boundary option then the test should execute correctly on all arm-eabi based platforms and most other ARM platforms where 8 was the default anyway.
>
> R.
>
>>
>> pr7519v1.patch
>>
>>
>> diff --git a/gcc/testsuite/g++.dg/ext/packed8.C
>> b/gcc/testsuite/g++.dg/ext/packed8.C
>> index 91ee8b3..4f38670 100644
>> --- a/gcc/testsuite/g++.dg/ext/packed8.C
>> +++ b/gcc/testsuite/g++.dg/ext/packed8.C
>> @@ -2,7 +2,7 @@
>> // NOTE: This test assumes packed structure layout differs from unpacked
>> // structure layout. This isn't true, e.g., with the default
>> // arm-none-elf options.
>> -// { dg-options "-mstructure-size-boundary=8" { target arm*-*-* } }
>> +// { dg-skip-if "packed structure layout does not differ from
>> +unpacked layout" { { arm*-*-* } && { arm_eabi } } }
>>
>> class A
>> {
>> diff --git a/gcc/testsuite/g++.dg/init/array16.C
>> b/gcc/testsuite/g++.dg/init/array16.C
>> index 188d1a8..3334e25 100644
>> --- a/gcc/testsuite/g++.dg/init/array16.C
>> +++ b/gcc/testsuite/g++.dg/init/array16.C
>> @@ -1,7 +1,7 @@
>> // Causes timeout for the MMIX simulator on a 3GHz P4 and we can't
>> // have "compile" for some targets and "run" for others.
>> // { dg-do run { target { ! mmix-*-* } } } -// { dg-options
>> "-mstructure-size-boundary=8" { target arm*-*-* } }
>> +// { dg-skip-if "packed structure layout does not differ from
>> +unpacked layout" { { arm*-*-* } && { arm_eabi } } }
>>
>> // Copyright (C) 2004 Free Software Foundation, Inc.
>> // Contributed by Nathan Sidwell 8 Dec 2004
>> <nathan@codesourcery.com> diff --git
>> a/gcc/testsuite/g++.dg/other/crash-4.C
>> b/gcc/testsuite/g++.dg/other/crash-4.C
>> index a77fe05..8530f44 100644
>> --- a/gcc/testsuite/g++.dg/other/crash-4.C
>> +++ b/gcc/testsuite/g++.dg/other/crash-4.C
>> @@ -7,7 +7,7 @@
>> // NOTE: This test assumes packed structure layout differs from unpacked
>> // structure layout. This isn't true, e.g., with the default
>> // arm-none-elf options.
>> -// { dg-options "-mstructure-size-boundary=8" { target arm*-*-* } }
>> +// { dg-skip-if "packed structure layout does not differ" { {
>> +arm*-*-* } && { arm_eabi } } }
>>
>> struct a
>> {
>> diff --git a/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c
>> b/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c
>> index e265578..d839097 100644
>> --- a/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c
>> +++ b/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c
>> @@ -2,7 +2,7 @@
>> are emitted properly. */
>> /* { dg-do compile } */
>> /* { dg-options "-O2 -Wno-format -std=gnu99
>> -ftrack-macro-expansion=0" } */
>> -/* { dg-additional-options "-mstructure-size-boundary=8" { target
>> arm*-*-* } } */
>> +// { dg-skip-if "packed structure layout does not differ from
>> +unpacked layout" { { arm*-*-* } && { arm_eabi } } }
>> // { dg-skip-if "packed attribute missing for t" { "epiphany-*-*" }
>> }
>>
>> extern void abort (void);
>>
>
[-- Attachment #2: pr7519v2.patch --]
[-- Type: application/octet-stream, Size: 2517 bytes --]
diff --git a/gcc/testsuite/g++.dg/ext/packed8.C b/gcc/testsuite/g++.dg/ext/packed8.C
index 91ee8b3..1476010 100644
--- a/gcc/testsuite/g++.dg/ext/packed8.C
+++ b/gcc/testsuite/g++.dg/ext/packed8.C
@@ -1,8 +1,6 @@
// PR c++/18378
// NOTE: This test assumes packed structure layout differs from unpacked
-// structure layout. This isn't true, e.g., with the default
-// arm-none-elf options.
-// { dg-options "-mstructure-size-boundary=8" { target arm*-*-* } }
+// structure layout.
class A
{
diff --git a/gcc/testsuite/g++.dg/init/array16.C b/gcc/testsuite/g++.dg/init/array16.C
index 188d1a8..2f6c63d 100644
--- a/gcc/testsuite/g++.dg/init/array16.C
+++ b/gcc/testsuite/g++.dg/init/array16.C
@@ -1,7 +1,6 @@
// Causes timeout for the MMIX simulator on a 3GHz P4 and we can't
// have "compile" for some targets and "run" for others.
// { dg-do run { target { ! mmix-*-* } } }
-// { dg-options "-mstructure-size-boundary=8" { target arm*-*-* } }
// Copyright (C) 2004 Free Software Foundation, Inc.
// Contributed by Nathan Sidwell 8 Dec 2004 <nathan@codesourcery.com>
@@ -10,8 +9,7 @@
// Origin: Matt LaFary <lafary@activmedia.com>
// NOTE: This test assumes that 4M instances of struct ELT can fit into
-// a 5MB array. This isn't true, e.g., with the default
-// arm-none-elf options.
+// a 5MB array.
struct elt
{
diff --git a/gcc/testsuite/g++.dg/other/crash-4.C b/gcc/testsuite/g++.dg/other/crash-4.C
index a77fe05..db5c5bd 100644
--- a/gcc/testsuite/g++.dg/other/crash-4.C
+++ b/gcc/testsuite/g++.dg/other/crash-4.C
@@ -5,9 +5,7 @@
// Origin: Andrew Pinski pinskia@gcc.gnu.org
// NOTE: This test assumes packed structure layout differs from unpacked
-// structure layout. This isn't true, e.g., with the default
-// arm-none-elf options.
-// { dg-options "-mstructure-size-boundary=8" { target arm*-*-* } }
+// structure layout.
struct a
{
diff --git a/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c b/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c
index e265578..35cc6dc 100644
--- a/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c
+++ b/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c
@@ -2,7 +2,6 @@
are emitted properly. */
/* { dg-do compile } */
/* { dg-options "-O2 -Wno-format -std=gnu99 -ftrack-macro-expansion=0" } */
-/* { dg-additional-options "-mstructure-size-boundary=8" { target arm*-*-* } } */
// { dg-skip-if "packed attribute missing for t" { "epiphany-*-*" } }
extern void abort (void);
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][Arm] Test suite failures resulting from deprecation of -mstructure-size-boundary
2017-08-09 15:06 ` Michael Collison
@ 2017-08-09 16:11 ` Richard Earnshaw (lists)
0 siblings, 0 replies; 6+ messages in thread
From: Richard Earnshaw (lists) @ 2017-08-09 16:11 UTC (permalink / raw)
To: Michael Collison, gcc-patches; +Cc: nd
On 09/08/17 16:05, Michael Collison wrote:
> Patch updated to remove -mstructure-size-boundary from tests based on comments from Richard. Outdated comments also removed.
>
> Okay for trunk?
OK.
R.
>
> 2017-08-01 Michael Collison <michael.collison@arm.com>
>
> * testsuite/g++.dg/ext/packed8.C: Remove -mstructure-size boundary
> option and fix comment.
> * testsuite/g++.dg/init/array16.C: Remove -mstructure-size boundary
> option and fix comment.
> * testsuite/g++.dg/other/crash-4.C: Remove -mstructure-size boundary
> option and fix comment.
> * testsuite/gcc.dg/builtin-stringop-chk-1.c: Remove
> -mstructure-size boundary option.
>
> -----Original Message-----
> From: Richard Earnshaw (lists) [mailto:Richard.Earnshaw@arm.com]
> Sent: Wednesday, August 9, 2017 1:21 AM
> To: Michael Collison <Michael.Collison@arm.com>; gcc-patches@gcc.gnu.org
> Cc: nd <nd@arm.com>
> Subject: Re: [PATCH][Arm] Test suite failures resulting from deprecation of -mstructure-size-boundary
>
> On 09/08/17 06:25, Michael Collison wrote:
>> Because the comment (for example) in g+=.dg/ext/packed8.C says
>>
>> // NOTE: This test assumes packed structure layout differs from unpacked
>> // structure layout. This isn't true, e.g., with the default
>> // arm-none-elf options.
>>
>> If we could just delete the -mstructure-size-boundary=8 option why was it added in the first place?
>>
>
> Because the comment it out of date. It was added at a time when the default structure size boundard (pre eabi) was 32.
>
> R.
>
>> -----Original Message-----
>> From: Richard Earnshaw (lists) [mailto:Richard.Earnshaw@arm.com]
>> Sent: Monday, August 7, 2017 5:32 AM
>> To: Michael Collison <Michael.Collison@arm.com>;
>> gcc-patches@gcc.gnu.org
>> Cc: nd <nd@arm.com>
>> Subject: Re: [PATCH][Arm] Test suite failures resulting from
>> deprecation of -mstructure-size-boundary
>>
>> On 06/08/17 00:25, Michael Collison wrote:
>>> This patch fixes test case failures on arm targets due to '-mstructure-size-boundary' being deprecated. The test cases were failing because a warning was being issued and due to the fact that the size of packed and unpacked structures is the same after deprecating '-mstructure-size-boundary'
>>>
>>> Okay for trunk?
>>>
>>> 2017-08-04 Michael Collison <michael.collison@arm.com>
>>>
>>> * testsuite/g++.dg/ext/packed8.C: Skip test for arm_eabi.
>>> * testsuite/g++.dg/init/array16.C: Skip test for arm_eabi.
>>> * testsuite/g++.dg/other/crash-4.C: Skip test for arm_eabi.
>>> * testsuite/gcc.dg/builtin-stringop-chk-1.c: Skip test for arm_eabi.
>>>
>>
>> Why would we want to skip the test? If you delete the -mstructure-size-boundary option then the test should execute correctly on all arm-eabi based platforms and most other ARM platforms where 8 was the default anyway.
>>
>> R.
>>
>>>
>>> pr7519v1.patch
>>>
>>>
>>> diff --git a/gcc/testsuite/g++.dg/ext/packed8.C
>>> b/gcc/testsuite/g++.dg/ext/packed8.C
>>> index 91ee8b3..4f38670 100644
>>> --- a/gcc/testsuite/g++.dg/ext/packed8.C
>>> +++ b/gcc/testsuite/g++.dg/ext/packed8.C
>>> @@ -2,7 +2,7 @@
>>> // NOTE: This test assumes packed structure layout differs from unpacked
>>> // structure layout. This isn't true, e.g., with the default
>>> // arm-none-elf options.
>>> -// { dg-options "-mstructure-size-boundary=8" { target arm*-*-* } }
>>> +// { dg-skip-if "packed structure layout does not differ from
>>> +unpacked layout" { { arm*-*-* } && { arm_eabi } } }
>>>
>>> class A
>>> {
>>> diff --git a/gcc/testsuite/g++.dg/init/array16.C
>>> b/gcc/testsuite/g++.dg/init/array16.C
>>> index 188d1a8..3334e25 100644
>>> --- a/gcc/testsuite/g++.dg/init/array16.C
>>> +++ b/gcc/testsuite/g++.dg/init/array16.C
>>> @@ -1,7 +1,7 @@
>>> // Causes timeout for the MMIX simulator on a 3GHz P4 and we can't
>>> // have "compile" for some targets and "run" for others.
>>> // { dg-do run { target { ! mmix-*-* } } } -// { dg-options
>>> "-mstructure-size-boundary=8" { target arm*-*-* } }
>>> +// { dg-skip-if "packed structure layout does not differ from
>>> +unpacked layout" { { arm*-*-* } && { arm_eabi } } }
>>>
>>> // Copyright (C) 2004 Free Software Foundation, Inc.
>>> // Contributed by Nathan Sidwell 8 Dec 2004
>>> <nathan@codesourcery.com> diff --git
>>> a/gcc/testsuite/g++.dg/other/crash-4.C
>>> b/gcc/testsuite/g++.dg/other/crash-4.C
>>> index a77fe05..8530f44 100644
>>> --- a/gcc/testsuite/g++.dg/other/crash-4.C
>>> +++ b/gcc/testsuite/g++.dg/other/crash-4.C
>>> @@ -7,7 +7,7 @@
>>> // NOTE: This test assumes packed structure layout differs from unpacked
>>> // structure layout. This isn't true, e.g., with the default
>>> // arm-none-elf options.
>>> -// { dg-options "-mstructure-size-boundary=8" { target arm*-*-* } }
>>> +// { dg-skip-if "packed structure layout does not differ" { {
>>> +arm*-*-* } && { arm_eabi } } }
>>>
>>> struct a
>>> {
>>> diff --git a/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c
>>> b/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c
>>> index e265578..d839097 100644
>>> --- a/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c
>>> +++ b/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c
>>> @@ -2,7 +2,7 @@
>>> are emitted properly. */
>>> /* { dg-do compile } */
>>> /* { dg-options "-O2 -Wno-format -std=gnu99
>>> -ftrack-macro-expansion=0" } */
>>> -/* { dg-additional-options "-mstructure-size-boundary=8" { target
>>> arm*-*-* } } */
>>> +// { dg-skip-if "packed structure layout does not differ from
>>> +unpacked layout" { { arm*-*-* } && { arm_eabi } } }
>>> // { dg-skip-if "packed attribute missing for t" { "epiphany-*-*" }
>>> }
>>>
>>> extern void abort (void);
>>>
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-08-09 16:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-05 23:25 [PATCH][Arm] Test suite failures resulting from deprecation of -mstructure-size-boundary Michael Collison
2017-08-07 12:32 ` Richard Earnshaw (lists)
2017-08-09 5:25 ` Michael Collison
2017-08-09 8:21 ` Richard Earnshaw (lists)
2017-08-09 15:06 ` Michael Collison
2017-08-09 16:11 ` Richard Earnshaw (lists)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).