From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46595 invoked by alias); 9 Aug 2017 05:25:29 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 45988 invoked by uid 89); 9 Aug 2017 05:25:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: EUR03-VE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr50043.outbound.protection.outlook.com (HELO EUR03-VE1-obe.outbound.protection.outlook.com) (40.107.5.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Aug 2017 05:25:14 +0000 Received: from HE1PR0802MB2377.eurprd08.prod.outlook.com (10.172.129.19) by HE1PR0802MB2396.eurprd08.prod.outlook.com (10.175.33.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1320.16; Wed, 9 Aug 2017 05:25:10 +0000 Received: from HE1PR0802MB2377.eurprd08.prod.outlook.com ([fe80::488f:54de:6ff0:fdec]) by HE1PR0802MB2377.eurprd08.prod.outlook.com ([fe80::488f:54de:6ff0:fdec%18]) with mapi id 15.01.1304.027; Wed, 9 Aug 2017 05:25:09 +0000 From: Michael Collison To: Richard Earnshaw , "gcc-patches@gcc.gnu.org" CC: nd Subject: RE: [PATCH][Arm] Test suite failures resulting from deprecation of -mstructure-size-boundary Date: Wed, 09 Aug 2017 05:25:00 -0000 Message-ID: References: <363725a3-b677-85ac-d4d2-95277dbbc524@arm.com> In-Reply-To: <363725a3-b677-85ac-d4d2-95277dbbc524@arm.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Michael.Collison@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;HE1PR0802MB2396;6:Dtd8YL2t2C0V9rzYrCXRADdV8vVVzqlIea7+yO2bUp7Eo+QfmNcvvuC6H4z20ehG+ZvLmJD4xr4B9kN2zEq/wH3mTlm4yyogaZoocolnJ/uCGQ0nLaEzH5UEbor6VDUk1S7icQ7spfuA7q7xYfd7y/ASAL+D+Dvz7SGXw1eHz9UZITtP3JBRvXY4P2wdIz5bPoj3b5Z0To4e+8HlkyVRTizpuG43Wi2aLFAYeKZNCGdY8GSzpKE33WUSW5y0TTuJO7ldAdnvETgAJD52Gm87tQFwTk3B8+TGUo94ypF9D0S+WMtIgqAv9IxWxUHVINlM4zGP9M8mKJtWPoczp3endw==;5:5jzE5Qom0WX0glqwZbh0RA8cHmxhGjAY56jpAmyKlgAgF+XnjImV22KQWLnUpnBeTAWZz3BAZDancde1bDIWn3KPLQ7j5k5ez/UBahxVab/Z8nfhxKzHrBvW748sgQPWsRBKgS6NWcUwy1fcbfLWOg==;24:7Ni0DoEb9H1LOYOY3ko/zzAaa4OXSgYkh3dLdFgay/EOYjmCkWKaXbNBxYMpy/kg0e8U549rlAfZCocj3F+Q52b1lGYg4Ea8t0w6AzXqIAk=;7:5WhnCd71g54om9kqpx+7rfESmsWSweBtOSM2zH0D2DctDxEz3LnAiXTBiKLuoj6b6ebZk1v7zg2dpFeldnN0Wob/FHzF6cOX63sBBQ/tyhP6KSDMWRv/ZYXZFNghEoxvdBR82cME3QSYhyH5/H6vURe+REXl39c8bx/a0iBgQ+lThxwE5/HrmFmHGtBE2em+v7B+vpKtkkaCdvK5lJLoUpTJhT7Xaj9qac1ANJII1D8= x-ms-office365-filtering-correlation-id: 265f5633-f31e-480f-3334-08d4dee700e5 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:HE1PR0802MB2396; x-ms-traffictypediagnostic: HE1PR0802MB2396: nodisclaimer: True x-exchange-antispam-report-test: UriScan:(180628864354917)(22074186197030)(183786458502308); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(100000703101)(100105400095)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(20161123558100)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:HE1PR0802MB2396;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:HE1PR0802MB2396; x-forefront-prvs: 0394259C80 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39840400002)(39450400003)(39410400002)(39850400002)(39400400002)(199003)(13464003)(24454002)(189002)(377454003)(377424004)(8936002)(2900100001)(72206003)(97736004)(2501003)(81156014)(81166006)(5660300001)(8676002)(230783001)(3660700001)(9686003)(74316002)(6116002)(3846002)(478600001)(102836003)(5250100002)(50986999)(55016002)(76176999)(66066001)(33656002)(99286003)(86362001)(68736007)(2950100002)(6506006)(3280700002)(25786009)(7696004)(53546010)(189998001)(6436002)(305945005)(38730400002)(6246003)(53936002)(106356001)(105586002)(14454004)(7736002)(229853002)(54356999)(101416001)(2906002)(4326008)(2004002);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0802MB2396;H:HE1PR0802MB2377.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2017 05:25:09.8196 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2396 X-SW-Source: 2017-08/txt/msg00644.txt.bz2 Because the comment (for example) in g+=3D.dg/ext/packed8.C says // NOTE: This test assumes packed structure layout differs from unpacked // structure layout. This isn't true, e.g., with the default // arm-none-elf options. If we could just delete the -mstructure-size-boundary=3D8 option why was it= added in the first place? -----Original Message----- From: Richard Earnshaw (lists) [mailto:Richard.Earnshaw@arm.com]=20 Sent: Monday, August 7, 2017 5:32 AM To: Michael Collison ; gcc-patches@gcc.gnu.org Cc: nd Subject: Re: [PATCH][Arm] Test suite failures resulting from deprecation of= -mstructure-size-boundary On 06/08/17 00:25, Michael Collison wrote: > This patch fixes test case failures on arm targets due to '-mstructure-si= ze-boundary' being deprecated. The test cases were failing because a warnin= g was being issued and due to the fact that the size of packed and unpacked= structures is the same after deprecating '-mstructure-size-boundary' >=20 > Okay for trunk? >=20 > 2017-08-04 Michael Collison >=20 > * testsuite/g++.dg/ext/packed8.C: Skip test for arm_eabi. > * testsuite/g++.dg/init/array16.C: Skip test for arm_eabi. > * testsuite/g++.dg/other/crash-4.C: Skip test for arm_eabi. > * testsuite/gcc.dg/builtin-stringop-chk-1.c: Skip test for arm_eabi. >=20 Why would we want to skip the test? If you delete the -mstructure-size-bou= ndary option then the test should execute correctly on all arm-eabi based p= latforms and most other ARM platforms where 8 was the default anyway. R. >=20 > pr7519v1.patch >=20 >=20 > diff --git a/gcc/testsuite/g++.dg/ext/packed8.C=20 > b/gcc/testsuite/g++.dg/ext/packed8.C > index 91ee8b3..4f38670 100644 > --- a/gcc/testsuite/g++.dg/ext/packed8.C > +++ b/gcc/testsuite/g++.dg/ext/packed8.C > @@ -2,7 +2,7 @@ > // NOTE: This test assumes packed structure layout differs from unpacked > // structure layout. This isn't true, e.g., with the default > // arm-none-elf options. > -// { dg-options "-mstructure-size-boundary=3D8" { target arm*-*-* } } > +// { dg-skip-if "packed structure layout does not differ from=20 > +unpacked layout" { { arm*-*-* } && { arm_eabi } } } >=20=20 > class A > { > diff --git a/gcc/testsuite/g++.dg/init/array16.C=20 > b/gcc/testsuite/g++.dg/init/array16.C > index 188d1a8..3334e25 100644 > --- a/gcc/testsuite/g++.dg/init/array16.C > +++ b/gcc/testsuite/g++.dg/init/array16.C > @@ -1,7 +1,7 @@ > // Causes timeout for the MMIX simulator on a 3GHz P4 and we can't=20=20 > // have "compile" for some targets and "run" for others. > // { dg-do run { target { ! mmix-*-* } } } -// { dg-options=20 > "-mstructure-size-boundary=3D8" { target arm*-*-* } } > +// { dg-skip-if "packed structure layout does not differ from=20 > +unpacked layout" { { arm*-*-* } && { arm_eabi } } } >=20=20 > // Copyright (C) 2004 Free Software Foundation, Inc. > // Contributed by Nathan Sidwell 8 Dec 2004 =20 > diff --git a/gcc/testsuite/g++.dg/other/crash-4.C=20 > b/gcc/testsuite/g++.dg/other/crash-4.C > index a77fe05..8530f44 100644 > --- a/gcc/testsuite/g++.dg/other/crash-4.C > +++ b/gcc/testsuite/g++.dg/other/crash-4.C > @@ -7,7 +7,7 @@ > // NOTE: This test assumes packed structure layout differs from unpacked > // structure layout. This isn't true, e.g., with the default > // arm-none-elf options. > -// { dg-options "-mstructure-size-boundary=3D8" { target arm*-*-* } } > +// { dg-skip-if "packed structure layout does not differ" { {=20 > +arm*-*-* } && { arm_eabi } } } >=20=20 > struct a > { > diff --git a/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c=20 > b/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c > index e265578..d839097 100644 > --- a/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c > +++ b/gcc/testsuite/gcc.dg/builtin-stringop-chk-1.c > @@ -2,7 +2,7 @@ > are emitted properly. */ > /* { dg-do compile } */ > /* { dg-options "-O2 -Wno-format -std=3Dgnu99=20 > -ftrack-macro-expansion=3D0" } */ > -/* { dg-additional-options "-mstructure-size-boundary=3D8" { target=20 > arm*-*-* } } */ > +// { dg-skip-if "packed structure layout does not differ from=20 > +unpacked layout" { { arm*-*-* } && { arm_eabi } } } > // { dg-skip-if "packed attribute missing for t" { "epiphany-*-*" } } >=20=20 > extern void abort (void); >=20