* [PING][PATCH][compare-elim] Fix PR rtl-optimization/82597
@ 2017-10-26 6:48 Michael Collison
2017-11-19 23:09 ` Jeff Law
0 siblings, 1 reply; 3+ messages in thread
From: Michael Collison @ 2017-10-26 6:48 UTC (permalink / raw)
To: GCC Patches; +Cc: nd, Richard Biener
Ping. Original patch posted here:
https://gcc.gnu.org/ml/gcc-patches/2017-10/msg01317.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PING][PATCH][compare-elim] Fix PR rtl-optimization/82597
2017-10-26 6:48 [PING][PATCH][compare-elim] Fix PR rtl-optimization/82597 Michael Collison
@ 2017-11-19 23:09 ` Jeff Law
2017-11-20 7:32 ` Michael Collison
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Law @ 2017-11-19 23:09 UTC (permalink / raw)
To: Michael Collison, GCC Patches; +Cc: nd, Richard Biener
On 10/25/2017 11:54 PM, Michael Collison wrote:
> Ping. Original patch posted here:
>
> https://gcc.gnu.org/ml/gcc-patches/2017-10/msg01317.html
Is this still needed or was it addressed by the patch Jakub checked in here:
2017-11-01 Jakub Jelinek <jakub@redhat.com>
PR rtl-optimization/82778
PR rtl-optimization/82597
* compare-elim.c (struct comparison): Add in_a_setter field.
(find_comparison_dom_walker::before_dom_children): Remove killed
bitmap and df_simulate_find_defs call, instead walk the defs.
Compute last_setter and initialize in_a_setter. Merge definitions
with first initialization for a few variables.
(try_validate_parallel): Use insn_invalid_p instead of
recog_memoized. Return insn rather than just the pattern.
(try_merge_compare): Fix up comment. Don't uselessly test if
in_a is a REG_P. Use cmp->in_a_setter instead of walking UD
chains.
(execute_compare_elim_after_reload): Remove df_chain_add_problem
call.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PING][PATCH][compare-elim] Fix PR rtl-optimization/82597
2017-11-19 23:09 ` Jeff Law
@ 2017-11-20 7:32 ` Michael Collison
0 siblings, 0 replies; 3+ messages in thread
From: Michael Collison @ 2017-11-20 7:32 UTC (permalink / raw)
To: Jeff Law; +Cc: GCC Patches, nd, Richard Biener
Hi Jeff,
No longer needed. Jakub's patch does the job.
Michael Collison
> On Nov 19, 2017, at 3:50 PM, Jeff Law <law@redhat.com> wrote:
>
>> On 10/25/2017 11:54 PM, Michael Collison wrote:
>> Ping. Original patch posted here:
>>
>> https://gcc.gnu.org/ml/gcc-patches/2017-10/msg01317.html
> Is this still needed or was it addressed by the patch Jakub checked in here:
>
>
>
> 2017-11-01 Jakub Jelinek <jakub@redhat.com>
>
> PR rtl-optimization/82778
> PR rtl-optimization/82597
> * compare-elim.c (struct comparison): Add in_a_setter field.
> (find_comparison_dom_walker::before_dom_children): Remove killed
> bitmap and df_simulate_find_defs call, instead walk the defs.
> Compute last_setter and initialize in_a_setter. Merge definitions
> with first initialization for a few variables.
> (try_validate_parallel): Use insn_invalid_p instead of
> recog_memoized. Return insn rather than just the pattern.
> (try_merge_compare): Fix up comment. Don't uselessly test if
> in_a is a REG_P. Use cmp->in_a_setter instead of walking UD
> chains.
> (execute_compare_elim_after_reload): Remove df_chain_add_problem
> call.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-20 6:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-26 6:48 [PING][PATCH][compare-elim] Fix PR rtl-optimization/82597 Michael Collison
2017-11-19 23:09 ` Jeff Law
2017-11-20 7:32 ` Michael Collison
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).